commit f25d4267a1dfe3dcda2fd1ad72fac20c97366967
author Samuel Tan <samueltan@google.com> Mon Aug 03 16:03:31 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Wed Aug 05 04:18:43 2015 +0000
tree 02d220ad1d21f7fae7feef96b1de2f392e25c12e
parent 820012496f8c171a7c5da4a4904a6ee93bfea2e9

shill: add IcmpSession::IsPacketLossPercentageGreaterThan utility function

Add a utility function that returns true iff
the packet loss recorded in the given IcmpSessionResult
is greater than the given integer percentage value.

BUG=None
TEST=Compile shill and run unit tests.

Change-Id: Ic0278bba026ec93b5ac518ab60523fc805bd14db
Reviewed-on: https://chromium-review.googlesource.com/290407
Reviewed-by: Samuel Tan <samueltan@chromium.org>
Tested-by: Samuel Tan <samueltan@chromium.org>
Commit-Queue: Samuel Tan <samueltan@chromium.org>

icmp_session_unittest.cc

diff --git a/icmp_session_unittest.cc b/icmp_session_unittest.cc
index fb8780e..5c88087 100644
--- a/icmp_session_unittest.cc
+++ b/icmp_session_unittest.cc
@@ -428,4 +428,34 @@
   EXPECT_TRUE(IcmpSession::AnyRepliesReceived(two_sent_one_received));
 }
 
+TEST_F(IcmpSessionTest, IsPacketLossPercentageGreaterThan) {
+  // If we sent no echo requests out, we expect no replies, therefore we have
+  // 0% packet loss.
+  IcmpSession::IcmpSessionResult none_sent_none_received;
+  EXPECT_FALSE(IcmpSession::IsPacketLossPercentageGreaterThan(
+      none_sent_none_received, 0));
+
+  // If we receive all replies, we experience 0% packet loss.
+  IcmpSession::IcmpSessionResult three_sent_three_received;
+  three_sent_three_received.push_back(base::TimeDelta::FromSeconds(10));
+  three_sent_three_received.push_back(base::TimeDelta::FromSeconds(10));
+  three_sent_three_received.push_back(base::TimeDelta::FromSeconds(10));
+  EXPECT_FALSE(IcmpSession::IsPacketLossPercentageGreaterThan(
+      three_sent_three_received, 0));
+
+  // If we sent 3 requests and received 2 replies, we have ~33% packet loss.
+  IcmpSession::IcmpSessionResult three_sent_two_received;
+  three_sent_two_received.push_back(base::TimeDelta::FromSeconds(10));
+  three_sent_two_received.push_back(base::TimeDelta::FromSeconds(10));
+  three_sent_two_received.push_back(base::TimeDelta());
+  EXPECT_FALSE(IcmpSession::IsPacketLossPercentageGreaterThan(
+      three_sent_two_received, 60));
+  EXPECT_FALSE(IcmpSession::IsPacketLossPercentageGreaterThan(
+      three_sent_two_received, 33));
+  EXPECT_TRUE(IcmpSession::IsPacketLossPercentageGreaterThan(
+      three_sent_two_received, 32));
+  EXPECT_TRUE(IcmpSession::IsPacketLossPercentageGreaterThan(
+      three_sent_two_received, 10));
+}
+
 }  // namespace shill