commit | f48a19573c5470868fae969492d9839813bb9d5e | [log] [tgz] |
---|---|---|
author | Wade Guthrie <wdg@chromium.org> | Mon Mar 04 17:33:47 2013 -0800 |
committer | ChromeBot <chrome-bot@google.com> | Sat Mar 09 09:59:05 2013 -0800 |
tree | 6545d6d5bdc8c97fa25fe09eb0cddd1840e73a3b | |
parent | bdcdaa7f96ec8ca233fbf6e65c3227613e0f164d [diff] |
shill: Split Nl80211Message into class hierarchy. Gotta apologize for this CL: it's a bit more gnarly than I'd like. There're not that many modifications but, with all the moving of code, it's harder to review than I'd like. I found that, easier than gerrit, cherry-pick the change, do a git show HEAD^:nl80211_message.[ch] > old.[ch], and edit the old and new files, together. With the exception of the following changes, the Nl80211Message code was just split into the NetlinkMessage <|-- GenericNetlinkMessage <|-- Nl80211Message class hierarchy. 1. In |NetlinkMessage::InitAndStripHeader|, a length check was added to verify that enough bytes for the |nlmsghdr| exists. 2. In |GenericNetlinkMessage::Encode|, changed name of |attributes| variable to |attribute_string|. 3. Split |EncodeHeader| and |InitAndStripHeader|, each, into |nlmsghdr| and |genlmsghdr| pieces. 4. In |NetlinkMessage::EncodeHeader|, added encoding of |flags_| (that had, somehow, gotten missed in the previous CL -- all other |flags_| processing had been included.) 5. Removed the following unused methods from |Nl80211Message|: - GetHeaderString - StringFromFrame - StringFromKeyType - StringFromRegInitiator - StringFromSsid BUG=chromium-os:38221 TEST=unittest. Change-Id: I208ede49fa8003d49eb487365f886a8f0d53da3f Reviewed-on: https://gerrit.chromium.org/gerrit/44640 Reviewed-by: Christopher Wiley <wiley@chromium.org> Reviewed-by: Wade Guthrie <wdg@chromium.org> Tested-by: Wade Guthrie <wdg@chromium.org> Commit-Queue: Wade Guthrie <wdg@chromium.org>