Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 1 | // Copyright (c) 2011 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "shill/service.h" |
| 6 | |
| 7 | #include <map> |
| 8 | #include <string> |
| 9 | #include <vector> |
| 10 | |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 11 | #include <chromeos/dbus/service_constants.h> |
mukesh agrawal | 1830fa1 | 2011-09-26 14:31:40 -0700 | [diff] [blame] | 12 | #include <dbus-c++/dbus.h> |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 13 | #include <gtest/gtest.h> |
| 14 | #include <gmock/gmock.h> |
| 15 | |
| 16 | #include "shill/dbus_adaptor.h" |
| 17 | #include "shill/ethernet_service.h" |
Paul Stewart | 26b327e | 2011-10-19 11:38:09 -0700 | [diff] [blame^] | 18 | #include "shill/event_dispatcher.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 19 | #include "shill/manager.h" |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 20 | #include "shill/mock_adaptors.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 21 | #include "shill/mock_control.h" |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 22 | #include "shill/mock_manager.h" |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 23 | #include "shill/mock_store.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 24 | #include "shill/property_store_unittest.h" |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 25 | #include "shill/service.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 26 | |
| 27 | using std::map; |
| 28 | using std::string; |
| 29 | using std::vector; |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 30 | using testing::_; |
| 31 | using testing::AtLeast; |
| 32 | using testing::NiceMock; |
| 33 | using testing::Return; |
| 34 | using testing::StrictMock; |
| 35 | using testing::Test; |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 36 | |
| 37 | namespace shill { |
| 38 | |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 39 | // This is a simple Service subclass with all the pure-virutal methods stubbed |
| 40 | class ServiceUnderTest : public Service { |
| 41 | public: |
| 42 | static const char kRpcId[]; |
| 43 | static const char kStorageId[]; |
| 44 | |
| 45 | ServiceUnderTest(ControlInterface *control_interface, |
| 46 | EventDispatcher *dispatcher, |
| 47 | Manager *manager) |
mukesh agrawal | 7a4e400 | 2011-09-06 11:26:05 -0700 | [diff] [blame] | 48 | : Service(control_interface, dispatcher, manager, "stub") {} |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 49 | virtual ~ServiceUnderTest() {} |
| 50 | |
mukesh agrawal | 1830fa1 | 2011-09-26 14:31:40 -0700 | [diff] [blame] | 51 | virtual void Connect(Error */*error*/) {} |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 52 | virtual void Disconnect() {} |
| 53 | virtual string CalculateState() { return ""; } |
| 54 | virtual string GetRpcIdentifier() const { return ServiceMockAdaptor::kRpcId; } |
| 55 | virtual string GetDeviceRpcId() { return kRpcId; } |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 56 | virtual string GetStorageIdentifier() { return kStorageId; } |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 57 | |
| 58 | private: |
| 59 | DISALLOW_COPY_AND_ASSIGN(ServiceUnderTest); |
| 60 | }; |
| 61 | |
| 62 | const char ServiceUnderTest::kRpcId[] = "mock-device-rpc"; |
| 63 | const char ServiceUnderTest::kStorageId[] = "service"; |
| 64 | |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 65 | class ServiceTest : public PropertyStoreTest { |
| 66 | public: |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 67 | ServiceTest() |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 68 | : mock_manager_(control_interface(), dispatcher(), glib()), |
| 69 | service_(new ServiceUnderTest(control_interface(), |
| 70 | dispatcher(), |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 71 | &mock_manager_)), |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 72 | storage_id_(ServiceUnderTest::kStorageId) { |
| 73 | } |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 74 | |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 75 | virtual ~ServiceTest() {} |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 76 | |
| 77 | protected: |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 78 | MockManager mock_manager_; |
| 79 | scoped_refptr<ServiceUnderTest> service_; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 80 | string storage_id_; |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 81 | }; |
| 82 | |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 83 | TEST_F(ServiceTest, Constructor) { |
| 84 | EXPECT_TRUE(service_->save_credentials_); |
| 85 | EXPECT_EQ(Service::kCheckPortalAuto, service_->check_portal_); |
| 86 | } |
| 87 | |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 88 | TEST_F(ServiceTest, GetProperties) { |
| 89 | map<string, ::DBus::Variant> props; |
| 90 | Error error(Error::kInvalidProperty, ""); |
| 91 | { |
| 92 | ::DBus::Error dbus_error; |
| 93 | string expected("portal_list"); |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 94 | service_->mutable_store()->SetStringProperty(flimflam::kCheckPortalProperty, |
| 95 | expected, |
| 96 | &error); |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 97 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 98 | ASSERT_FALSE(props.find(flimflam::kCheckPortalProperty) == props.end()); |
| 99 | EXPECT_EQ(props[flimflam::kCheckPortalProperty].reader().get_string(), |
| 100 | expected); |
| 101 | } |
| 102 | { |
| 103 | ::DBus::Error dbus_error; |
| 104 | bool expected = true; |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 105 | service_->mutable_store()->SetBoolProperty(flimflam::kAutoConnectProperty, |
| 106 | expected, |
| 107 | &error); |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 108 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 109 | ASSERT_FALSE(props.find(flimflam::kAutoConnectProperty) == props.end()); |
| 110 | EXPECT_EQ(props[flimflam::kAutoConnectProperty].reader().get_bool(), |
| 111 | expected); |
| 112 | } |
| 113 | { |
| 114 | ::DBus::Error dbus_error; |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 115 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 116 | ASSERT_FALSE(props.find(flimflam::kConnectableProperty) == props.end()); |
| 117 | EXPECT_EQ(props[flimflam::kConnectableProperty].reader().get_bool(), false); |
| 118 | } |
| 119 | { |
| 120 | ::DBus::Error dbus_error; |
| 121 | int32 expected = 127; |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 122 | service_->mutable_store()->SetInt32Property(flimflam::kPriorityProperty, |
| 123 | expected, |
| 124 | &error); |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 125 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 126 | ASSERT_FALSE(props.find(flimflam::kPriorityProperty) == props.end()); |
| 127 | EXPECT_EQ(props[flimflam::kPriorityProperty].reader().get_int32(), |
| 128 | expected); |
| 129 | } |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 130 | { |
| 131 | ::DBus::Error dbus_error; |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 132 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 133 | ASSERT_FALSE(props.find(flimflam::kDeviceProperty) == props.end()); |
| 134 | EXPECT_EQ(props[flimflam::kDeviceProperty].reader().get_string(), |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 135 | string(ServiceUnderTest::kRpcId)); |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 136 | } |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 137 | } |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 138 | |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 139 | TEST_F(ServiceTest, Dispatch) { |
| 140 | { |
| 141 | ::DBus::Error error; |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 142 | EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(), |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 143 | flimflam::kSaveCredentialsProperty, |
| 144 | PropertyStoreTest::kBoolV, |
| 145 | &error)); |
| 146 | } |
| 147 | { |
| 148 | ::DBus::Error error; |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 149 | EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(), |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 150 | flimflam::kPriorityProperty, |
| 151 | PropertyStoreTest::kInt32V, |
| 152 | &error)); |
| 153 | } |
| 154 | { |
| 155 | ::DBus::Error error; |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 156 | EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(), |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 157 | flimflam::kEAPEAPProperty, |
| 158 | PropertyStoreTest::kStringV, |
| 159 | &error)); |
| 160 | } |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 161 | // Ensure that an attempt to write a R/O property returns InvalidArgs error. |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 162 | { |
| 163 | ::DBus::Error error; |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 164 | EXPECT_FALSE(DBusAdaptor::DispatchOnType(service_->mutable_store(), |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 165 | flimflam::kFavoriteProperty, |
| 166 | PropertyStoreTest::kBoolV, |
| 167 | &error)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 168 | EXPECT_EQ(invalid_args(), error.name()); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 169 | } |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 170 | } |
| 171 | |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 172 | TEST_F(ServiceTest, Load) { |
| 173 | NiceMock<MockStore> storage; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 174 | EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(true)); |
| 175 | EXPECT_CALL(storage, GetString(storage_id_, _, _)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 176 | .Times(AtLeast(1)) |
| 177 | .WillRepeatedly(Return(true)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 178 | EXPECT_TRUE(service_->Load(&storage)); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 179 | } |
| 180 | |
| 181 | TEST_F(ServiceTest, LoadFail) { |
| 182 | StrictMock<MockStore> storage; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 183 | EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(false)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 184 | EXPECT_FALSE(service_->Load(&storage)); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 185 | } |
| 186 | |
| 187 | TEST_F(ServiceTest, SaveString) { |
| 188 | MockStore storage; |
| 189 | static const char kKey[] = "test-key"; |
| 190 | static const char kData[] = "test-data"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 191 | EXPECT_CALL(storage, SetString(storage_id_, kKey, kData)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 192 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 193 | service_->SaveString(&storage, storage_id_, kKey, kData, false, true); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 194 | } |
| 195 | |
| 196 | TEST_F(ServiceTest, SaveStringCrypted) { |
| 197 | MockStore storage; |
| 198 | static const char kKey[] = "test-key"; |
| 199 | static const char kData[] = "test-data"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 200 | EXPECT_CALL(storage, SetCryptedString(storage_id_, kKey, kData)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 201 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 202 | service_->SaveString(&storage, storage_id_, kKey, kData, true, true); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 203 | } |
| 204 | |
| 205 | TEST_F(ServiceTest, SaveStringDontSave) { |
| 206 | MockStore storage; |
| 207 | static const char kKey[] = "test-key"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 208 | EXPECT_CALL(storage, DeleteKey(storage_id_, kKey)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 209 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 210 | service_->SaveString(&storage, storage_id_, kKey, "data", false, false); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 211 | } |
| 212 | |
| 213 | TEST_F(ServiceTest, SaveStringEmpty) { |
| 214 | MockStore storage; |
| 215 | static const char kKey[] = "test-key"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 216 | EXPECT_CALL(storage, DeleteKey(storage_id_, kKey)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 217 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 218 | service_->SaveString(&storage, storage_id_, kKey, "", true, true); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 219 | } |
| 220 | |
| 221 | TEST_F(ServiceTest, Save) { |
| 222 | NiceMock<MockStore> storage; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 223 | EXPECT_CALL(storage, SetString(storage_id_, _, _)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 224 | .Times(AtLeast(1)) |
| 225 | .WillRepeatedly(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 226 | EXPECT_CALL(storage, DeleteKey(storage_id_, _)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 227 | .Times(AtLeast(1)) |
| 228 | .WillRepeatedly(Return(true)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 229 | EXPECT_TRUE(service_->Save(&storage)); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 230 | } |
| 231 | |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 232 | TEST_F(ServiceTest, State) { |
| 233 | EXPECT_EQ(Service::kStateUnknown, service_->state()); |
| 234 | EXPECT_EQ(Service::kFailureUnknown, service_->failure()); |
| 235 | |
| 236 | ServiceConstRefPtr service_ref(service_); |
mukesh agrawal | f2f68a5 | 2011-09-01 12:15:48 -0700 | [diff] [blame] | 237 | |
| 238 | // TODO(quiche): make this EXPECT_CALL work (crosbug.com/20154) |
| 239 | // EXPECT_CALL(*dynamic_cast<ServiceMockAdaptor *>(service_->adaptor_.get()), |
| 240 | // EmitStringChanged(flimflam::kStateProperty, _)); |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 241 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 242 | service_->SetState(Service::kStateConnected); |
| 243 | // A second state change shouldn't cause another update |
| 244 | service_->SetState(Service::kStateConnected); |
| 245 | |
| 246 | EXPECT_EQ(Service::kStateConnected, service_->state()); |
| 247 | EXPECT_EQ(Service::kFailureUnknown, service_->failure()); |
| 248 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 249 | service_->SetState(Service::kStateDisconnected); |
| 250 | |
| 251 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 252 | service_->SetFailure(Service::kFailureOutOfRange); |
| 253 | |
| 254 | EXPECT_EQ(Service::kStateFailure, service_->state()); |
| 255 | EXPECT_EQ(Service::kFailureOutOfRange, service_->failure()); |
| 256 | } |
| 257 | |
Darin Petkov | b100ae7 | 2011-08-24 16:19:45 -0700 | [diff] [blame] | 258 | TEST_F(ServiceTest, ActivateCellularModem) { |
| 259 | Error error; |
| 260 | service_->ActivateCellularModem("Carrier", &error); |
| 261 | EXPECT_EQ(Error::kInvalidArguments, error.type()); |
| 262 | } |
| 263 | |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 264 | } // namespace shill |