Paul Stewart | d8ad3c4 | 2012-01-09 12:39:38 -0800 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "shill/service.h" |
| 6 | |
| 7 | #include <map> |
| 8 | #include <string> |
| 9 | #include <vector> |
| 10 | |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 11 | #include <base/bind.h> |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 12 | #include <chromeos/dbus/service_constants.h> |
mukesh agrawal | 1830fa1 | 2011-09-26 14:31:40 -0700 | [diff] [blame] | 13 | #include <dbus-c++/dbus.h> |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 14 | #include <gtest/gtest.h> |
| 15 | #include <gmock/gmock.h> |
| 16 | |
| 17 | #include "shill/dbus_adaptor.h" |
| 18 | #include "shill/ethernet_service.h" |
Paul Stewart | 26b327e | 2011-10-19 11:38:09 -0700 | [diff] [blame] | 19 | #include "shill/event_dispatcher.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 20 | #include "shill/manager.h" |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 21 | #include "shill/mock_adaptors.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 22 | #include "shill/mock_control.h" |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 23 | #include "shill/mock_manager.h" |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 24 | #include "shill/mock_store.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 25 | #include "shill/property_store_unittest.h" |
Chris Masone | 6515aab | 2011-10-12 16:19:09 -0700 | [diff] [blame] | 26 | #include "shill/service_under_test.h" |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 27 | |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 28 | using base::Bind; |
| 29 | using base::Unretained; |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 30 | using std::map; |
| 31 | using std::string; |
| 32 | using std::vector; |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 33 | using testing::_; |
| 34 | using testing::AtLeast; |
Paul Stewart | d8ad3c4 | 2012-01-09 12:39:38 -0800 | [diff] [blame] | 35 | using testing::DoAll; |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 36 | using testing::NiceMock; |
| 37 | using testing::Return; |
| 38 | using testing::StrictMock; |
Paul Stewart | d8ad3c4 | 2012-01-09 12:39:38 -0800 | [diff] [blame] | 39 | using testing::SetArgumentPointee; |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 40 | using testing::Test; |
Paul Stewart | 9f32d19 | 2012-01-30 20:37:50 -0800 | [diff] [blame] | 41 | using testing::Values; |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 42 | |
| 43 | namespace shill { |
| 44 | |
| 45 | class ServiceTest : public PropertyStoreTest { |
| 46 | public: |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 47 | ServiceTest() |
Thieu Le | 3426c8f | 2012-01-11 17:35:11 -0800 | [diff] [blame] | 48 | : mock_manager_(control_interface(), dispatcher(), metrics(), glib()), |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 49 | service_(new ServiceUnderTest(control_interface(), |
| 50 | dispatcher(), |
Thieu Le | 3426c8f | 2012-01-11 17:35:11 -0800 | [diff] [blame] | 51 | metrics(), |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 52 | &mock_manager_)), |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 53 | storage_id_(ServiceUnderTest::kStorageId) { |
| 54 | } |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 55 | |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 56 | virtual ~ServiceTest() {} |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 57 | |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 58 | MOCK_METHOD1(TestCallback, void(const Error &error)); |
| 59 | |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 60 | protected: |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 61 | |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 62 | MockManager mock_manager_; |
| 63 | scoped_refptr<ServiceUnderTest> service_; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 64 | string storage_id_; |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 65 | }; |
| 66 | |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 67 | TEST_F(ServiceTest, Constructor) { |
| 68 | EXPECT_TRUE(service_->save_credentials_); |
| 69 | EXPECT_EQ(Service::kCheckPortalAuto, service_->check_portal_); |
Eric Shienbrood | cc95c5d | 2012-03-30 15:25:49 -0400 | [diff] [blame] | 70 | EXPECT_EQ(Service::kStateIdle, service_->state()); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 71 | } |
| 72 | |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 73 | TEST_F(ServiceTest, GetProperties) { |
| 74 | map<string, ::DBus::Variant> props; |
| 75 | Error error(Error::kInvalidProperty, ""); |
| 76 | { |
| 77 | ::DBus::Error dbus_error; |
| 78 | string expected("portal_list"); |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 79 | service_->mutable_store()->SetStringProperty(flimflam::kCheckPortalProperty, |
| 80 | expected, |
| 81 | &error); |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 82 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 83 | ASSERT_FALSE(props.find(flimflam::kCheckPortalProperty) == props.end()); |
| 84 | EXPECT_EQ(props[flimflam::kCheckPortalProperty].reader().get_string(), |
| 85 | expected); |
| 86 | } |
| 87 | { |
| 88 | ::DBus::Error dbus_error; |
| 89 | bool expected = true; |
Thieu Le | 284fe79 | 2012-01-31 17:53:19 -0800 | [diff] [blame] | 90 | service_->set_favorite(true); |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 91 | service_->mutable_store()->SetBoolProperty(flimflam::kAutoConnectProperty, |
| 92 | expected, |
| 93 | &error); |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 94 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 95 | ASSERT_FALSE(props.find(flimflam::kAutoConnectProperty) == props.end()); |
| 96 | EXPECT_EQ(props[flimflam::kAutoConnectProperty].reader().get_bool(), |
| 97 | expected); |
| 98 | } |
| 99 | { |
| 100 | ::DBus::Error dbus_error; |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 101 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 102 | ASSERT_FALSE(props.find(flimflam::kConnectableProperty) == props.end()); |
| 103 | EXPECT_EQ(props[flimflam::kConnectableProperty].reader().get_bool(), false); |
| 104 | } |
| 105 | { |
| 106 | ::DBus::Error dbus_error; |
| 107 | int32 expected = 127; |
mukesh agrawal | de29fa8 | 2011-09-16 16:16:36 -0700 | [diff] [blame] | 108 | service_->mutable_store()->SetInt32Property(flimflam::kPriorityProperty, |
| 109 | expected, |
| 110 | &error); |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 111 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 112 | ASSERT_FALSE(props.find(flimflam::kPriorityProperty) == props.end()); |
| 113 | EXPECT_EQ(props[flimflam::kPriorityProperty].reader().get_int32(), |
| 114 | expected); |
| 115 | } |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 116 | { |
| 117 | ::DBus::Error dbus_error; |
Chris Masone | 27c4aa5 | 2011-07-02 13:10:14 -0700 | [diff] [blame] | 118 | DBusAdaptor::GetProperties(service_->store(), &props, &dbus_error); |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 119 | ASSERT_FALSE(props.find(flimflam::kDeviceProperty) == props.end()); |
Jason Glasgow | acdc11f | 2012-03-30 14:12:22 -0400 | [diff] [blame] | 120 | EXPECT_EQ(props[flimflam::kDeviceProperty].reader().get_path(), |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 121 | string(ServiceUnderTest::kRpcId)); |
Chris Masone | 95207da | 2011-06-29 16:50:49 -0700 | [diff] [blame] | 122 | } |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 123 | } |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 124 | |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 125 | TEST_F(ServiceTest, SetProperty) { |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 126 | { |
| 127 | ::DBus::Error error; |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 128 | EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(), |
| 129 | flimflam::kSaveCredentialsProperty, |
| 130 | PropertyStoreTest::kBoolV, |
| 131 | &error)); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 132 | } |
| 133 | { |
| 134 | ::DBus::Error error; |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 135 | EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(), |
| 136 | flimflam::kPriorityProperty, |
| 137 | PropertyStoreTest::kInt32V, |
| 138 | &error)); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 139 | } |
| 140 | { |
| 141 | ::DBus::Error error; |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 142 | EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(), |
| 143 | flimflam::kEAPEAPProperty, |
| 144 | PropertyStoreTest::kStringV, |
| 145 | &error)); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 146 | } |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 147 | // Ensure that an attempt to write a R/O property returns InvalidArgs error. |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 148 | { |
| 149 | ::DBus::Error error; |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 150 | EXPECT_FALSE(DBusAdaptor::SetProperty(service_->mutable_store(), |
| 151 | flimflam::kFavoriteProperty, |
| 152 | PropertyStoreTest::kBoolV, |
| 153 | &error)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 154 | EXPECT_EQ(invalid_args(), error.name()); |
Chris Masone | a8a2c25 | 2011-06-27 22:16:30 -0700 | [diff] [blame] | 155 | } |
Thieu Le | 284fe79 | 2012-01-31 17:53:19 -0800 | [diff] [blame] | 156 | { |
| 157 | ::DBus::Error error; |
| 158 | service_->set_favorite(true); |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 159 | EXPECT_TRUE(DBusAdaptor::SetProperty(service_->mutable_store(), |
| 160 | flimflam::kAutoConnectProperty, |
| 161 | PropertyStoreTest::kBoolV, |
| 162 | &error)); |
Thieu Le | 284fe79 | 2012-01-31 17:53:19 -0800 | [diff] [blame] | 163 | } |
| 164 | { |
| 165 | ::DBus::Error error; |
| 166 | service_->set_favorite(false); |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 167 | EXPECT_FALSE(DBusAdaptor::SetProperty(service_->mutable_store(), |
| 168 | flimflam::kAutoConnectProperty, |
| 169 | PropertyStoreTest::kBoolV, |
| 170 | &error)); |
Thieu Le | 284fe79 | 2012-01-31 17:53:19 -0800 | [diff] [blame] | 171 | EXPECT_EQ(invalid_args(), error.name()); |
| 172 | } |
Chris Masone | b925cc8 | 2011-06-22 15:39:57 -0700 | [diff] [blame] | 173 | } |
| 174 | |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 175 | TEST_F(ServiceTest, Load) { |
| 176 | NiceMock<MockStore> storage; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 177 | EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(true)); |
| 178 | EXPECT_CALL(storage, GetString(storage_id_, _, _)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 179 | .Times(AtLeast(1)) |
| 180 | .WillRepeatedly(Return(true)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 181 | EXPECT_TRUE(service_->Load(&storage)); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 182 | } |
| 183 | |
| 184 | TEST_F(ServiceTest, LoadFail) { |
| 185 | StrictMock<MockStore> storage; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 186 | EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(false)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 187 | EXPECT_FALSE(service_->Load(&storage)); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 188 | } |
| 189 | |
| 190 | TEST_F(ServiceTest, SaveString) { |
| 191 | MockStore storage; |
| 192 | static const char kKey[] = "test-key"; |
| 193 | static const char kData[] = "test-data"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 194 | EXPECT_CALL(storage, SetString(storage_id_, kKey, kData)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 195 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 196 | service_->SaveString(&storage, storage_id_, kKey, kData, false, true); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 197 | } |
| 198 | |
| 199 | TEST_F(ServiceTest, SaveStringCrypted) { |
| 200 | MockStore storage; |
| 201 | static const char kKey[] = "test-key"; |
| 202 | static const char kData[] = "test-data"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 203 | EXPECT_CALL(storage, SetCryptedString(storage_id_, kKey, kData)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 204 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 205 | service_->SaveString(&storage, storage_id_, kKey, kData, true, true); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 206 | } |
| 207 | |
| 208 | TEST_F(ServiceTest, SaveStringDontSave) { |
| 209 | MockStore storage; |
| 210 | static const char kKey[] = "test-key"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 211 | EXPECT_CALL(storage, DeleteKey(storage_id_, kKey)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 212 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 213 | service_->SaveString(&storage, storage_id_, kKey, "data", false, false); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 214 | } |
| 215 | |
| 216 | TEST_F(ServiceTest, SaveStringEmpty) { |
| 217 | MockStore storage; |
| 218 | static const char kKey[] = "test-key"; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 219 | EXPECT_CALL(storage, DeleteKey(storage_id_, kKey)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 220 | .WillOnce(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 221 | service_->SaveString(&storage, storage_id_, kKey, "", true, true); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 222 | } |
| 223 | |
| 224 | TEST_F(ServiceTest, Save) { |
| 225 | NiceMock<MockStore> storage; |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 226 | EXPECT_CALL(storage, SetString(storage_id_, _, _)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 227 | .Times(AtLeast(1)) |
| 228 | .WillRepeatedly(Return(true)); |
Chris Masone | 34af218 | 2011-08-22 11:59:36 -0700 | [diff] [blame] | 229 | EXPECT_CALL(storage, DeleteKey(storage_id_, _)) |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 230 | .Times(AtLeast(1)) |
| 231 | .WillRepeatedly(Return(true)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 232 | EXPECT_TRUE(service_->Save(&storage)); |
Darin Petkov | ba40dd3 | 2011-07-11 20:06:39 -0700 | [diff] [blame] | 233 | } |
| 234 | |
Paul Stewart | d8ad3c4 | 2012-01-09 12:39:38 -0800 | [diff] [blame] | 235 | TEST_F(ServiceTest, Unload) { |
| 236 | NiceMock<MockStore> storage; |
| 237 | EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(true)); |
| 238 | static const string string_value("value"); |
| 239 | EXPECT_CALL(storage, GetString(storage_id_, _, _)) |
| 240 | .Times(AtLeast(1)) |
| 241 | .WillRepeatedly(DoAll(SetArgumentPointee<2>(string_value), Return(true))); |
| 242 | ASSERT_TRUE(service_->Load(&storage)); |
| 243 | // TODO(pstew): A single string property in the service is tested as |
| 244 | // a sentinel that properties are being set and reset at the rit times. |
| 245 | // However, since property load/store is essentially a manual process, |
| 246 | // it is error prone and should either be exhaustively unit-tested or |
| 247 | // a generic framework for registering loaded/stored properties should |
| 248 | // be created. crosbug.com/24859 |
| 249 | EXPECT_EQ(string_value, service_->ui_data_); |
| 250 | service_->Unload(); |
| 251 | EXPECT_EQ(string(""), service_->ui_data_); |
| 252 | } |
| 253 | |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 254 | TEST_F(ServiceTest, State) { |
Eric Shienbrood | cc95c5d | 2012-03-30 15:25:49 -0400 | [diff] [blame] | 255 | EXPECT_EQ(Service::kStateIdle, service_->state()); |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 256 | EXPECT_EQ(Service::kFailureUnknown, service_->failure()); |
| 257 | |
mukesh agrawal | 00917ce | 2011-11-22 23:56:55 +0000 | [diff] [blame] | 258 | ServiceRefPtr service_ref(service_); |
mukesh agrawal | f2f68a5 | 2011-09-01 12:15:48 -0700 | [diff] [blame] | 259 | |
Eric Shienbrood | cc95c5d | 2012-03-30 15:25:49 -0400 | [diff] [blame] | 260 | EXPECT_CALL(*dynamic_cast<ServiceMockAdaptor *>(service_->adaptor_.get()), |
| 261 | EmitStringChanged(flimflam::kStateProperty, _)).Times(5); |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 262 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 263 | service_->SetState(Service::kStateConnected); |
| 264 | // A second state change shouldn't cause another update |
| 265 | service_->SetState(Service::kStateConnected); |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 266 | EXPECT_EQ(Service::kStateConnected, service_->state()); |
| 267 | EXPECT_EQ(Service::kFailureUnknown, service_->failure()); |
mukesh agrawal | 568b5c6 | 2012-02-28 14:44:47 -0800 | [diff] [blame] | 268 | |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 269 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 270 | service_->SetState(Service::kStateDisconnected); |
| 271 | |
| 272 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 273 | service_->SetFailure(Service::kFailureOutOfRange); |
mukesh agrawal | 568b5c6 | 2012-02-28 14:44:47 -0800 | [diff] [blame] | 274 | EXPECT_TRUE(service_->IsFailed()); |
| 275 | EXPECT_GT(service_->failed_time_, 0); |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 276 | EXPECT_EQ(Service::kStateFailure, service_->state()); |
| 277 | EXPECT_EQ(Service::kFailureOutOfRange, service_->failure()); |
mukesh agrawal | 568b5c6 | 2012-02-28 14:44:47 -0800 | [diff] [blame] | 278 | |
| 279 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 280 | service_->SetState(Service::kStateConnected); |
| 281 | EXPECT_FALSE(service_->IsFailed()); |
| 282 | EXPECT_EQ(service_->failed_time_, 0); |
| 283 | |
| 284 | EXPECT_CALL(mock_manager_, UpdateService(service_ref)); |
| 285 | service_->SetFailureSilent(Service::kFailurePinMissing); |
| 286 | EXPECT_TRUE(service_->IsFailed()); |
| 287 | EXPECT_GT(service_->failed_time_, 0); |
| 288 | EXPECT_EQ(Service::kStateIdle, service_->state()); |
| 289 | EXPECT_EQ(Service::kFailurePinMissing, service_->failure()); |
Paul Stewart | 03dba0b | 2011-08-22 16:32:45 -0700 | [diff] [blame] | 290 | } |
| 291 | |
Darin Petkov | b100ae7 | 2011-08-24 16:19:45 -0700 | [diff] [blame] | 292 | TEST_F(ServiceTest, ActivateCellularModem) { |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 293 | ResultCallback callback = |
| 294 | Bind(&ServiceTest::TestCallback, Unretained(this)); |
| 295 | EXPECT_CALL(*this, TestCallback(_)).Times(0); |
Darin Petkov | b100ae7 | 2011-08-24 16:19:45 -0700 | [diff] [blame] | 296 | Error error; |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 297 | service_->ActivateCellularModem("Carrier", &error, callback); |
| 298 | EXPECT_TRUE(error.IsFailure()); |
Darin Petkov | b100ae7 | 2011-08-24 16:19:45 -0700 | [diff] [blame] | 299 | } |
| 300 | |
mukesh agrawal | 00917ce | 2011-11-22 23:56:55 +0000 | [diff] [blame] | 301 | TEST_F(ServiceTest, MakeFavorite) { |
| 302 | EXPECT_FALSE(service_->favorite()); |
| 303 | EXPECT_FALSE(service_->auto_connect()); |
| 304 | |
| 305 | service_->MakeFavorite(); |
| 306 | EXPECT_TRUE(service_->favorite()); |
| 307 | EXPECT_TRUE(service_->auto_connect()); |
| 308 | } |
| 309 | |
| 310 | TEST_F(ServiceTest, ReMakeFavorite) { |
| 311 | service_->MakeFavorite(); |
| 312 | EXPECT_TRUE(service_->favorite()); |
| 313 | EXPECT_TRUE(service_->auto_connect()); |
| 314 | |
| 315 | service_->set_auto_connect(false); |
| 316 | service_->MakeFavorite(); |
| 317 | EXPECT_TRUE(service_->favorite()); |
| 318 | EXPECT_FALSE(service_->auto_connect()); |
| 319 | } |
| 320 | |
mukesh agrawal | 76d1388 | 2012-01-12 15:23:11 -0800 | [diff] [blame] | 321 | TEST_F(ServiceTest, IsAutoConnectable) { |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 322 | const char *reason; |
mukesh agrawal | 76d1388 | 2012-01-12 15:23:11 -0800 | [diff] [blame] | 323 | service_->set_connectable(true); |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 324 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
mukesh agrawal | 76d1388 | 2012-01-12 15:23:11 -0800 | [diff] [blame] | 325 | |
mukesh agrawal | adb6848 | 2012-01-17 16:31:51 -0800 | [diff] [blame] | 326 | // We should not auto-connect to a Service that a user has |
| 327 | // deliberately disconnected. |
| 328 | Error error; |
| 329 | service_->Disconnect(&error); |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 330 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 331 | EXPECT_STREQ(Service::kAutoConnExplicitDisconnect, reason); |
mukesh agrawal | adb6848 | 2012-01-17 16:31:51 -0800 | [diff] [blame] | 332 | |
| 333 | // But if the Service is reloaded, it is eligible for auto-connect |
| 334 | // again. |
| 335 | NiceMock<MockStore> storage; |
| 336 | EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(true)); |
| 337 | EXPECT_TRUE(service_->Load(&storage)); |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 338 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
mukesh agrawal | adb6848 | 2012-01-17 16:31:51 -0800 | [diff] [blame] | 339 | |
| 340 | // A deliberate Connect should also re-enable auto-connect. |
| 341 | service_->Disconnect(&error); |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 342 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
mukesh agrawal | adb6848 | 2012-01-17 16:31:51 -0800 | [diff] [blame] | 343 | service_->Connect(&error); |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 344 | EXPECT_TRUE(service_->IsAutoConnectable(&reason)); |
mukesh agrawal | adb6848 | 2012-01-17 16:31:51 -0800 | [diff] [blame] | 345 | |
| 346 | // TODO(quiche): After we have resume handling in place, test that |
| 347 | // we re-enable auto-connect on resume. crosbug.com/25213 |
| 348 | |
mukesh agrawal | 76d1388 | 2012-01-12 15:23:11 -0800 | [diff] [blame] | 349 | service_->SetState(Service::kStateConnected); |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 350 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 351 | EXPECT_STREQ(Service::kAutoConnConnected, reason); |
mukesh agrawal | 76d1388 | 2012-01-12 15:23:11 -0800 | [diff] [blame] | 352 | |
| 353 | service_->SetState(Service::kStateAssociating); |
mukesh agrawal | bf14e94 | 2012-03-02 14:36:34 -0800 | [diff] [blame] | 354 | EXPECT_FALSE(service_->IsAutoConnectable(&reason)); |
| 355 | EXPECT_STREQ(Service::kAutoConnConnecting, reason); |
mukesh agrawal | 76d1388 | 2012-01-12 15:23:11 -0800 | [diff] [blame] | 356 | } |
| 357 | |
Paul Stewart | cb59fed | 2012-03-21 21:14:46 -0700 | [diff] [blame] | 358 | TEST_F(ServiceTest, ConfigureBadProperty) { |
| 359 | KeyValueStore args; |
| 360 | args.SetString("XXXInvalid", "Value"); |
| 361 | Error error; |
| 362 | service_->Configure(args, &error); |
| 363 | EXPECT_FALSE(error.IsSuccess()); |
| 364 | } |
| 365 | |
| 366 | TEST_F(ServiceTest, ConfigureBoolProperty) { |
| 367 | service_->MakeFavorite(); |
| 368 | service_->set_auto_connect(false); |
| 369 | ASSERT_FALSE(service_->auto_connect()); |
| 370 | KeyValueStore args; |
| 371 | args.SetBool(flimflam::kAutoConnectProperty, true); |
| 372 | Error error; |
| 373 | service_->Configure(args, &error); |
| 374 | EXPECT_TRUE(error.IsSuccess()); |
| 375 | EXPECT_TRUE(service_->auto_connect()); |
| 376 | } |
| 377 | |
| 378 | TEST_F(ServiceTest, ConfigureStringProperty) { |
| 379 | const string kEAPManagement0 = "management_zero"; |
| 380 | const string kEAPManagement1 = "management_one"; |
| 381 | service_->SetEAPKeyManagement(kEAPManagement0); |
| 382 | ASSERT_EQ(kEAPManagement0, service_->GetEAPKeyManagement()); |
| 383 | KeyValueStore args; |
| 384 | args.SetString(flimflam::kEapKeyMgmtProperty, kEAPManagement1); |
| 385 | Error error; |
| 386 | service_->Configure(args, &error); |
| 387 | EXPECT_TRUE(error.IsSuccess()); |
| 388 | EXPECT_EQ(kEAPManagement1, service_->GetEAPKeyManagement()); |
| 389 | } |
| 390 | |
| 391 | TEST_F(ServiceTest, ConfigureIgnoredProperty) { |
| 392 | service_->MakeFavorite(); |
| 393 | service_->set_auto_connect(false); |
| 394 | ASSERT_FALSE(service_->auto_connect()); |
| 395 | KeyValueStore args; |
| 396 | args.SetBool(flimflam::kAutoConnectProperty, true); |
| 397 | Error error; |
| 398 | service_->IgnoreParameterForConfigure(flimflam::kAutoConnectProperty); |
| 399 | service_->Configure(args, &error); |
| 400 | EXPECT_TRUE(error.IsSuccess()); |
| 401 | EXPECT_FALSE(service_->auto_connect()); |
| 402 | } |
| 403 | |
Paul Stewart | 9f32d19 | 2012-01-30 20:37:50 -0800 | [diff] [blame] | 404 | // Make sure a property is registered as a write only property |
| 405 | // by reading and comparing all string properties returned on the store. |
| 406 | // Subtle: We need to convert the test argument back and forth between |
| 407 | // string and ::DBus::Variant because this is the parameter type that |
| 408 | // our supeclass (PropertyStoreTest) is declared with. |
| 409 | class ReadOnlyServicePropertyTest : public ServiceTest {}; |
| 410 | TEST_P(ReadOnlyServicePropertyTest, PropertyWriteOnly) { |
| 411 | ReadablePropertyConstIterator<string> it = |
| 412 | (service_->store()).GetStringPropertiesIter(); |
| 413 | string property(GetParam().reader().get_string()); |
| 414 | for( ; !it.AtEnd(); it.Advance()) |
| 415 | EXPECT_NE(it.Key(), property); |
| 416 | } |
| 417 | |
| 418 | INSTANTIATE_TEST_CASE_P( |
| 419 | ReadOnlyServicePropertyTestInstance, |
| 420 | ReadOnlyServicePropertyTest, |
| 421 | Values( |
| 422 | DBusAdaptor::StringToVariant(flimflam::kEapPrivateKeyPasswordProperty), |
| 423 | DBusAdaptor::StringToVariant(flimflam::kEapPasswordProperty))); |
| 424 | |
Chris Masone | 3bd3c8c | 2011-06-13 08:20:26 -0700 | [diff] [blame] | 425 | } // namespace shill |