mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Chris Masone | 8a7b8be | 2011-07-22 12:43:37 -0700 | [diff] [blame] | 5 | #include "shill/dhcp_config.h" |
| 6 | |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 7 | #include <base/bind.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 8 | #include <base/file_util.h> |
Paul Stewart | 5ad1606 | 2013-02-21 18:10:48 -0800 | [diff] [blame] | 9 | #include <base/files/scoped_temp_dir.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 10 | #include <base/stringprintf.h> |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 11 | #include <chromeos/dbus/service_constants.h> |
Chris Masone | 8a7b8be | 2011-07-22 12:43:37 -0700 | [diff] [blame] | 12 | #include <gtest/gtest.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 13 | |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 14 | #include "shill/dbus_adaptor.h" |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 15 | #include "shill/dhcp_provider.h" |
Paul Stewart | 26b327e | 2011-10-19 11:38:09 -0700 | [diff] [blame] | 16 | #include "shill/event_dispatcher.h" |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 17 | #include "shill/mock_control.h" |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 18 | #include "shill/mock_dhcp_proxy.h" |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 19 | #include "shill/mock_glib.h" |
mukesh agrawal | 6c6655d | 2012-12-06 14:49:50 -0800 | [diff] [blame] | 20 | #include "shill/mock_log.h" |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 21 | #include "shill/mock_minijail.h" |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 22 | #include "shill/property_store_unittest.h" |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 23 | #include "shill/proxy_factory.h" |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 24 | |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 25 | using base::Bind; |
Albert Chaulk | 0e1cdea | 2013-02-27 15:32:55 -0800 | [diff] [blame] | 26 | using base::FilePath; |
Paul Stewart | 5ad1606 | 2013-02-21 18:10:48 -0800 | [diff] [blame] | 27 | using base::ScopedTempDir; |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 28 | using base::Unretained; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 29 | using std::string; |
| 30 | using std::vector; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 31 | using testing::_; |
mukesh agrawal | 1835e77 | 2013-01-15 18:35:03 -0800 | [diff] [blame] | 32 | using testing::AnyNumber; |
| 33 | using testing::ContainsRegex; |
Paul Stewart | 21f7b34 | 2013-11-19 10:15:58 -0800 | [diff] [blame] | 34 | using testing::Mock; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 35 | using testing::Return; |
| 36 | using testing::SetArgumentPointee; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 37 | using testing::Test; |
| 38 | |
| 39 | namespace shill { |
| 40 | |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 41 | namespace { |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 42 | const char kDeviceName[] = "eth0"; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 43 | const char kHostName[] = "hostname"; |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 44 | const char kLeaseFileSuffix[] = "leasefilesuffix"; |
| 45 | const bool kArpGateway = true; |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 46 | const bool kHasHostname = true; |
| 47 | const bool kHasLeaseSuffix = true; |
| 48 | const bool kMinimalConfig = true; |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 49 | } // namespace {} |
| 50 | |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 51 | class DHCPConfigTest : public PropertyStoreTest { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 52 | public: |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 53 | DHCPConfigTest() |
Darin Petkov | f65e928 | 2011-06-21 14:29:56 -0700 | [diff] [blame] | 54 | : proxy_(new MockDHCPProxy()), |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 55 | proxy_factory_(this), |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 56 | minijail_(new MockMinijail()), |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 57 | config_(new DHCPConfig(&control_, |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 58 | dispatcher(), |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 59 | DHCPProvider::GetInstance(), |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 60 | kDeviceName, |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 61 | kHostName, |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 62 | kLeaseFileSuffix, |
| 63 | kArpGateway, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 64 | !kMinimalConfig, |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 65 | glib())) {} |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 66 | |
| 67 | virtual void SetUp() { |
Darin Petkov | ab565bb | 2011-10-06 02:55:51 -0700 | [diff] [blame] | 68 | config_->proxy_factory_ = &proxy_factory_; |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 69 | config_->minijail_ = minijail_.get(); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 70 | } |
| 71 | |
| 72 | virtual void TearDown() { |
Darin Petkov | ab565bb | 2011-10-06 02:55:51 -0700 | [diff] [blame] | 73 | config_->proxy_factory_ = NULL; |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 74 | config_->minijail_ = NULL; |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 75 | } |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 76 | |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 77 | DHCPConfigRefPtr CreateMockMinijailConfig(const string &hostname, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 78 | const string &lease_suffix, |
| 79 | bool arp_gateway, |
| 80 | bool minimal_config); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 81 | DHCPConfigRefPtr CreateRunningConfig(const string &hostname, |
| 82 | const string &lease_suffix, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 83 | bool arp_gateway, |
| 84 | bool minimal_config); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 85 | void StopRunningConfigAndExpect(DHCPConfigRefPtr config, |
| 86 | bool lease_file_exists); |
| 87 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 88 | protected: |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 89 | class TestProxyFactory : public ProxyFactory { |
| 90 | public: |
Paul Stewart | 7355ce1 | 2011-09-02 10:47:01 -0700 | [diff] [blame] | 91 | explicit TestProxyFactory(DHCPConfigTest *test) : test_(test) {} |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 92 | |
mukesh agrawal | 1830fa1 | 2011-09-26 14:31:40 -0700 | [diff] [blame] | 93 | virtual DHCPProxyInterface *CreateDHCPProxy(const string &/*service*/) { |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 94 | return test_->proxy_.release(); |
| 95 | } |
| 96 | |
| 97 | private: |
| 98 | DHCPConfigTest *test_; |
| 99 | }; |
| 100 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 101 | static const int kPID; |
| 102 | static const unsigned int kTag; |
| 103 | |
| 104 | FilePath lease_file_; |
| 105 | FilePath pid_file_; |
| 106 | ScopedTempDir temp_dir_; |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 107 | scoped_ptr<MockDHCPProxy> proxy_; |
| 108 | TestProxyFactory proxy_factory_; |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 109 | MockControl control_; |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 110 | scoped_ptr<MockMinijail> minijail_; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 111 | DHCPConfigRefPtr config_; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 112 | }; |
| 113 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 114 | const int DHCPConfigTest::kPID = 123456; |
| 115 | const unsigned int DHCPConfigTest::kTag = 77; |
| 116 | |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 117 | DHCPConfigRefPtr DHCPConfigTest::CreateMockMinijailConfig( |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 118 | const string &hostname, |
| 119 | const string &lease_suffix, |
| 120 | bool arp_gateway, |
| 121 | bool minimal_config) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 122 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 123 | dispatcher(), |
| 124 | DHCPProvider::GetInstance(), |
| 125 | kDeviceName, |
| 126 | hostname, |
| 127 | lease_suffix, |
| 128 | arp_gateway, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 129 | minimal_config, |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 130 | glib())); |
| 131 | config->minijail_ = minijail_.get(); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 132 | |
| 133 | return config; |
| 134 | } |
| 135 | |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 136 | DHCPConfigRefPtr DHCPConfigTest::CreateRunningConfig( |
| 137 | const string &hostname, |
| 138 | const string &lease_suffix, |
| 139 | bool arp_gateway, |
| 140 | bool minimal_config) { |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 141 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 142 | dispatcher(), |
| 143 | DHCPProvider::GetInstance(), |
| 144 | kDeviceName, |
| 145 | hostname, |
| 146 | lease_suffix, |
| 147 | arp_gateway, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 148 | minimal_config, |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 149 | glib())); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 150 | config->minijail_ = minijail_.get(); |
| 151 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)) |
| 152 | .WillOnce(DoAll(SetArgumentPointee<2>(kPID), Return(true))); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 153 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID, _, _)).WillOnce(Return(kTag)); |
| 154 | EXPECT_TRUE(config->Start()); |
| 155 | EXPECT_EQ(kPID, config->pid_); |
| 156 | EXPECT_EQ(config.get(), DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 157 | EXPECT_EQ(kTag, config->child_watch_tag_); |
| 158 | |
| 159 | EXPECT_TRUE(temp_dir_.CreateUniqueTempDir()); |
| 160 | config->root_ = temp_dir_.path(); |
Jorge Lucangeli Obes | 2f3169d | 2012-04-25 11:38:25 -0700 | [diff] [blame] | 161 | FilePath varrun = temp_dir_.path().Append("var/run/dhcpcd"); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 162 | EXPECT_TRUE(file_util::CreateDirectory(varrun)); |
| 163 | pid_file_ = varrun.Append(base::StringPrintf("dhcpcd-%s.pid", kDeviceName)); |
| 164 | FilePath varlib = temp_dir_.path().Append("var/lib/dhcpcd"); |
| 165 | EXPECT_TRUE(file_util::CreateDirectory(varlib)); |
| 166 | lease_file_ = |
| 167 | varlib.Append(base::StringPrintf("dhcpcd-%s.lease", kDeviceName)); |
| 168 | EXPECT_EQ(0, file_util::WriteFile(pid_file_, "", 0)); |
| 169 | EXPECT_EQ(0, file_util::WriteFile(lease_file_, "", 0)); |
| 170 | EXPECT_TRUE(file_util::PathExists(pid_file_)); |
| 171 | EXPECT_TRUE(file_util::PathExists(lease_file_)); |
| 172 | |
| 173 | return config; |
| 174 | } |
| 175 | |
| 176 | void DHCPConfigTest::StopRunningConfigAndExpect(DHCPConfigRefPtr config, |
| 177 | bool lease_file_exists) { |
mukesh agrawal | 6c6655d | 2012-12-06 14:49:50 -0800 | [diff] [blame] | 178 | ScopedMockLog log; |
| 179 | // We use a non-zero exit status so that we get the log message. |
| 180 | EXPECT_CALL(log, Log(_, _, ::testing::EndsWith("status 10"))); |
| 181 | DHCPConfig::ChildWatchCallback(kPID, 10, config.get()); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 182 | EXPECT_EQ(NULL, DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 183 | |
| 184 | EXPECT_FALSE(file_util::PathExists(pid_file_)); |
| 185 | EXPECT_EQ(lease_file_exists, file_util::PathExists(lease_file_)); |
| 186 | } |
| 187 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 188 | TEST_F(DHCPConfigTest, GetIPv4AddressString) { |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 189 | EXPECT_EQ("255.255.255.255", config_->GetIPv4AddressString(0xffffffff)); |
| 190 | EXPECT_EQ("0.0.0.0", config_->GetIPv4AddressString(0)); |
| 191 | EXPECT_EQ("1.2.3.4", config_->GetIPv4AddressString(0x04030201)); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 192 | } |
| 193 | |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 194 | TEST_F(DHCPConfigTest, InitProxy) { |
| 195 | static const char kService[] = ":1.200"; |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 196 | EXPECT_TRUE(proxy_.get()); |
| 197 | EXPECT_FALSE(config_->proxy_.get()); |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 198 | config_->InitProxy(kService); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 199 | EXPECT_FALSE(proxy_.get()); |
| 200 | EXPECT_TRUE(config_->proxy_.get()); |
| 201 | |
| 202 | config_->InitProxy(kService); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 203 | } |
| 204 | |
Paul Stewart | 65bcd08 | 2012-11-16 09:37:14 -0800 | [diff] [blame] | 205 | TEST_F(DHCPConfigTest, ParseClasslessStaticRoutes) { |
| 206 | const string kDefaultAddress = "0.0.0.0"; |
| 207 | const string kDefaultDestination = kDefaultAddress + "/0"; |
| 208 | const string kRouter0 = "10.0.0.254"; |
| 209 | const string kAddress1 = "192.168.1.0"; |
| 210 | const string kDestination1 = kAddress1 + "/24"; |
| 211 | // Last gateway missing, leaving an odd number of parameters. |
| 212 | const string kBrokenClasslessRoutes0 = kDefaultDestination + " " + kRouter0 + |
| 213 | " " + kDestination1; |
| 214 | IPConfig::Properties properties; |
| 215 | EXPECT_FALSE(DHCPConfig::ParseClasslessStaticRoutes(kBrokenClasslessRoutes0, |
| 216 | &properties)); |
| 217 | EXPECT_TRUE(properties.routes.empty()); |
| 218 | EXPECT_TRUE(properties.gateway.empty()); |
| 219 | |
| 220 | // Gateway argument for the second route is malformed, but we were able |
| 221 | // to salvage a default gateway. |
| 222 | const string kBrokenRouter1 = "10.0.0"; |
| 223 | const string kBrokenClasslessRoutes1 = kBrokenClasslessRoutes0 + " " + |
| 224 | kBrokenRouter1; |
| 225 | EXPECT_FALSE(DHCPConfig::ParseClasslessStaticRoutes(kBrokenClasslessRoutes1, |
| 226 | &properties)); |
| 227 | EXPECT_TRUE(properties.routes.empty()); |
| 228 | EXPECT_EQ(kRouter0, properties.gateway); |
| 229 | |
| 230 | const string kRouter1 = "10.0.0.253"; |
| 231 | const string kRouter2 = "10.0.0.252"; |
| 232 | const string kClasslessRoutes0 = kDefaultDestination + " " + kRouter2 + " " + |
| 233 | kDestination1 + " " + kRouter1; |
| 234 | EXPECT_TRUE(DHCPConfig::ParseClasslessStaticRoutes(kClasslessRoutes0, |
| 235 | &properties)); |
| 236 | // The old default route is preserved. |
| 237 | EXPECT_EQ(kRouter0, properties.gateway); |
| 238 | |
| 239 | // The two routes (including the one which would have otherwise been |
| 240 | // classified as a default route) are added to the routing table. |
| 241 | EXPECT_EQ(2, properties.routes.size()); |
| 242 | const IPConfig::Route &route0 = properties.routes[0]; |
| 243 | EXPECT_EQ(kDefaultAddress, route0.host); |
| 244 | EXPECT_EQ("0.0.0.0", route0.netmask); |
| 245 | EXPECT_EQ(kRouter2, route0.gateway); |
| 246 | |
| 247 | const IPConfig::Route &route1 = properties.routes[1]; |
| 248 | EXPECT_EQ(kAddress1, route1.host); |
| 249 | EXPECT_EQ("255.255.255.0", route1.netmask); |
| 250 | EXPECT_EQ(kRouter1, route1.gateway); |
| 251 | |
| 252 | // A malformed routing table should not affect the current table. |
| 253 | EXPECT_FALSE(DHCPConfig::ParseClasslessStaticRoutes(kBrokenClasslessRoutes1, |
| 254 | &properties)); |
| 255 | EXPECT_EQ(2, properties.routes.size()); |
| 256 | EXPECT_EQ(kRouter0, properties.gateway); |
| 257 | } |
| 258 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 259 | TEST_F(DHCPConfigTest, ParseConfiguration) { |
| 260 | DHCPConfig::Configuration conf; |
| 261 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 262 | 0x01020304); |
| 263 | conf[DHCPConfig::kConfigurationKeySubnetCIDR].writer().append_byte( |
| 264 | 16); |
| 265 | conf[DHCPConfig::kConfigurationKeyBroadcastAddress].writer().append_uint32( |
| 266 | 0x10203040); |
| 267 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 268 | vector<unsigned int> routers; |
| 269 | routers.push_back(0x02040608); |
| 270 | routers.push_back(0x03050709); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 271 | DBus::MessageIter writer = |
| 272 | conf[DHCPConfig::kConfigurationKeyRouters].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 273 | writer << routers; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 274 | } |
| 275 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 276 | vector<unsigned int> dns; |
| 277 | dns.push_back(0x09070503); |
| 278 | dns.push_back(0x08060402); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 279 | DBus::MessageIter writer = conf[DHCPConfig::kConfigurationKeyDNS].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 280 | writer << dns; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 281 | } |
| 282 | conf[DHCPConfig::kConfigurationKeyDomainName].writer().append_string( |
| 283 | "domain-name"); |
| 284 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 285 | vector<string> search; |
| 286 | search.push_back("foo.com"); |
| 287 | search.push_back("bar.com"); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 288 | DBus::MessageIter writer = |
| 289 | conf[DHCPConfig::kConfigurationKeyDomainSearch].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 290 | writer << search; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 291 | } |
| 292 | conf[DHCPConfig::kConfigurationKeyMTU].writer().append_uint16(600); |
| 293 | conf["UnknownKey"] = DBus::Variant(); |
| 294 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 295 | IPConfig::Properties properties; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 296 | ASSERT_TRUE(config_->ParseConfiguration(conf, &properties)); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 297 | EXPECT_EQ("4.3.2.1", properties.address); |
Paul Stewart | 48100b0 | 2012-03-19 07:53:52 -0700 | [diff] [blame] | 298 | EXPECT_EQ(16, properties.subnet_prefix); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 299 | EXPECT_EQ("64.48.32.16", properties.broadcast_address); |
| 300 | EXPECT_EQ("8.6.4.2", properties.gateway); |
| 301 | ASSERT_EQ(2, properties.dns_servers.size()); |
| 302 | EXPECT_EQ("3.5.7.9", properties.dns_servers[0]); |
| 303 | EXPECT_EQ("2.4.6.8", properties.dns_servers[1]); |
| 304 | EXPECT_EQ("domain-name", properties.domain_name); |
| 305 | ASSERT_EQ(2, properties.domain_search.size()); |
| 306 | EXPECT_EQ("foo.com", properties.domain_search[0]); |
| 307 | EXPECT_EQ("bar.com", properties.domain_search[1]); |
| 308 | EXPECT_EQ(600, properties.mtu); |
| 309 | } |
| 310 | |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 311 | TEST_F(DHCPConfigTest, StartFail) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 312 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(false)); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 313 | EXPECT_CALL(*glib(), ChildWatchAdd(_, _, _)).Times(0); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 314 | EXPECT_FALSE(config_->Start()); |
| 315 | EXPECT_EQ(0, config_->pid_); |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 316 | } |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 317 | |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 318 | MATCHER_P4(IsDHCPCDArgs, has_hostname, has_arp_gateway, has_lease_suffix, |
| 319 | has_minimal_config, "") { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 320 | if (string(arg[0]) != "/sbin/dhcpcd" || |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 321 | string(arg[1]) != "-B" || |
| 322 | string(arg[2]) != "-q") { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 323 | return false; |
| 324 | } |
| 325 | |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 326 | int end_offset = 3; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 327 | if (has_hostname) { |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 328 | if (string(arg[end_offset]) != "-h" || |
| 329 | string(arg[end_offset + 1]) != kHostName) { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 330 | return false; |
| 331 | } |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 332 | end_offset += 2; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 333 | } |
| 334 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 335 | if (has_arp_gateway) { |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 336 | if (string(arg[end_offset]) != "-R" || |
| 337 | string(arg[end_offset + 1]) != "-U") { |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 338 | return false; |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 339 | } |
| 340 | end_offset += 2; |
| 341 | } |
| 342 | |
| 343 | if (has_minimal_config) { |
| 344 | if (string(arg[end_offset]) != "-f" || |
| 345 | string(arg[end_offset + 1]) != "/etc/dhcpcd-minimal.conf") { |
| 346 | return false; |
| 347 | } |
| 348 | end_offset += 2; |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 349 | } |
| 350 | |
| 351 | string device_arg = has_lease_suffix ? |
| 352 | string(kDeviceName) + "=" + string(kLeaseFileSuffix) : kDeviceName; |
| 353 | return string(arg[end_offset]) == device_arg && arg[end_offset + 1] == NULL; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 354 | } |
| 355 | |
| 356 | TEST_F(DHCPConfigTest, StartWithHostname) { |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 357 | EXPECT_CALL(*minijail_, RunAndDestroy(_, IsDHCPCDArgs(kHasHostname, |
| 358 | kArpGateway, |
| 359 | kHasLeaseSuffix, |
| 360 | !kMinimalConfig), _)) |
| 361 | .WillOnce(Return(false)); |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 362 | EXPECT_FALSE(config_->Start()); |
| 363 | } |
| 364 | |
| 365 | TEST_F(DHCPConfigTest, StartWithoutHostname) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 366 | DHCPConfigRefPtr config = CreateMockMinijailConfig("", |
| 367 | kLeaseFileSuffix, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 368 | kArpGateway, |
| 369 | !kMinimalConfig); |
| 370 | EXPECT_CALL(*minijail_, RunAndDestroy(_, IsDHCPCDArgs(!kHasHostname, |
| 371 | kArpGateway, |
| 372 | kHasLeaseSuffix, |
| 373 | !kMinimalConfig), _)) |
| 374 | .WillOnce(Return(false)); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 375 | EXPECT_FALSE(config->Start()); |
| 376 | } |
| 377 | |
| 378 | TEST_F(DHCPConfigTest, StartWithoutArpGateway) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 379 | DHCPConfigRefPtr config = CreateMockMinijailConfig(kHostName, |
| 380 | kLeaseFileSuffix, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 381 | !kArpGateway, |
| 382 | !kMinimalConfig); |
| 383 | EXPECT_CALL(*minijail_, RunAndDestroy(_, IsDHCPCDArgs(kHasHostname, |
| 384 | !kArpGateway, |
| 385 | kHasLeaseSuffix, |
| 386 | !kMinimalConfig), _)) |
| 387 | .WillOnce(Return(false)); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 388 | EXPECT_FALSE(config->Start()); |
| 389 | } |
| 390 | |
| 391 | TEST_F(DHCPConfigTest, StartWithoutLeaseSuffix) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 392 | DHCPConfigRefPtr config = CreateMockMinijailConfig(kHostName, |
| 393 | kDeviceName, |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 394 | kArpGateway, |
| 395 | !kMinimalConfig); |
| 396 | EXPECT_CALL(*minijail_, RunAndDestroy(_, IsDHCPCDArgs(kHasHostname, |
| 397 | kArpGateway, |
| 398 | !kHasLeaseSuffix, |
| 399 | !kMinimalConfig), _)) |
| 400 | .WillOnce(Return(false)); |
| 401 | EXPECT_FALSE(config->Start()); |
| 402 | } |
| 403 | |
| 404 | TEST_F(DHCPConfigTest, StartWithMinimalConfig) { |
| 405 | DHCPConfigRefPtr config = CreateMockMinijailConfig(kHostName, |
| 406 | kLeaseFileSuffix, |
| 407 | kArpGateway, |
| 408 | kMinimalConfig); |
| 409 | EXPECT_CALL(*minijail_, RunAndDestroy(_, IsDHCPCDArgs(kHasHostname, |
| 410 | kArpGateway, |
| 411 | kHasLeaseSuffix, |
| 412 | kMinimalConfig), _)) |
| 413 | .WillOnce(Return(false)); |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 414 | EXPECT_FALSE(config->Start()); |
| 415 | } |
| 416 | |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 417 | namespace { |
| 418 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 419 | class DHCPConfigCallbackTest : public DHCPConfigTest { |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 420 | public: |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 421 | virtual void SetUp() { |
| 422 | DHCPConfigTest::SetUp(); |
| 423 | config_->RegisterUpdateCallback( |
| 424 | Bind(&DHCPConfigCallbackTest::SuccessCallback, Unretained(this))); |
| 425 | config_->RegisterFailureCallback( |
| 426 | Bind(&DHCPConfigCallbackTest::FailureCallback, Unretained(this))); |
| 427 | ip_config_ = config_; |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 428 | } |
| 429 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 430 | MOCK_METHOD1(SuccessCallback, void(const IPConfigRefPtr &ipconfig)); |
| 431 | MOCK_METHOD1(FailureCallback, void(const IPConfigRefPtr &ipconfig)); |
| 432 | |
| 433 | // The mock methods above take IPConfigRefPtr because this is the type |
| 434 | // that the registered callbacks take. This conversion of the DHCP |
| 435 | // config ref pointer eases our work in setting up expectations. |
| 436 | const IPConfigRefPtr &ConfigRef() { return ip_config_; } |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 437 | |
| 438 | private: |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 439 | IPConfigRefPtr ip_config_; |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 440 | }; |
| 441 | |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 442 | void DoNothing() {} |
| 443 | |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 444 | } // namespace {} |
| 445 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 446 | TEST_F(DHCPConfigCallbackTest, ProcessEventSignalFail) { |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 447 | DHCPConfig::Configuration conf; |
| 448 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 449 | 0x01020304); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 450 | EXPECT_CALL(*this, SuccessCallback(_)).Times(0); |
| 451 | EXPECT_CALL(*this, FailureCallback(ConfigRef())); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 452 | config_->lease_acquisition_timeout_callback_.Reset(base::Bind(&DoNothing)); |
Paul Stewart | 1f916e4 | 2013-12-23 09:52:54 -0800 | [diff] [blame] | 453 | config_->lease_expiration_callback_.Reset(base::Bind(&DoNothing)); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 454 | config_->ProcessEventSignal(DHCPConfig::kReasonFail, conf); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 455 | Mock::VerifyAndClearExpectations(this); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 456 | EXPECT_TRUE(config_->properties().address.empty()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 457 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Paul Stewart | 1f916e4 | 2013-12-23 09:52:54 -0800 | [diff] [blame] | 458 | EXPECT_TRUE(config_->lease_expiration_callback_.IsCancelled()); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 459 | } |
| 460 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 461 | TEST_F(DHCPConfigCallbackTest, ProcessEventSignalSuccess) { |
Paul Stewart | 1f916e4 | 2013-12-23 09:52:54 -0800 | [diff] [blame] | 462 | for (const auto &reason : { DHCPConfig::kReasonBound, |
| 463 | DHCPConfig::kReasonRebind, |
| 464 | DHCPConfig::kReasonReboot, |
| 465 | DHCPConfig::kReasonRenew }) { |
| 466 | int address_octet = 0; |
| 467 | for (const auto lease_time_given : { false, true }) { |
| 468 | DHCPConfig::Configuration conf; |
| 469 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 470 | ++address_octet); |
| 471 | if (lease_time_given) { |
| 472 | const uint32 kLeaseTime = 1; |
| 473 | conf[DHCPConfig::kConfigurationKeyLeaseTime].writer().append_uint32( |
| 474 | kLeaseTime); |
| 475 | config_->lease_expiration_callback_.Cancel(); |
| 476 | } else { |
| 477 | config_->lease_expiration_callback_.Reset(base::Bind(&DoNothing)); |
| 478 | } |
| 479 | config_->lease_acquisition_timeout_callback_.Reset( |
| 480 | base::Bind(&DoNothing)); |
| 481 | EXPECT_CALL(*this, SuccessCallback(ConfigRef())); |
| 482 | EXPECT_CALL(*this, FailureCallback(_)).Times(0); |
| 483 | config_->ProcessEventSignal(reason, conf); |
| 484 | string failure_message = string(reason) + " failed with lease time " + |
| 485 | (lease_time_given ? "given" : "not given"); |
| 486 | EXPECT_TRUE(Mock::VerifyAndClearExpectations(this)) << failure_message; |
| 487 | EXPECT_EQ(base::StringPrintf("%d.0.0.0", address_octet), |
| 488 | config_->properties().address) << failure_message; |
| 489 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()) |
| 490 | << failure_message; |
| 491 | // With no lease time given, the expiration callback will be cancelled. |
| 492 | // With a lease time given, the expiration callback should be started. |
| 493 | EXPECT_EQ(!lease_time_given, |
| 494 | config_->lease_expiration_callback_.IsCancelled()) |
| 495 | << failure_message; |
| 496 | } |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 497 | } |
| 498 | } |
| 499 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 500 | TEST_F(DHCPConfigCallbackTest, ProcessEventSignalUnknown) { |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 501 | DHCPConfig::Configuration conf; |
| 502 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 503 | 0x01020304); |
| 504 | static const char kReasonUnknown[] = "UNKNOWN_REASON"; |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 505 | EXPECT_CALL(*this, SuccessCallback(_)).Times(0); |
| 506 | EXPECT_CALL(*this, FailureCallback(_)).Times(0); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 507 | config_->lease_acquisition_timeout_callback_.Reset(base::Bind(&DoNothing)); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 508 | config_->ProcessEventSignal(kReasonUnknown, conf); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 509 | Mock::VerifyAndClearExpectations(this); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 510 | EXPECT_TRUE(config_->properties().address.empty()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 511 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 512 | } |
| 513 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 514 | TEST_F(DHCPConfigCallbackTest, ProcessEventSignalGatewayArp) { |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 515 | DHCPConfig::Configuration conf; |
| 516 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 517 | 0x01020304); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 518 | EXPECT_CALL(*this, SuccessCallback(ConfigRef())); |
| 519 | EXPECT_CALL(*this, FailureCallback(_)).Times(0); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 520 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(true)); |
| 521 | config_->Start(); |
| 522 | config_->ProcessEventSignal(DHCPConfig::kReasonGatewayArp, conf); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 523 | Mock::VerifyAndClearExpectations(this); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 524 | EXPECT_EQ("4.3.2.1", config_->properties().address); |
| 525 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
| 526 | EXPECT_TRUE(config_->is_gateway_arp_active_); |
| 527 | |
| 528 | // If the timeout gets called, we shouldn't lose the lease since GatewayArp |
| 529 | // is active. |
| 530 | ScopedMockLog log; |
| 531 | EXPECT_CALL(log, Log(_, _, _)).Times(AnyNumber()); |
| 532 | EXPECT_CALL(log, Log(_, _, ::testing::EndsWith( |
| 533 | "Continuing to use our previous lease, due to gateway-ARP."))); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 534 | EXPECT_CALL(*this, SuccessCallback(_)).Times(0); |
| 535 | EXPECT_CALL(*this, FailureCallback(_)).Times(0); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 536 | config_->lease_acquisition_timeout_callback_.callback().Run(); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 537 | Mock::VerifyAndClearExpectations(this); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 538 | EXPECT_TRUE(config_->is_gateway_arp_active_); |
| 539 | |
| 540 | // An official reply from a DHCP server should reset our GatewayArp state. |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 541 | EXPECT_CALL(*this, SuccessCallback(ConfigRef())); |
| 542 | EXPECT_CALL(*this, FailureCallback(_)).Times(0); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 543 | config_->ProcessEventSignal(DHCPConfig::kReasonRenew, conf); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 544 | Mock::VerifyAndClearExpectations(this); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 545 | EXPECT_FALSE(config_->is_gateway_arp_active_); |
| 546 | } |
| 547 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 548 | TEST_F(DHCPConfigCallbackTest, ProcessEventSignalGatewayArpNak) { |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 549 | DHCPConfig::Configuration conf; |
| 550 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 551 | 0x01020304); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 552 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(true)); |
| 553 | config_->Start(); |
| 554 | config_->ProcessEventSignal(DHCPConfig::kReasonGatewayArp, conf); |
| 555 | EXPECT_TRUE(config_->is_gateway_arp_active_); |
| 556 | |
| 557 | // Sending a NAK should clear is_gateway_arp_active_. |
| 558 | config_->ProcessEventSignal(DHCPConfig::kReasonNak, conf); |
| 559 | EXPECT_FALSE(config_->is_gateway_arp_active_); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 560 | Mock::VerifyAndClearExpectations(this); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 561 | |
| 562 | // If the timeout gets called, we should lose the lease since GatewayArp |
| 563 | // is not active any more. |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 564 | EXPECT_CALL(*this, SuccessCallback(_)).Times(0); |
| 565 | EXPECT_CALL(*this, FailureCallback(ConfigRef())); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 566 | config_->lease_acquisition_timeout_callback_.callback().Run(); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 567 | Mock::VerifyAndClearExpectations(this); |
Paul Stewart | 94571f1 | 2013-09-10 17:26:07 -0700 | [diff] [blame] | 568 | } |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 569 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 570 | TEST_F(DHCPConfigTest, ReleaseIP) { |
| 571 | config_->pid_ = 1 << 18; // Ensure unknown positive PID. |
Paul Stewart | a02ee49 | 2012-05-16 10:04:53 -0700 | [diff] [blame] | 572 | config_->arp_gateway_ = false; |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 573 | EXPECT_CALL(*proxy_, Release(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 574 | config_->proxy_.reset(proxy_.release()); |
Paul Stewart | 217c61d | 2013-06-13 15:12:02 -0700 | [diff] [blame] | 575 | EXPECT_TRUE(config_->ReleaseIP(IPConfig::kReleaseReasonDisconnect)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 576 | config_->pid_ = 0; |
| 577 | } |
| 578 | |
Paul Stewart | a02ee49 | 2012-05-16 10:04:53 -0700 | [diff] [blame] | 579 | TEST_F(DHCPConfigTest, ReleaseIPArpGW) { |
| 580 | config_->pid_ = 1 << 18; // Ensure unknown positive PID. |
| 581 | config_->arp_gateway_ = true; |
| 582 | EXPECT_CALL(*proxy_, Release(kDeviceName)).Times(0); |
| 583 | config_->proxy_.reset(proxy_.release()); |
Paul Stewart | 217c61d | 2013-06-13 15:12:02 -0700 | [diff] [blame] | 584 | EXPECT_TRUE(config_->ReleaseIP(IPConfig::kReleaseReasonDisconnect)); |
| 585 | config_->pid_ = 0; |
| 586 | } |
| 587 | |
| 588 | TEST_F(DHCPConfigTest, ReleaseIPStaticIPWithLease) { |
| 589 | config_->pid_ = 1 << 18; // Ensure unknown positive PID. |
| 590 | config_->arp_gateway_ = true; |
| 591 | config_->is_lease_active_ = true; |
| 592 | EXPECT_CALL(*proxy_, Release(kDeviceName)); |
| 593 | config_->proxy_.reset(proxy_.release()); |
| 594 | EXPECT_TRUE(config_->ReleaseIP(IPConfig::kReleaseReasonStaticIP)); |
| 595 | EXPECT_EQ(NULL, config_->proxy_.get()); |
| 596 | config_->pid_ = 0; |
| 597 | } |
| 598 | |
| 599 | TEST_F(DHCPConfigTest, ReleaseIPStaticIPWithoutLease) { |
| 600 | config_->pid_ = 1 << 18; // Ensure unknown positive PID. |
| 601 | config_->arp_gateway_ = true; |
| 602 | config_->is_lease_active_ = false; |
| 603 | EXPECT_CALL(*proxy_, Release(kDeviceName)).Times(0); |
| 604 | MockDHCPProxy *proxy_pointer = proxy_.get(); |
| 605 | config_->proxy_.reset(proxy_.release()); |
| 606 | EXPECT_TRUE(config_->ReleaseIP(IPConfig::kReleaseReasonStaticIP)); |
| 607 | // Expect that proxy has not been released. |
| 608 | EXPECT_EQ(proxy_pointer, config_->proxy_.get()); |
Paul Stewart | a02ee49 | 2012-05-16 10:04:53 -0700 | [diff] [blame] | 609 | config_->pid_ = 0; |
| 610 | } |
| 611 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 612 | TEST_F(DHCPConfigTest, RenewIP) { |
Paul Stewart | 21f7b34 | 2013-11-19 10:15:58 -0800 | [diff] [blame] | 613 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(false)); |
| 614 | config_->pid_ = 0; |
| 615 | EXPECT_FALSE(config_->RenewIP()); // Expect a call to Start() if pid_ is 0. |
| 616 | Mock::VerifyAndClearExpectations(minijail_.get()); |
| 617 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).Times(0); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 618 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Paul Stewart | 1f916e4 | 2013-12-23 09:52:54 -0800 | [diff] [blame] | 619 | config_->lease_expiration_callback_.Reset(base::Bind(&DoNothing)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 620 | config_->pid_ = 456; |
Paul Stewart | c02344a | 2012-08-17 16:57:37 -0700 | [diff] [blame] | 621 | EXPECT_FALSE(config_->RenewIP()); // Expect no crash with NULL proxy. |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 622 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 623 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 624 | EXPECT_TRUE(config_->RenewIP()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 625 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Paul Stewart | 1f916e4 | 2013-12-23 09:52:54 -0800 | [diff] [blame] | 626 | EXPECT_TRUE(config_->lease_expiration_callback_.IsCancelled()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 627 | config_->pid_ = 0; |
| 628 | } |
| 629 | |
| 630 | TEST_F(DHCPConfigTest, RequestIP) { |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 631 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 632 | config_->pid_ = 567; |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 633 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 634 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 635 | EXPECT_TRUE(config_->RenewIP()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 636 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
| 637 | config_->pid_ = 0; |
| 638 | } |
| 639 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 640 | TEST_F(DHCPConfigCallbackTest, RequestIPTimeout) { |
| 641 | EXPECT_CALL(*this, SuccessCallback(_)).Times(0); |
| 642 | EXPECT_CALL(*this, FailureCallback(ConfigRef())); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 643 | config_->lease_acquisition_timeout_seconds_ = 0; |
| 644 | config_->pid_ = 567; |
| 645 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
| 646 | config_->proxy_.reset(proxy_.release()); |
| 647 | config_->RenewIP(); |
| 648 | config_->dispatcher_->DispatchPendingEvents(); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 649 | Mock::VerifyAndClearExpectations(this); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 650 | config_->pid_ = 0; |
| 651 | } |
| 652 | |
| 653 | TEST_F(DHCPConfigTest, Restart) { |
| 654 | const int kPID1 = 1 << 17; // Ensure unknown positive PID. |
| 655 | const int kPID2 = 987; |
| 656 | const unsigned int kTag1 = 11; |
| 657 | const unsigned int kTag2 = 22; |
| 658 | config_->pid_ = kPID1; |
| 659 | config_->child_watch_tag_ = kTag1; |
| 660 | DHCPProvider::GetInstance()->BindPID(kPID1, config_); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 661 | EXPECT_CALL(*glib(), SourceRemove(kTag1)).WillOnce(Return(true)); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 662 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce( |
| 663 | DoAll(SetArgumentPointee<2>(kPID2), Return(true))); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 664 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID2, _, _)).WillOnce(Return(kTag2)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 665 | EXPECT_TRUE(config_->Restart()); |
| 666 | EXPECT_EQ(kPID2, config_->pid_); |
| 667 | EXPECT_EQ(config_.get(), DHCPProvider::GetInstance()->GetConfig(kPID2).get()); |
| 668 | EXPECT_EQ(kTag2, config_->child_watch_tag_); |
| 669 | DHCPProvider::GetInstance()->UnbindPID(kPID2); |
| 670 | config_->pid_ = 0; |
| 671 | config_->child_watch_tag_ = 0; |
| 672 | } |
| 673 | |
| 674 | TEST_F(DHCPConfigTest, RestartNoClient) { |
| 675 | const int kPID = 777; |
| 676 | const unsigned int kTag = 66; |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 677 | EXPECT_CALL(*glib(), SourceRemove(_)).Times(0); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 678 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce( |
| 679 | DoAll(SetArgumentPointee<2>(kPID), Return(true))); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 680 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID, _, _)).WillOnce(Return(kTag)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 681 | EXPECT_TRUE(config_->Restart()); |
| 682 | EXPECT_EQ(kPID, config_->pid_); |
| 683 | EXPECT_EQ(config_.get(), DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 684 | EXPECT_EQ(kTag, config_->child_watch_tag_); |
| 685 | DHCPProvider::GetInstance()->UnbindPID(kPID); |
| 686 | config_->pid_ = 0; |
| 687 | config_->child_watch_tag_ = 0; |
| 688 | } |
| 689 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 690 | TEST_F(DHCPConfigTest, StartSuccessEphemeral) { |
| 691 | DHCPConfigRefPtr config = |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 692 | CreateRunningConfig(kHostName, kDeviceName, kArpGateway, !kMinimalConfig); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 693 | StopRunningConfigAndExpect(config, false); |
| 694 | } |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 695 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 696 | TEST_F(DHCPConfigTest, StartSuccessPersistent) { |
| 697 | DHCPConfigRefPtr config = |
Paul Stewart | 75a68b9 | 2013-10-24 10:50:27 -0700 | [diff] [blame] | 698 | CreateRunningConfig(kHostName, kLeaseFileSuffix, kArpGateway, |
| 699 | !kMinimalConfig); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 700 | StopRunningConfigAndExpect(config, true); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 701 | } |
| 702 | |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 703 | TEST_F(DHCPConfigCallbackTest, StartTimeout) { |
| 704 | EXPECT_CALL(*this, SuccessCallback(_)).Times(0); |
| 705 | EXPECT_CALL(*this, FailureCallback(ConfigRef())); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 706 | config_->lease_acquisition_timeout_seconds_ = 0; |
| 707 | config_->proxy_.reset(proxy_.release()); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 708 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(true)); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 709 | config_->Start(); |
| 710 | config_->dispatcher_->DispatchPendingEvents(); |
Paul Stewart | c509953 | 2013-12-12 07:53:15 -0800 | [diff] [blame] | 711 | Mock::VerifyAndClearExpectations(this); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 712 | } |
| 713 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 714 | TEST_F(DHCPConfigTest, Stop) { |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 715 | const int kPID = 1 << 17; // Ensure unknown positive PID. |
mukesh agrawal | 1835e77 | 2013-01-15 18:35:03 -0800 | [diff] [blame] | 716 | ScopedMockLog log; |
| 717 | EXPECT_CALL(log, Log(_, _, _)).Times(AnyNumber()); |
| 718 | EXPECT_CALL(log, Log(_, _, ContainsRegex( |
Darin Petkov | 3fe1766 | 2013-02-04 14:19:08 +0100 | [diff] [blame] | 719 | base::StringPrintf("Stopping.+%s", __func__)))); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 720 | config_->pid_ = kPID; |
Darin Petkov | 3fe1766 | 2013-02-04 14:19:08 +0100 | [diff] [blame] | 721 | DHCPProvider::GetInstance()->BindPID(kPID, config_); |
Paul Stewart | 1f916e4 | 2013-12-23 09:52:54 -0800 | [diff] [blame] | 722 | config_->lease_acquisition_timeout_callback_.Reset(base::Bind(&DoNothing)); |
| 723 | config_->lease_expiration_callback_.Reset(base::Bind(&DoNothing)); |
mukesh agrawal | 1835e77 | 2013-01-15 18:35:03 -0800 | [diff] [blame] | 724 | config_->Stop(__func__); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 725 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Paul Stewart | 1f916e4 | 2013-12-23 09:52:54 -0800 | [diff] [blame] | 726 | EXPECT_TRUE(config_->lease_expiration_callback_.IsCancelled()); |
Darin Petkov | 3fe1766 | 2013-02-04 14:19:08 +0100 | [diff] [blame] | 727 | EXPECT_FALSE(DHCPProvider::GetInstance()->GetConfig(kPID)); |
| 728 | EXPECT_FALSE(config_->pid_); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 729 | } |
| 730 | |
| 731 | TEST_F(DHCPConfigTest, StopDuringRequestIP) { |
| 732 | config_->pid_ = 567; |
| 733 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
| 734 | config_->proxy_.reset(proxy_.release()); |
| 735 | EXPECT_TRUE(config_->RenewIP()); |
| 736 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
| 737 | config_->pid_ = 0; // Keep Stop from killing a real process. |
mukesh agrawal | 1835e77 | 2013-01-15 18:35:03 -0800 | [diff] [blame] | 738 | config_->Stop(__func__); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 739 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 740 | } |
| 741 | |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 742 | TEST_F(DHCPConfigTest, SetProperty) { |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 743 | ::DBus::Error error; |
| 744 | // Ensure that an attempt to write a R/O property returns InvalidArgs error. |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 745 | EXPECT_FALSE(DBusAdaptor::SetProperty(config_->mutable_store(), |
Ben Chan | 0295e0f | 2013-09-20 13:47:29 -0700 | [diff] [blame] | 746 | kAddressProperty, |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 747 | PropertyStoreTest::kStringV, |
| 748 | &error)); |
mukesh agrawal | bebf1b8 | 2013-04-23 15:06:33 -0700 | [diff] [blame] | 749 | ASSERT_TRUE(error.is_set()); // name() may be invalid otherwise |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 750 | EXPECT_EQ(invalid_args(), error.name()); |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 751 | } |
| 752 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 753 | } // namespace shill |