mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Chris Masone | 8a7b8be | 2011-07-22 12:43:37 -0700 | [diff] [blame] | 5 | #include "shill/dhcp_config.h" |
| 6 | |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 7 | #include <base/bind.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 8 | #include <base/file_util.h> |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 9 | #include <base/scoped_temp_dir.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 10 | #include <base/stringprintf.h> |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 11 | #include <chromeos/dbus/service_constants.h> |
Chris Masone | 8a7b8be | 2011-07-22 12:43:37 -0700 | [diff] [blame] | 12 | #include <gtest/gtest.h> |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 13 | |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 14 | #include "shill/dbus_adaptor.h" |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 15 | #include "shill/dhcp_provider.h" |
Paul Stewart | 26b327e | 2011-10-19 11:38:09 -0700 | [diff] [blame] | 16 | #include "shill/event_dispatcher.h" |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 17 | #include "shill/mock_control.h" |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 18 | #include "shill/mock_dhcp_proxy.h" |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 19 | #include "shill/mock_glib.h" |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 20 | #include "shill/mock_minijail.h" |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 21 | #include "shill/property_store_unittest.h" |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 22 | #include "shill/proxy_factory.h" |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 23 | |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 24 | using base::Bind; |
| 25 | using base::Unretained; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 26 | using std::string; |
| 27 | using std::vector; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 28 | using testing::_; |
| 29 | using testing::Return; |
| 30 | using testing::SetArgumentPointee; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 31 | using testing::Test; |
| 32 | |
| 33 | namespace shill { |
| 34 | |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 35 | namespace { |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 36 | const char kDeviceName[] = "eth0"; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 37 | const char kHostName[] = "hostname"; |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 38 | const char kLeaseFileSuffix[] = "leasefilesuffix"; |
| 39 | const bool kArpGateway = true; |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 40 | } // namespace {} |
| 41 | |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 42 | class DHCPConfigTest : public PropertyStoreTest { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 43 | public: |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 44 | DHCPConfigTest() |
Darin Petkov | f65e928 | 2011-06-21 14:29:56 -0700 | [diff] [blame] | 45 | : proxy_(new MockDHCPProxy()), |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 46 | proxy_factory_(this), |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 47 | minijail_(new MockMinijail()), |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 48 | config_(new DHCPConfig(&control_, |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 49 | dispatcher(), |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 50 | DHCPProvider::GetInstance(), |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 51 | kDeviceName, |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 52 | kHostName, |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 53 | kLeaseFileSuffix, |
| 54 | kArpGateway, |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 55 | glib())) {} |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 56 | |
| 57 | virtual void SetUp() { |
Darin Petkov | ab565bb | 2011-10-06 02:55:51 -0700 | [diff] [blame] | 58 | config_->proxy_factory_ = &proxy_factory_; |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 59 | config_->minijail_ = minijail_.get(); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 60 | } |
| 61 | |
| 62 | virtual void TearDown() { |
Darin Petkov | ab565bb | 2011-10-06 02:55:51 -0700 | [diff] [blame] | 63 | config_->proxy_factory_ = NULL; |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 64 | config_->minijail_ = NULL; |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 65 | } |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 66 | |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 67 | DHCPConfigRefPtr CreateMockMinijailConfig(const string &hostname, |
| 68 | const string &lease_suffix, |
| 69 | bool arp_gateway); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 70 | DHCPConfigRefPtr CreateRunningConfig(const string &hostname, |
| 71 | const string &lease_suffix, |
| 72 | bool arp_gateway); |
| 73 | void StopRunningConfigAndExpect(DHCPConfigRefPtr config, |
| 74 | bool lease_file_exists); |
| 75 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 76 | protected: |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 77 | class TestProxyFactory : public ProxyFactory { |
| 78 | public: |
Paul Stewart | 7355ce1 | 2011-09-02 10:47:01 -0700 | [diff] [blame] | 79 | explicit TestProxyFactory(DHCPConfigTest *test) : test_(test) {} |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 80 | |
mukesh agrawal | 1830fa1 | 2011-09-26 14:31:40 -0700 | [diff] [blame] | 81 | virtual DHCPProxyInterface *CreateDHCPProxy(const string &/*service*/) { |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 82 | return test_->proxy_.release(); |
| 83 | } |
| 84 | |
| 85 | private: |
| 86 | DHCPConfigTest *test_; |
| 87 | }; |
| 88 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 89 | static const int kPID; |
| 90 | static const unsigned int kTag; |
| 91 | |
| 92 | FilePath lease_file_; |
| 93 | FilePath pid_file_; |
| 94 | ScopedTempDir temp_dir_; |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 95 | scoped_ptr<MockDHCPProxy> proxy_; |
| 96 | TestProxyFactory proxy_factory_; |
Chris Masone | 19e3040 | 2011-07-19 15:48:47 -0700 | [diff] [blame] | 97 | MockControl control_; |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 98 | scoped_ptr<MockMinijail> minijail_; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 99 | DHCPConfigRefPtr config_; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 100 | }; |
| 101 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 102 | const int DHCPConfigTest::kPID = 123456; |
| 103 | const unsigned int DHCPConfigTest::kTag = 77; |
| 104 | |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 105 | DHCPConfigRefPtr DHCPConfigTest::CreateMockMinijailConfig( |
| 106 | const string &hostname, |
| 107 | const string &lease_suffix, |
| 108 | bool arp_gateway) { |
| 109 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 110 | dispatcher(), |
| 111 | DHCPProvider::GetInstance(), |
| 112 | kDeviceName, |
| 113 | hostname, |
| 114 | lease_suffix, |
| 115 | arp_gateway, |
| 116 | glib())); |
| 117 | config->minijail_ = minijail_.get(); |
| 118 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(false)); |
| 119 | |
| 120 | return config; |
| 121 | } |
| 122 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 123 | DHCPConfigRefPtr DHCPConfigTest::CreateRunningConfig(const string &hostname, |
| 124 | const string &lease_suffix, |
| 125 | bool arp_gateway) { |
| 126 | DHCPConfigRefPtr config(new DHCPConfig(&control_, |
| 127 | dispatcher(), |
| 128 | DHCPProvider::GetInstance(), |
| 129 | kDeviceName, |
| 130 | hostname, |
| 131 | lease_suffix, |
| 132 | arp_gateway, |
| 133 | glib())); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 134 | config->minijail_ = minijail_.get(); |
| 135 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)) |
| 136 | .WillOnce(DoAll(SetArgumentPointee<2>(kPID), Return(true))); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 137 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID, _, _)).WillOnce(Return(kTag)); |
| 138 | EXPECT_TRUE(config->Start()); |
| 139 | EXPECT_EQ(kPID, config->pid_); |
| 140 | EXPECT_EQ(config.get(), DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 141 | EXPECT_EQ(kTag, config->child_watch_tag_); |
| 142 | |
| 143 | EXPECT_TRUE(temp_dir_.CreateUniqueTempDir()); |
| 144 | config->root_ = temp_dir_.path(); |
Jorge Lucangeli Obes | 2f3169d | 2012-04-25 11:38:25 -0700 | [diff] [blame] | 145 | FilePath varrun = temp_dir_.path().Append("var/run/dhcpcd"); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 146 | EXPECT_TRUE(file_util::CreateDirectory(varrun)); |
| 147 | pid_file_ = varrun.Append(base::StringPrintf("dhcpcd-%s.pid", kDeviceName)); |
| 148 | FilePath varlib = temp_dir_.path().Append("var/lib/dhcpcd"); |
| 149 | EXPECT_TRUE(file_util::CreateDirectory(varlib)); |
| 150 | lease_file_ = |
| 151 | varlib.Append(base::StringPrintf("dhcpcd-%s.lease", kDeviceName)); |
| 152 | EXPECT_EQ(0, file_util::WriteFile(pid_file_, "", 0)); |
| 153 | EXPECT_EQ(0, file_util::WriteFile(lease_file_, "", 0)); |
| 154 | EXPECT_TRUE(file_util::PathExists(pid_file_)); |
| 155 | EXPECT_TRUE(file_util::PathExists(lease_file_)); |
| 156 | |
| 157 | return config; |
| 158 | } |
| 159 | |
| 160 | void DHCPConfigTest::StopRunningConfigAndExpect(DHCPConfigRefPtr config, |
| 161 | bool lease_file_exists) { |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 162 | DHCPConfig::ChildWatchCallback(kPID, 0, config.get()); |
| 163 | EXPECT_EQ(NULL, DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 164 | |
| 165 | EXPECT_FALSE(file_util::PathExists(pid_file_)); |
| 166 | EXPECT_EQ(lease_file_exists, file_util::PathExists(lease_file_)); |
| 167 | } |
| 168 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 169 | TEST_F(DHCPConfigTest, GetIPv4AddressString) { |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 170 | EXPECT_EQ("255.255.255.255", config_->GetIPv4AddressString(0xffffffff)); |
| 171 | EXPECT_EQ("0.0.0.0", config_->GetIPv4AddressString(0)); |
| 172 | EXPECT_EQ("1.2.3.4", config_->GetIPv4AddressString(0x04030201)); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 173 | } |
| 174 | |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 175 | TEST_F(DHCPConfigTest, InitProxy) { |
| 176 | static const char kService[] = ":1.200"; |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 177 | EXPECT_TRUE(proxy_.get()); |
| 178 | EXPECT_FALSE(config_->proxy_.get()); |
Eric Shienbrood | 9a24553 | 2012-03-07 14:20:39 -0500 | [diff] [blame] | 179 | config_->InitProxy(kService); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 180 | EXPECT_FALSE(proxy_.get()); |
| 181 | EXPECT_TRUE(config_->proxy_.get()); |
| 182 | |
| 183 | config_->InitProxy(kService); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 184 | } |
| 185 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 186 | TEST_F(DHCPConfigTest, ParseConfiguration) { |
| 187 | DHCPConfig::Configuration conf; |
| 188 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 189 | 0x01020304); |
| 190 | conf[DHCPConfig::kConfigurationKeySubnetCIDR].writer().append_byte( |
| 191 | 16); |
| 192 | conf[DHCPConfig::kConfigurationKeyBroadcastAddress].writer().append_uint32( |
| 193 | 0x10203040); |
| 194 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 195 | vector<unsigned int> routers; |
| 196 | routers.push_back(0x02040608); |
| 197 | routers.push_back(0x03050709); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 198 | DBus::MessageIter writer = |
| 199 | conf[DHCPConfig::kConfigurationKeyRouters].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 200 | writer << routers; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 201 | } |
| 202 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 203 | vector<unsigned int> dns; |
| 204 | dns.push_back(0x09070503); |
| 205 | dns.push_back(0x08060402); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 206 | DBus::MessageIter writer = conf[DHCPConfig::kConfigurationKeyDNS].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 207 | writer << dns; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 208 | } |
| 209 | conf[DHCPConfig::kConfigurationKeyDomainName].writer().append_string( |
| 210 | "domain-name"); |
| 211 | { |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 212 | vector<string> search; |
| 213 | search.push_back("foo.com"); |
| 214 | search.push_back("bar.com"); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 215 | DBus::MessageIter writer = |
| 216 | conf[DHCPConfig::kConfigurationKeyDomainSearch].writer(); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 217 | writer << search; |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 218 | } |
| 219 | conf[DHCPConfig::kConfigurationKeyMTU].writer().append_uint16(600); |
| 220 | conf["UnknownKey"] = DBus::Variant(); |
| 221 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 222 | IPConfig::Properties properties; |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 223 | ASSERT_TRUE(config_->ParseConfiguration(conf, &properties)); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 224 | EXPECT_EQ("4.3.2.1", properties.address); |
Paul Stewart | 48100b0 | 2012-03-19 07:53:52 -0700 | [diff] [blame] | 225 | EXPECT_EQ(16, properties.subnet_prefix); |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 226 | EXPECT_EQ("64.48.32.16", properties.broadcast_address); |
| 227 | EXPECT_EQ("8.6.4.2", properties.gateway); |
| 228 | ASSERT_EQ(2, properties.dns_servers.size()); |
| 229 | EXPECT_EQ("3.5.7.9", properties.dns_servers[0]); |
| 230 | EXPECT_EQ("2.4.6.8", properties.dns_servers[1]); |
| 231 | EXPECT_EQ("domain-name", properties.domain_name); |
| 232 | ASSERT_EQ(2, properties.domain_search.size()); |
| 233 | EXPECT_EQ("foo.com", properties.domain_search[0]); |
| 234 | EXPECT_EQ("bar.com", properties.domain_search[1]); |
| 235 | EXPECT_EQ(600, properties.mtu); |
| 236 | } |
| 237 | |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 238 | TEST_F(DHCPConfigTest, StartFail) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 239 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(false)); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 240 | EXPECT_CALL(*glib(), ChildWatchAdd(_, _, _)).Times(0); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 241 | EXPECT_FALSE(config_->Start()); |
| 242 | EXPECT_EQ(0, config_->pid_); |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 243 | } |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 244 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 245 | MATCHER_P3(IsDHCPCDArgs, has_hostname, has_arp_gateway, has_lease_suffix, "") { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 246 | if (string(arg[0]) != "/sbin/dhcpcd" || |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 247 | string(arg[1]) != "-B") { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 248 | return false; |
| 249 | } |
| 250 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 251 | int end_offset = 2; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 252 | if (has_hostname) { |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 253 | if (string(arg[end_offset]) != "-h" || |
| 254 | string(arg[end_offset + 1]) != kHostName) { |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 255 | return false; |
| 256 | } |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 257 | end_offset += 2; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 258 | } |
| 259 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 260 | if (has_arp_gateway) { |
| 261 | if (string(arg[end_offset]) != "-R") |
| 262 | return false; |
| 263 | ++end_offset; |
| 264 | } |
| 265 | |
| 266 | string device_arg = has_lease_suffix ? |
| 267 | string(kDeviceName) + "=" + string(kLeaseFileSuffix) : kDeviceName; |
| 268 | return string(arg[end_offset]) == device_arg && arg[end_offset + 1] == NULL; |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 269 | } |
| 270 | |
| 271 | TEST_F(DHCPConfigTest, StartWithHostname) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 272 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(false)); |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 273 | EXPECT_FALSE(config_->Start()); |
| 274 | } |
| 275 | |
| 276 | TEST_F(DHCPConfigTest, StartWithoutHostname) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 277 | DHCPConfigRefPtr config = CreateMockMinijailConfig("", |
| 278 | kLeaseFileSuffix, |
| 279 | kArpGateway); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 280 | EXPECT_FALSE(config->Start()); |
| 281 | } |
| 282 | |
| 283 | TEST_F(DHCPConfigTest, StartWithoutArpGateway) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 284 | DHCPConfigRefPtr config = CreateMockMinijailConfig(kHostName, |
| 285 | kLeaseFileSuffix, |
| 286 | false); |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 287 | EXPECT_FALSE(config->Start()); |
| 288 | } |
| 289 | |
| 290 | TEST_F(DHCPConfigTest, StartWithoutLeaseSuffix) { |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 291 | DHCPConfigRefPtr config = CreateMockMinijailConfig(kHostName, |
| 292 | kDeviceName, |
| 293 | kArpGateway); |
Paul Stewart | d32f484 | 2012-01-11 16:08:13 -0800 | [diff] [blame] | 294 | EXPECT_FALSE(config->Start()); |
| 295 | } |
| 296 | |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 297 | namespace { |
| 298 | |
| 299 | class UpdateCallbackTest { |
| 300 | public: |
| 301 | UpdateCallbackTest(const string &message, |
Chris Masone | 2b10554 | 2011-06-22 10:58:09 -0700 | [diff] [blame] | 302 | const IPConfigRefPtr &ipconfig, |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 303 | bool success) |
| 304 | : message_(message), |
| 305 | ipconfig_(ipconfig), |
| 306 | success_(success), |
| 307 | called_(false) {} |
| 308 | |
Chris Masone | 2b10554 | 2011-06-22 10:58:09 -0700 | [diff] [blame] | 309 | void Callback(const IPConfigRefPtr &ipconfig, bool success) { |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 310 | called_ = true; |
| 311 | EXPECT_EQ(ipconfig_.get(), ipconfig.get()) << message_; |
| 312 | EXPECT_EQ(success_, success) << message_; |
| 313 | } |
| 314 | |
| 315 | bool called() const { return called_; } |
| 316 | |
| 317 | private: |
| 318 | const string message_; |
| 319 | IPConfigRefPtr ipconfig_; |
| 320 | bool success_; |
| 321 | bool called_; |
| 322 | }; |
| 323 | |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 324 | void DoNothing() {} |
| 325 | |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 326 | } // namespace {} |
| 327 | |
| 328 | TEST_F(DHCPConfigTest, ProcessEventSignalFail) { |
| 329 | DHCPConfig::Configuration conf; |
| 330 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 331 | 0x01020304); |
| 332 | UpdateCallbackTest callback_test(DHCPConfig::kReasonFail, config_, false); |
| 333 | config_->RegisterUpdateCallback( |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 334 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 335 | config_->lease_acquisition_timeout_callback_.Reset(base::Bind(&DoNothing)); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 336 | config_->ProcessEventSignal(DHCPConfig::kReasonFail, conf); |
| 337 | EXPECT_TRUE(callback_test.called()); |
| 338 | EXPECT_TRUE(config_->properties().address.empty()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 339 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 340 | } |
| 341 | |
| 342 | TEST_F(DHCPConfigTest, ProcessEventSignalSuccess) { |
| 343 | static const char * const kReasons[] = { |
| 344 | DHCPConfig::kReasonBound, |
| 345 | DHCPConfig::kReasonRebind, |
| 346 | DHCPConfig::kReasonReboot, |
| 347 | DHCPConfig::kReasonRenew |
| 348 | }; |
| 349 | for (size_t r = 0; r < arraysize(kReasons); r++) { |
| 350 | DHCPConfig::Configuration conf; |
| 351 | string message = string(kReasons[r]) + " failed"; |
| 352 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32(r); |
| 353 | UpdateCallbackTest callback_test(message, config_, true); |
| 354 | config_->RegisterUpdateCallback( |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 355 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 356 | config_->lease_acquisition_timeout_callback_.Reset(base::Bind(&DoNothing)); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 357 | config_->ProcessEventSignal(kReasons[r], conf); |
| 358 | EXPECT_TRUE(callback_test.called()) << message; |
Paul Stewart | 8322440 | 2011-11-30 14:52:30 -0800 | [diff] [blame] | 359 | EXPECT_EQ(base::StringPrintf("%zu.0.0.0", r), config_->properties().address) |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 360 | << message; |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 361 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 362 | } |
| 363 | } |
| 364 | |
| 365 | TEST_F(DHCPConfigTest, ProcessEventSignalUnknown) { |
| 366 | DHCPConfig::Configuration conf; |
| 367 | conf[DHCPConfig::kConfigurationKeyIPAddress].writer().append_uint32( |
| 368 | 0x01020304); |
| 369 | static const char kReasonUnknown[] = "UNKNOWN_REASON"; |
| 370 | UpdateCallbackTest callback_test(kReasonUnknown, config_, false); |
| 371 | config_->RegisterUpdateCallback( |
Eric Shienbrood | 3e20a23 | 2012-02-16 11:35:56 -0500 | [diff] [blame] | 372 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 373 | config_->lease_acquisition_timeout_callback_.Reset(base::Bind(&DoNothing)); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 374 | config_->ProcessEventSignal(kReasonUnknown, conf); |
| 375 | EXPECT_FALSE(callback_test.called()); |
| 376 | EXPECT_TRUE(config_->properties().address.empty()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 377 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | f9b0ca8 | 2011-06-20 12:10:23 -0700 | [diff] [blame] | 378 | } |
| 379 | |
| 380 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 381 | TEST_F(DHCPConfigTest, ReleaseIP) { |
| 382 | config_->pid_ = 1 << 18; // Ensure unknown positive PID. |
Paul Stewart | a02ee49 | 2012-05-16 10:04:53 -0700 | [diff] [blame] | 383 | config_->arp_gateway_ = false; |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 384 | EXPECT_CALL(*proxy_, Release(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 385 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 386 | EXPECT_TRUE(config_->ReleaseIP()); |
| 387 | config_->pid_ = 0; |
| 388 | } |
| 389 | |
Paul Stewart | a02ee49 | 2012-05-16 10:04:53 -0700 | [diff] [blame] | 390 | TEST_F(DHCPConfigTest, ReleaseIPArpGW) { |
| 391 | config_->pid_ = 1 << 18; // Ensure unknown positive PID. |
| 392 | config_->arp_gateway_ = true; |
| 393 | EXPECT_CALL(*proxy_, Release(kDeviceName)).Times(0); |
| 394 | config_->proxy_.reset(proxy_.release()); |
| 395 | EXPECT_TRUE(config_->ReleaseIP()); |
| 396 | config_->pid_ = 0; |
| 397 | } |
| 398 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 399 | TEST_F(DHCPConfigTest, RenewIP) { |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 400 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 401 | config_->pid_ = 456; |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 402 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 403 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 404 | EXPECT_TRUE(config_->RenewIP()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 405 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 406 | config_->pid_ = 0; |
| 407 | } |
| 408 | |
| 409 | TEST_F(DHCPConfigTest, RequestIP) { |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 410 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 411 | config_->pid_ = 567; |
Darin Petkov | aceede3 | 2011-07-18 15:32:38 -0700 | [diff] [blame] | 412 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
Darin Petkov | a7b8949 | 2011-07-27 12:48:17 -0700 | [diff] [blame] | 413 | config_->proxy_.reset(proxy_.release()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 414 | EXPECT_TRUE(config_->RenewIP()); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 415 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
| 416 | config_->pid_ = 0; |
| 417 | } |
| 418 | |
| 419 | TEST_F(DHCPConfigTest, RequestIPTimeout) { |
| 420 | UpdateCallbackTest callback_test(DHCPConfig::kReasonFail, config_, false); |
| 421 | config_->RegisterUpdateCallback( |
| 422 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
| 423 | config_->lease_acquisition_timeout_seconds_ = 0; |
| 424 | config_->pid_ = 567; |
| 425 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
| 426 | config_->proxy_.reset(proxy_.release()); |
| 427 | config_->RenewIP(); |
| 428 | config_->dispatcher_->DispatchPendingEvents(); |
| 429 | EXPECT_TRUE(callback_test.called()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 430 | config_->pid_ = 0; |
| 431 | } |
| 432 | |
| 433 | TEST_F(DHCPConfigTest, Restart) { |
| 434 | const int kPID1 = 1 << 17; // Ensure unknown positive PID. |
| 435 | const int kPID2 = 987; |
| 436 | const unsigned int kTag1 = 11; |
| 437 | const unsigned int kTag2 = 22; |
| 438 | config_->pid_ = kPID1; |
| 439 | config_->child_watch_tag_ = kTag1; |
| 440 | DHCPProvider::GetInstance()->BindPID(kPID1, config_); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 441 | EXPECT_CALL(*glib(), SourceRemove(kTag1)).WillOnce(Return(true)); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 442 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce( |
| 443 | DoAll(SetArgumentPointee<2>(kPID2), Return(true))); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 444 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID2, _, _)).WillOnce(Return(kTag2)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 445 | EXPECT_TRUE(config_->Restart()); |
| 446 | EXPECT_EQ(kPID2, config_->pid_); |
| 447 | EXPECT_EQ(config_.get(), DHCPProvider::GetInstance()->GetConfig(kPID2).get()); |
| 448 | EXPECT_EQ(kTag2, config_->child_watch_tag_); |
| 449 | DHCPProvider::GetInstance()->UnbindPID(kPID2); |
| 450 | config_->pid_ = 0; |
| 451 | config_->child_watch_tag_ = 0; |
| 452 | } |
| 453 | |
| 454 | TEST_F(DHCPConfigTest, RestartNoClient) { |
| 455 | const int kPID = 777; |
| 456 | const unsigned int kTag = 66; |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 457 | EXPECT_CALL(*glib(), SourceRemove(_)).Times(0); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 458 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce( |
| 459 | DoAll(SetArgumentPointee<2>(kPID), Return(true))); |
Chris Masone | 2176a88 | 2011-09-14 22:29:15 -0700 | [diff] [blame] | 460 | EXPECT_CALL(*glib(), ChildWatchAdd(kPID, _, _)).WillOnce(Return(kTag)); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 461 | EXPECT_TRUE(config_->Restart()); |
| 462 | EXPECT_EQ(kPID, config_->pid_); |
| 463 | EXPECT_EQ(config_.get(), DHCPProvider::GetInstance()->GetConfig(kPID).get()); |
| 464 | EXPECT_EQ(kTag, config_->child_watch_tag_); |
| 465 | DHCPProvider::GetInstance()->UnbindPID(kPID); |
| 466 | config_->pid_ = 0; |
| 467 | config_->child_watch_tag_ = 0; |
| 468 | } |
| 469 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 470 | TEST_F(DHCPConfigTest, StartSuccessEphemeral) { |
| 471 | DHCPConfigRefPtr config = |
| 472 | CreateRunningConfig(kHostName, kDeviceName, kArpGateway); |
| 473 | StopRunningConfigAndExpect(config, false); |
| 474 | } |
Darin Petkov | 92c4390 | 2011-06-09 20:46:06 -0700 | [diff] [blame] | 475 | |
Paul Stewart | d408fdf | 2012-05-07 17:15:57 -0700 | [diff] [blame] | 476 | TEST_F(DHCPConfigTest, StartSuccessPersistent) { |
| 477 | DHCPConfigRefPtr config = |
| 478 | CreateRunningConfig(kHostName, kLeaseFileSuffix, kArpGateway); |
| 479 | StopRunningConfigAndExpect(config, true); |
Darin Petkov | f7897bc | 2011-06-08 17:13:36 -0700 | [diff] [blame] | 480 | } |
| 481 | |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 482 | TEST_F(DHCPConfigTest, StartTimeout) { |
| 483 | UpdateCallbackTest callback_test(DHCPConfig::kReasonFail, config_, false); |
| 484 | config_->RegisterUpdateCallback( |
| 485 | Bind(&UpdateCallbackTest::Callback, Unretained(&callback_test))); |
| 486 | config_->lease_acquisition_timeout_seconds_ = 0; |
| 487 | config_->proxy_.reset(proxy_.release()); |
Jorge Lucangeli Obes | ad43cc6 | 2012-04-11 16:25:43 -0700 | [diff] [blame] | 488 | EXPECT_CALL(*minijail_, RunAndDestroy(_, _, _)).WillOnce(Return(true)); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 489 | config_->Start(); |
| 490 | config_->dispatcher_->DispatchPendingEvents(); |
| 491 | EXPECT_TRUE(callback_test.called()); |
| 492 | } |
| 493 | |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 494 | TEST_F(DHCPConfigTest, Stop) { |
| 495 | // Ensure no crashes. |
| 496 | const int kPID = 1 << 17; // Ensure unknown positive PID. |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 497 | config_->pid_ = kPID; |
| 498 | config_->Stop(); |
mukesh agrawal | cc0fded | 2012-05-09 13:40:58 -0700 | [diff] [blame] | 499 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
| 500 | } |
| 501 | |
| 502 | TEST_F(DHCPConfigTest, StopDuringRequestIP) { |
| 503 | config_->pid_ = 567; |
| 504 | EXPECT_CALL(*proxy_, Rebind(kDeviceName)).Times(1); |
| 505 | config_->proxy_.reset(proxy_.release()); |
| 506 | EXPECT_TRUE(config_->RenewIP()); |
| 507 | EXPECT_FALSE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
| 508 | config_->pid_ = 0; // Keep Stop from killing a real process. |
| 509 | config_->Stop(); |
| 510 | EXPECT_TRUE(config_->lease_acquisition_timeout_callback_.IsCancelled()); |
Darin Petkov | 98dd6a0 | 2011-06-10 15:12:57 -0700 | [diff] [blame] | 511 | } |
| 512 | |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 513 | TEST_F(DHCPConfigTest, SetProperty) { |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 514 | ::DBus::Error error; |
| 515 | // Ensure that an attempt to write a R/O property returns InvalidArgs error. |
mukesh agrawal | 6bb9e7c | 2012-01-30 14:57:54 -0800 | [diff] [blame] | 516 | EXPECT_FALSE(DBusAdaptor::SetProperty(config_->mutable_store(), |
| 517 | flimflam::kAddressProperty, |
| 518 | PropertyStoreTest::kStringV, |
| 519 | &error)); |
Chris Masone | 9d77993 | 2011-08-25 16:33:41 -0700 | [diff] [blame] | 520 | EXPECT_EQ(invalid_args(), error.name()); |
Chris Masone | 43b48a1 | 2011-07-01 13:37:07 -0700 | [diff] [blame] | 521 | } |
| 522 | |
Darin Petkov | e7cb7f8 | 2011-06-03 13:21:51 -0700 | [diff] [blame] | 523 | } // namespace shill |