tree 3d912eb8fca5b7c43bad421e4ba86c825b4e401e
parent 7fc87c9bc2b10eae7f5fa08708fd613186887d92
author David Pursell <dpursell@google.com> 1453435010 -0800
committer David Pursell <dpursell@google.com> 1453481355 -0800

adb: fix GetFeatureSet() to indicate failure.

Previously GetFeatureSet() on an invalid target would just return an
empty feature set, leading to some invalid assumptions, e.g. if there
isn't exactly one device connected this happens:

$ adb shell -t
error: target doesn't support PTY args -Tt

This CL adds a success/failure return value to GetFeatureSet(), and
also adds an option to print errors to stderr since that's the most
common behavior.

This will cause a slight difference in behavior for install/uninstall.
Previously they would block until the device was available, now they
print an error and quit immediately, which seems to be the more common
behavior for adb functions.

Bug: http://b/26387641
Change-Id: I0ea6ffaec922e04b9946e84f05c3870e5b549fde