tree 34d47c33650c4e2f2432d0ca7b0f8e73ebd8786b
parent 863d8e11b9b62388d9d00d7192b5e6f39fa089fa
author Michael Scott <michael.scott@linaro.org> 1465150813 -0700
committer Michael Scott <michael.scott@linaro.org> 1466434862 +0000

batterymonitor: simplify readFromFile and use std::string buffers

In readFromFile() when a newline is not found in the data, we reset
the initial character of the buffer to \0, but leave the count as is
(something >0 in this case).

Later in getBooleanField() we could erroneously treat a response as
"true" because count would be >0 and the initial value of buf would
be != '0' (set to \0 in this case).

To fixup error paths such as this, we can simplify readFromFile
by using android::base functions: ReadFromFileString() and Trim().

NOTES:
- Converted char * buffers used with readFromFile to std::string
- Removed unused variable btech from BatteryMonitor::update

Testing Done:
- Build healthd and recovery for angler device
- Confirm that known values are being read correctly from kernel
  sysfs.

Change-Id: I238bbff097543767f352aa084bf0acbc1324baca
Signed-off-by: Michael Scott <michael.scott@linaro.org>