commit 344d01f99f6049565e4342b4c4202bd9ab96340b
author Jorge Lucangeli Obes <jorgelo@google.com> Fri Jul 08 13:32:26 2016 -0400
committer Jorge Lucangeli Obes <jorgelo@google.com> Mon Jul 11 09:57:17 2016 -0400
tree 03d4aa3b5fbe3942853699bb46c6eb91d4863e3a
parent c4dc4f3fc29918b70ee963ef779079a7685c610b

Refactor Service::Start method.

This CL extracts code from Service::Start into four helper functions,
bringing Service::Start down to 134 lines vs 212 lines originally. This
makes the method a lot easier to follow. There is no change in behaviour.

Also, make error messages consistent (start with lowercase) and
format Service::Start to fit in 100 cols.

Bug: 30035168

Change-Id: If979976fba4d339a336d030f802ca9f169fd012c

init/service.h

diff --git a/init/service.h b/init/service.h
index 38c5d64..aa73aaf 100644
--- a/init/service.h
+++ b/init/service.h
@@ -113,6 +113,8 @@
     void OpenConsole() const;
     void PublishSocket(const std::string& name, int fd) const;
     void KillProcessGroup(int signal);
+    void CreateSockets(const std::string& scon);
+    void SetProcessAttributes();
 
     bool ParseClass(const std::vector<std::string>& args, std::string* err);
     bool ParseConsole(const std::vector<std::string>& args, std::string* err);