commit 56a0656ed91a01fdf09f9704a1f8a8aeb5d9f3b7
author Elliott Hughes <enh@google.com> Sat Mar 28 11:23:32 2015 -0700
committer Elliott Hughes <enh@google.com> Sat Mar 28 11:26:15 2015 -0700
tree f1626d0d105f2aa1aff4ffbd6f8de0a12fff8b77
parent 6dbbcc57a00e6b44488e595d128e27168a939a02

Further cleanup of the logic in device_init.

Change-Id: I96e4b11894926b50792b9b7d7cfa0fe8392abef6

init/devices.cpp

diff --git a/init/devices.cpp b/init/devices.cpp
index 1fa70ec..96b1696 100644
--- a/init/devices.cpp
+++ b/init/devices.cpp
@@ -992,22 +992,22 @@
 
     /* is 256K enough? udev uses 16MB! */
     device_fd = uevent_open_socket(256*1024, true);
-    if(device_fd < 0)
+    if (device_fd == -1) {
         return;
-
+    }
     fcntl(device_fd, F_SETFL, O_NONBLOCK);
 
-    struct stat info;
-    if (stat(COLDBOOT_DONE, &info) < 0) {
-        Timer t;
-        coldboot("/sys/class");
-        coldboot("/sys/block");
-        coldboot("/sys/devices");
-        close(open(COLDBOOT_DONE, O_WRONLY|O_CREAT|O_CLOEXEC, 0000));
-        NOTICE("Coldboot took %.2fs.\n", t.duration());
-    } else {
+    if (access(COLDBOOT_DONE, F_OK) == 0) {
         NOTICE("Skipping coldboot, already done!\n");
+        return;
     }
+
+    Timer t;
+    coldboot("/sys/class");
+    coldboot("/sys/block");
+    coldboot("/sys/devices");
+    close(open(COLDBOOT_DONE, O_WRONLY|O_CREAT|O_CLOEXEC, 0000));
+    NOTICE("Coldboot took %.2fs.\n", t.duration());
 }
 
 int get_device_fd()