commit 6ed33e5ada7e7a1f7d4f0a0407850021169893d3
author Elliott Hughes <enh@google.com> Wed Dec 16 18:40:04 2015 +0000
committer android-build-merger <android-build-merger@google.com> Wed Dec 16 18:40:04 2015 +0000
tree 5863acf91adc4d2292133f7ea923b91d9cb3755b
parent 14f74dae876482a2eb41e8a3802cc5b39224662a
parent ec2f506e741bbc9252d25f0f2ba1c24b1aa0ab7d

Merge "Make host ashmem_create_region more robust."
am: ec2f506e74

* commit 'ec2f506e741bbc9252d25f0f2ba1c24b1aa0ab7d':
  Make host ashmem_create_region more robust.

libcutils/ashmem-host.c

diff --git a/libcutils/ashmem-host.c b/libcutils/ashmem-host.c
index abc4f94..15dd43e 100644
--- a/libcutils/ashmem-host.c
+++ b/libcutils/ashmem-host.c
@@ -43,11 +43,16 @@
     char template[PATH_MAX];
     snprintf(template, sizeof(template), "/tmp/android-ashmem-%d-XXXXXXXXX", getpid());
     int fd = mkstemp(template);
-    if (fd != -1 && TEMP_FAILURE_RETRY(ftruncate(fd, size)) != -1 && unlink(template) != -1) {
-        return fd;
+    if (fd == -1) return -1;
+
+    unlink(template);
+
+    if (TEMP_FAILURE_RETRY(ftruncate(fd, size)) == -1) {
+      close(fd);
+      return -1;
     }
-    close(fd);
-    return -1;
+
+    return fd;
 }
 
 int ashmem_set_prot_region(int fd __unused, int prot __unused)