commit 815f74a759c56f6bbd75818a6ae6d7f7d4672e3a
author Treehugger Robot <treehugger-gerrit@google.com> Wed Aug 30 08:03:32 2017 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Aug 30 08:03:32 2017 +0000
tree 65031831f244d8167a269e3d6e46e41e825ee2ab
parent cb4e1645626bc35ac90b794504c80ea2c33b22e2
parent 4221e2cc038a6f6ca9b67e6e7fae019a3a601c11

Merge "base: hopefully fix the mac build."

sdcard/sdcard.cpp

diff --git a/sdcard/sdcard.cpp b/sdcard/sdcard.cpp
index c342cf8..343a903 100644
--- a/sdcard/sdcard.cpp
+++ b/sdcard/sdcard.cpp
@@ -249,7 +249,9 @@
     global.root.uid = AID_ROOT;
     global.root.under_android = false;
 
-    strcpy(global.source_path, source_path);
+    // Clang static analyzer think strcpy potentially overwrites other fields
+    // in global. Use snprintf() to mute the false warning.
+    snprintf(global.source_path, sizeof(global.source_path), "%s", source_path);
 
     if (multi_user) {
         global.root.perm = PERM_PRE_ROOT;