commit 8f7b9e3d39cdae8363816aa7bcbab0d79fd70cea
author Chih-Hung Hsieh <chh@google.com> Wed Jul 27 16:25:51 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Mon Aug 01 11:55:42 2016 -0700
tree 136c54668ea9515735fc14d1e71eb514c62f5a57
parent eafeb75c492677550a62dfe19623fac8b7be0344

Fix clang-tidy performance warnings in syste/core.

* Use const reference type for parameters to avoid unnecessary copy.
* Suppress warning of not using faster overloaded string find function.

Bug: 30407689
Bug: 30411878
Change-Id: I6cfdbbd50cf5e8f3db6e5263076d3a17a9a791ee
Test: build with WITH_TIDY=1
Merged-In: Ie79dbe21899867bc62031f8618bb1322b8071525

adb/adb_utils_test.cpp

diff --git a/adb/adb_utils_test.cpp b/adb/adb_utils_test.cpp
index aabc5d7..9daa397 100644
--- a/adb/adb_utils_test.cpp
+++ b/adb/adb_utils_test.cpp
@@ -111,7 +111,7 @@
   EXPECT_EQ("/system/bin", adb_dirname("/system/bin/sh/"));
 }
 
-void test_mkdirs(const std::string basepath) {
+void test_mkdirs(const std::string& basepath) {
   // Test creating a directory hierarchy.
   EXPECT_TRUE(mkdirs(basepath));
   // Test finding an existing directory hierarchy.