commit 8f7ff94762b029203fb3751573a5729a5c642370
author Josh Gao <jmgao@google.com> Wed Mar 21 18:06:20 2018 -0700
committer Josh Gao <jmgao@google.com> Wed Mar 21 18:23:09 2018 -0700
tree ac1b225f6277d23296bfe9f8952337d96f99c42e
parent ef454589e4c14e2978e11388d4cc81991182e832

adbd: spawn login shell when run without a command.

Match openssh's behavior with regards to login shells.

Bug: http://b/76116378
Test: `adb shell -T set -o` vs `ssh localhost -T set -o`
Test: `adb shell -tt set -o` vs `ssh localhost -tt set -o`
Test: `echo set -o | adb shell -T` vs `echo set -o | ssh localhost -T`
Test: `echo set -o | adb shell -tt` vs `echo set -o | ssh localhost -tt`
Change-Id: I6ed69b43e2ac79c947c242948b5617ece08a713e

adb/daemon/shell_service.cpp

diff --git a/adb/daemon/shell_service.cpp b/adb/daemon/shell_service.cpp
index c04ceaf..bb65977 100644
--- a/adb/daemon/shell_service.cpp
+++ b/adb/daemon/shell_service.cpp
@@ -335,7 +335,8 @@
         signal(SIGPIPE, SIG_DFL);
 
         if (command_.empty()) {
-            execle(_PATH_BSHELL, _PATH_BSHELL, "-", nullptr, cenv.data());
+            // Spawn a login shell if we don't have a command.
+            execle(_PATH_BSHELL, "-" _PATH_BSHELL, nullptr, cenv.data());
         } else {
             execle(_PATH_BSHELL, _PATH_BSHELL, "-c", command_.c_str(), nullptr, cenv.data());
         }