commit 919f538e6d2c9aa45034f4232e38f9e811eec6d8
author Mark Salyzyn <salyzyn@google.com> Sun Feb 04 15:27:23 2018 -0800
committer Mark Salyzyn <salyzyn@google.com> Mon Feb 05 11:00:59 2018 -0800
tree fd0c11ca20ffc74556597ad4a08c82cfcce0c328
parent 94e930551169f95593cd8732f8d9dcb452902ed0

lmkd: use after free

Remove a use-after free reference of procp->pid, using the already
captured pid variable.

Test: lmkd_unit_tests
Bug: 33808187
Change-Id: I3f5f8dd9acab2e28c81465d6195b73ae47e0a3c4

lmkd/lmkd.c

diff --git a/lmkd/lmkd.c b/lmkd/lmkd.c
index b486a17..15471e0 100644
--- a/lmkd/lmkd.c
+++ b/lmkd/lmkd.c
@@ -615,11 +615,11 @@
     pid_remove(pid);
 
     if (r) {
-        ALOGE("kill(%d): errno=%d", procp->pid, errno);
+        ALOGE("kill(%d): errno=%d", pid, errno);
         return -1;
-    } else {
-        return tasksize;
     }
+
+    return tasksize;
 }
 
 /*