commit e87a826a1df1891d2819aa70d613f7f140b11953
author Treehugger Robot <treehugger-gerrit@google.com> Tue Mar 21 20:11:07 2017 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Mar 21 20:11:09 2017 +0000
tree 6728def03e4e1c501c9067c98897f1e1bb243c67
parent 4b9a555a0f6370b939d7d4c0816b23e783918e28
parent 40578ab91f48f0654ca71cd147d0ab9359478b4b

Merge "init: Fix leaking fd and error print"

init/util.cpp

diff --git a/init/util.cpp b/init/util.cpp
index 888a366..c987181 100644
--- a/init/util.cpp
+++ b/init/util.cpp
@@ -163,7 +163,7 @@
 bool read_file(const char* path, std::string* content) {
     content->clear();
 
-    int fd = TEMP_FAILURE_RETRY(open(path, O_RDONLY|O_NOFOLLOW|O_CLOEXEC));
+    android::base::unique_fd fd(TEMP_FAILURE_RETRY(open(path, O_RDONLY | O_NOFOLLOW | O_CLOEXEC)));
     if (fd == -1) {
         return false;
     }
@@ -176,17 +176,16 @@
         return false;
     }
     if ((sb.st_mode & (S_IWGRP | S_IWOTH)) != 0) {
-        PLOG(ERROR) << "skipping insecure file '" << path << "'";
+        LOG(ERROR) << "skipping insecure file '" << path << "'";
         return false;
     }
 
-    bool okay = android::base::ReadFdToString(fd, content);
-    close(fd);
-    return okay;
+    return android::base::ReadFdToString(fd, content);
 }
 
 bool write_file(const char* path, const char* content) {
-    int fd = TEMP_FAILURE_RETRY(open(path, O_WRONLY|O_CREAT|O_NOFOLLOW|O_CLOEXEC, 0600));
+    android::base::unique_fd fd(
+        TEMP_FAILURE_RETRY(open(path, O_WRONLY | O_CREAT | O_NOFOLLOW | O_CLOEXEC, 0600)));
     if (fd == -1) {
         PLOG(ERROR) << "write_file: Unable to open '" << path << "'";
         return false;
@@ -195,7 +194,6 @@
     if (!success) {
         PLOG(ERROR) << "write_file: Unable to write to '" << path << "'";
     }
-    close(fd);
     return success;
 }