crash-reporter: Use C++11 override specifier.
Also remove some unnecessary 'void' arguments.
BUG=None
TEST=`FEATURES=test emerge-$BOARD crash-reporter`
Change-Id: I0039aec93aae14cb238f284fda756b631f9c1587
Reviewed-on: https://chromium-review.googlesource.com/211959
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
diff --git a/crash_reporter/chrome_collector.h b/crash_reporter/chrome_collector.h
index 3586d52..90e5e38 100644
--- a/crash_reporter/chrome_collector.h
+++ b/crash_reporter/chrome_collector.h
@@ -18,7 +18,7 @@
class ChromeCollector : public CrashCollector {
public:
ChromeCollector();
- virtual ~ChromeCollector();
+ ~ChromeCollector() override;
// Magic string to let Chrome know the crash report succeeded.
static const char kSuccessMagic[];
diff --git a/crash_reporter/crash_collector.cc b/crash_reporter/crash_collector.cc
index f1dbb58..966970b 100644
--- a/crash_reporter/crash_collector.cc
+++ b/crash_reporter/crash_collector.cc
@@ -154,7 +154,7 @@
}
-GHashTable *CrashCollector::GetActiveUserSessions(void) {
+GHashTable *CrashCollector::GetActiveUserSessions() {
GHashTable *active_sessions = NULL;
chromeos::dbus::BusConnection dbus = chromeos::dbus::GetSystemBusConnection();
@@ -189,7 +189,7 @@
return active_sessions;
}
-FilePath CrashCollector::GetUserCrashPath(void) {
+FilePath CrashCollector::GetUserCrashPath() {
// In this multiprofile world, there is no one-specific user dir anymore.
// Ask the session manager for the active ones, then just run with the
// first result we get back.
diff --git a/crash_reporter/crash_collector.h b/crash_reporter/crash_collector.h
index 0e78661..49aba12 100644
--- a/crash_reporter/crash_collector.h
+++ b/crash_reporter/crash_collector.h
@@ -76,8 +76,8 @@
forced_crash_directory_ = forced_directory;
}
- virtual GHashTable *GetActiveUserSessions(void);
- base::FilePath GetUserCrashPath(void);
+ virtual GHashTable *GetActiveUserSessions();
+ base::FilePath GetUserCrashPath();
base::FilePath GetCrashDirectoryInfo(uid_t process_euid,
uid_t default_user_id,
gid_t default_user_group,
diff --git a/crash_reporter/kernel_collector.h b/crash_reporter/kernel_collector.h
index 5f21747..8602564 100644
--- a/crash_reporter/kernel_collector.h
+++ b/crash_reporter/kernel_collector.h
@@ -30,7 +30,7 @@
KernelCollector();
- virtual ~KernelCollector();
+ ~KernelCollector() override;
void OverridePreservedDumpPath(const base::FilePath &file_path);
@@ -65,7 +65,7 @@
void StripSensitiveData(std::string *kernel_dump);
void GetRamoopsRecordPath(base::FilePath *path, size_t record);
- virtual bool LoadParameters();
+ bool LoadParameters();
bool HasMoreRecords();
// Read a record to string, modified from file_utils since that didn't
diff --git a/crash_reporter/kernel_warning_collector.h b/crash_reporter/kernel_warning_collector.h
index 2559d72..0b20027 100644
--- a/crash_reporter/kernel_warning_collector.h
+++ b/crash_reporter/kernel_warning_collector.h
@@ -16,7 +16,7 @@
public:
KernelWarningCollector();
- virtual ~KernelWarningCollector();
+ ~KernelWarningCollector() override;
// Collects warning.
bool Collect();
diff --git a/crash_reporter/list_proxies.cc b/crash_reporter/list_proxies.cc
index 95ad0eb..17793af 100644
--- a/crash_reporter/list_proxies.cc
+++ b/crash_reporter/list_proxies.cc
@@ -107,7 +107,7 @@
std::deque<std::string> *proxies)
: main_loop_(main_loop), proxies_(proxies) { }
- virtual void OnSignal(DBusMessage *message) {
+ void OnSignal(DBusMessage *message) override {
// Get args
char *source_url = NULL;
char *proxy_list = NULL;
diff --git a/crash_reporter/udev_collector.h b/crash_reporter/udev_collector.h
index e54ce5b..2b9bd34 100644
--- a/crash_reporter/udev_collector.h
+++ b/crash_reporter/udev_collector.h
@@ -17,7 +17,7 @@
public:
UdevCollector();
- virtual ~UdevCollector();
+ ~UdevCollector() override;
// The udev event string should be formatted as follows:
// "ACTION=[action]:KERNEL=[name]:SUBSYSTEM=[subsystem]"
diff --git a/crash_reporter/unclean_shutdown_collector.h b/crash_reporter/unclean_shutdown_collector.h
index 6324bc3..ed026bd 100644
--- a/crash_reporter/unclean_shutdown_collector.h
+++ b/crash_reporter/unclean_shutdown_collector.h
@@ -16,7 +16,7 @@
class UncleanShutdownCollector : public CrashCollector {
public:
UncleanShutdownCollector();
- virtual ~UncleanShutdownCollector();
+ ~UncleanShutdownCollector() override;
// Enable collection - signal that a boot has started.
bool Enable();
diff --git a/crash_reporter/user_collector.h b/crash_reporter/user_collector.h
index 3658e51..9f1bb9c 100644
--- a/crash_reporter/user_collector.h
+++ b/crash_reporter/user_collector.h
@@ -31,7 +31,7 @@
IsFeedbackAllowedFunction is_metrics_allowed,
bool generate_diagnostics);
- virtual ~UserCollector();
+ ~UserCollector() override;
// Enable collection.
bool Enable() { return SetUpInternal(true); }