commit | f1a5014637180457af21cc40a5ca64ab18a6947b | [log] [tgz] |
---|---|---|
author | Mike Frysinger <vapier@chromium.org> | Wed May 14 16:05:09 2014 -0400 |
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Thu May 15 23:54:00 2014 +0000 |
tree | 6f4fbd71cfa4dbb1726466236dd0fbf519a6aa56 | |
parent | 8fce2859059b27147ddd15f9a0e89a2816ed12ca [diff] [blame] |
use IGNORE_EINTR w/close HANDLE_EINTR is both not safe and not useful on Linux systems. Switch to IGNORE_EINTR like Chromium has done everywhere. See http://crbug.com/269623 for details. BUG=chromium:373154 TEST=`cbuildbot {arm,amd64,x86}-generic-full` passes Change-Id: Ib7b5c6913a63cc391005e9814200b87ed7ed7733 Reviewed-on: https://chromium-review.googlesource.com/199850 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org>
diff --git a/crash_reporter/crash_collector.cc b/crash_reporter/crash_collector.cc index 1a0898b..89d9304 100644 --- a/crash_reporter/crash_collector.cc +++ b/crash_reporter/crash_collector.cc
@@ -103,7 +103,7 @@ } int rv = file_util::WriteFileDescriptor(fd, data, size); - HANDLE_EINTR(close(fd)); + IGNORE_EINTR(close(fd)); return rv; }