Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2012-2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 17 | #include <ctype.h> |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 18 | #include <endian.h> |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 19 | #include <fcntl.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 20 | #include <stdio.h> |
| 21 | #include <string.h> |
| 22 | #include <time.h> |
| 23 | #include <unistd.h> |
| 24 | |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 25 | #include <private/android_logger.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 26 | |
Mark Salyzyn | 2ad0bd0 | 2016-02-23 08:55:43 -0800 | [diff] [blame] | 27 | #include "LogBuffer.h" |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 28 | #include "LogBufferElement.h" |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 29 | #include "LogCommand.h" |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 30 | #include "LogReader.h" |
Mark Salyzyn | 2ad0bd0 | 2016-02-23 08:55:43 -0800 | [diff] [blame] | 31 | #include "LogUtils.h" |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 32 | |
Mark Salyzyn | 5a34d6e | 2017-03-10 08:44:14 -0800 | [diff] [blame] | 33 | const log_time LogBufferElement::FLUSH_ERROR((uint32_t)-1, (uint32_t)-1); |
Mark Salyzyn | ee49c6a | 2015-06-12 14:59:42 -0700 | [diff] [blame] | 34 | atomic_int_fast64_t LogBufferElement::sequence(1); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 35 | |
Mark Salyzyn | 7e2f83c | 2014-03-05 07:41:49 -0800 | [diff] [blame] | 36 | LogBufferElement::LogBufferElement(log_id_t log_id, log_time realtime, |
Mark Salyzyn | b992d0d | 2014-03-20 16:09:38 -0700 | [diff] [blame] | 37 | uid_t uid, pid_t pid, pid_t tid, |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 38 | const char* msg, unsigned short len) |
| 39 | : mUid(uid), |
| 40 | mPid(pid), |
| 41 | mTid(tid), |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 42 | mRealTime(realtime), |
| 43 | mMsgLen(len), |
Christopher Ferris | 74e74f9 | 2017-08-02 17:54:27 -0700 | [diff] [blame] | 44 | mLogId(log_id), |
| 45 | mDropped(false) { |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 46 | mMsg = new char[len]; |
| 47 | memcpy(mMsg, msg, len); |
| 48 | } |
| 49 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 50 | LogBufferElement::LogBufferElement(const LogBufferElement& elem) |
Christopher Ferris | 74e74f9 | 2017-08-02 17:54:27 -0700 | [diff] [blame] | 51 | : mUid(elem.mUid), |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 52 | mPid(elem.mPid), |
| 53 | mTid(elem.mTid), |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 54 | mRealTime(elem.mRealTime), |
| 55 | mMsgLen(elem.mMsgLen), |
Christopher Ferris | 74e74f9 | 2017-08-02 17:54:27 -0700 | [diff] [blame] | 56 | mLogId(elem.mLogId), |
| 57 | mDropped(elem.mDropped) { |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 58 | mMsg = new char[mMsgLen]; |
| 59 | memcpy(mMsg, elem.mMsg, mMsgLen); |
| 60 | } |
| 61 | |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 62 | LogBufferElement::~LogBufferElement() { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 63 | delete[] mMsg; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 64 | } |
| 65 | |
Christopher Ferris | 74e74f9 | 2017-08-02 17:54:27 -0700 | [diff] [blame] | 66 | uint32_t LogBufferElement::getTag() const { |
| 67 | return (isBinary() && |
| 68 | ((mDropped && mMsg != nullptr) || |
| 69 | (!mDropped && mMsgLen >= sizeof(android_event_header_t)))) |
| 70 | ? reinterpret_cast<const android_event_header_t*>(mMsg)->tag |
| 71 | : 0; |
| 72 | } |
| 73 | |
| 74 | unsigned short LogBufferElement::setDropped(unsigned short value) { |
| 75 | // The tag information is saved in mMsg data, if the tag is non-zero |
| 76 | // save only the information needed to get the tag. |
| 77 | if (getTag() != 0) { |
| 78 | if (mMsgLen > sizeof(android_event_header_t)) { |
| 79 | char* truncated_msg = new char[sizeof(android_event_header_t)]; |
| 80 | memcpy(truncated_msg, mMsg, sizeof(android_event_header_t)); |
| 81 | delete[] mMsg; |
| 82 | mMsg = truncated_msg; |
| 83 | } // mMsgLen == sizeof(android_event_header_t), already at minimum. |
| 84 | } else { |
| 85 | delete[] mMsg; |
| 86 | mMsg = nullptr; |
| 87 | } |
| 88 | mDropped = true; |
| 89 | return mDroppedCount = value; |
| 90 | } |
| 91 | |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 92 | // caller must own and free character string |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 93 | char* android::tidToName(pid_t tid) { |
| 94 | char* retval = NULL; |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 95 | char buffer[256]; |
| 96 | snprintf(buffer, sizeof(buffer), "/proc/%u/comm", tid); |
| 97 | int fd = open(buffer, O_RDONLY); |
| 98 | if (fd >= 0) { |
| 99 | ssize_t ret = read(fd, buffer, sizeof(buffer)); |
| 100 | if (ret >= (ssize_t)sizeof(buffer)) { |
| 101 | ret = sizeof(buffer) - 1; |
| 102 | } |
| 103 | while ((ret > 0) && isspace(buffer[ret - 1])) { |
| 104 | --ret; |
| 105 | } |
| 106 | if (ret > 0) { |
| 107 | buffer[ret] = '\0'; |
| 108 | retval = strdup(buffer); |
| 109 | } |
| 110 | close(fd); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 111 | } |
| 112 | |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 113 | // if nothing for comm, check out cmdline |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 114 | char* name = android::pidToName(tid); |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 115 | if (!retval) { |
| 116 | retval = name; |
| 117 | name = NULL; |
| 118 | } |
| 119 | |
| 120 | // check if comm is truncated, see if cmdline has full representation |
| 121 | if (name) { |
| 122 | // impossible for retval to be NULL if name not NULL |
| 123 | size_t retval_len = strlen(retval); |
| 124 | size_t name_len = strlen(name); |
| 125 | // KISS: ToDo: Only checks prefix truncated, not suffix, or both |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 126 | if ((retval_len < name_len) && |
| 127 | !fastcmp<strcmp>(retval, name + name_len - retval_len)) { |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 128 | free(retval); |
| 129 | retval = name; |
| 130 | } else { |
| 131 | free(name); |
| 132 | } |
| 133 | } |
| 134 | return retval; |
| 135 | } |
| 136 | |
| 137 | // assumption: mMsg == NULL |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 138 | size_t LogBufferElement::populateDroppedMessage(char*& buffer, LogBuffer* parent, |
| 139 | bool lastSame) { |
Mark Salyzyn | 047cc07 | 2015-06-04 13:35:30 -0700 | [diff] [blame] | 140 | static const char tag[] = "chatty"; |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 141 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 142 | if (!__android_log_is_loggable_len(ANDROID_LOG_INFO, tag, strlen(tag), |
Mark Salyzyn | 807e40e | 2016-09-22 09:56:51 -0700 | [diff] [blame] | 143 | ANDROID_LOG_VERBOSE)) { |
Mark Salyzyn | e59c469 | 2014-10-02 13:07:05 -0700 | [diff] [blame] | 144 | return 0; |
| 145 | } |
| 146 | |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 147 | static const char format_uid[] = "uid=%u%s%s %s %u line%s"; |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 148 | parent->wrlock(); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 149 | const char* name = parent->uidToName(mUid); |
Mark Salyzyn | ed777e9 | 2015-06-24 16:22:54 -0700 | [diff] [blame] | 150 | parent->unlock(); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 151 | const char* commName = android::tidToName(mTid); |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 152 | if (!commName && (mTid != mPid)) { |
Mark Salyzyn | 17ed679 | 2015-04-20 13:35:15 -0700 | [diff] [blame] | 153 | commName = android::tidToName(mPid); |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 154 | } |
| 155 | if (!commName) { |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 156 | parent->wrlock(); |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 157 | commName = parent->pidToName(mPid); |
Mark Salyzyn | ed777e9 | 2015-06-24 16:22:54 -0700 | [diff] [blame] | 158 | parent->unlock(); |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 159 | } |
Mark Salyzyn | ddda212 | 2015-10-02 09:22:52 -0700 | [diff] [blame] | 160 | if (name && name[0] && commName && (name[0] == commName[0])) { |
| 161 | size_t len = strlen(name + 1); |
| 162 | if (!strncmp(name + 1, commName + 1, len)) { |
| 163 | if (commName[len + 1] == '\0') { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 164 | free(const_cast<char*>(commName)); |
Mark Salyzyn | ddda212 | 2015-10-02 09:22:52 -0700 | [diff] [blame] | 165 | commName = NULL; |
| 166 | } else { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 167 | free(const_cast<char*>(name)); |
Mark Salyzyn | ddda212 | 2015-10-02 09:22:52 -0700 | [diff] [blame] | 168 | name = NULL; |
| 169 | } |
Mark Salyzyn | 047cc07 | 2015-06-04 13:35:30 -0700 | [diff] [blame] | 170 | } |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 171 | } |
| 172 | if (name) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 173 | char* buf = NULL; |
Mark Salyzyn | 758058f | 2015-08-21 16:44:30 -0700 | [diff] [blame] | 174 | asprintf(&buf, "(%s)", name); |
| 175 | if (buf) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 176 | free(const_cast<char*>(name)); |
Mark Salyzyn | 758058f | 2015-08-21 16:44:30 -0700 | [diff] [blame] | 177 | name = buf; |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 178 | } |
| 179 | } |
| 180 | if (commName) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 181 | char* buf = NULL; |
Mark Salyzyn | 758058f | 2015-08-21 16:44:30 -0700 | [diff] [blame] | 182 | asprintf(&buf, " %s", commName); |
| 183 | if (buf) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 184 | free(const_cast<char*>(commName)); |
Mark Salyzyn | 758058f | 2015-08-21 16:44:30 -0700 | [diff] [blame] | 185 | commName = buf; |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 186 | } |
| 187 | } |
| 188 | // identical to below to calculate the buffer size required |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 189 | const char* type = lastSame ? "identical" : "expire"; |
Mark Salyzyn | ddda212 | 2015-10-02 09:22:52 -0700 | [diff] [blame] | 190 | size_t len = snprintf(NULL, 0, format_uid, mUid, name ? name : "", |
Christopher Ferris | 74e74f9 | 2017-08-02 17:54:27 -0700 | [diff] [blame] | 191 | commName ? commName : "", type, getDropped(), |
| 192 | (getDropped() > 1) ? "s" : ""); |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 193 | |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 194 | size_t hdrLen; |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 195 | if (isBinary()) { |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 196 | hdrLen = sizeof(android_log_event_string_t); |
| 197 | } else { |
| 198 | hdrLen = 1 + sizeof(tag); |
| 199 | } |
| 200 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 201 | buffer = static_cast<char*>(calloc(1, hdrLen + len + 1)); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 202 | if (!buffer) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 203 | free(const_cast<char*>(name)); |
| 204 | free(const_cast<char*>(commName)); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 205 | return 0; |
| 206 | } |
| 207 | |
| 208 | size_t retval = hdrLen + len; |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 209 | if (isBinary()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 210 | android_log_event_string_t* event = |
| 211 | reinterpret_cast<android_log_event_string_t*>(buffer); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 212 | |
Mark Salyzyn | 47684ca | 2016-07-15 10:19:16 -0700 | [diff] [blame] | 213 | event->header.tag = htole32(CHATTY_LOG_TAG); |
Mark Salyzyn | 758058f | 2015-08-21 16:44:30 -0700 | [diff] [blame] | 214 | event->type = EVENT_TYPE_STRING; |
| 215 | event->length = htole32(len); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 216 | } else { |
| 217 | ++retval; |
| 218 | buffer[0] = ANDROID_LOG_INFO; |
| 219 | strcpy(buffer + 1, tag); |
| 220 | } |
| 221 | |
Mark Salyzyn | 21fb7e0 | 2015-04-20 07:26:27 -0700 | [diff] [blame] | 222 | snprintf(buffer + hdrLen, len + 1, format_uid, mUid, name ? name : "", |
Christopher Ferris | 74e74f9 | 2017-08-02 17:54:27 -0700 | [diff] [blame] | 223 | commName ? commName : "", type, getDropped(), |
| 224 | (getDropped() > 1) ? "s" : ""); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 225 | free(const_cast<char*>(name)); |
| 226 | free(const_cast<char*>(commName)); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 227 | |
| 228 | return retval; |
| 229 | } |
| 230 | |
Mark Salyzyn | 5a34d6e | 2017-03-10 08:44:14 -0800 | [diff] [blame] | 231 | log_time LogBufferElement::flushTo(SocketClient* reader, LogBuffer* parent, |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 232 | bool privileged, bool lastSame) { |
Mark Salyzyn | 7b87365 | 2015-12-03 15:38:35 -0800 | [diff] [blame] | 233 | struct logger_entry_v4 entry; |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 234 | |
Mark Salyzyn | 7b87365 | 2015-12-03 15:38:35 -0800 | [diff] [blame] | 235 | memset(&entry, 0, sizeof(struct logger_entry_v4)); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 236 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 237 | entry.hdr_size = privileged ? sizeof(struct logger_entry_v4) |
| 238 | : sizeof(struct logger_entry_v3); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 239 | entry.lid = mLogId; |
| 240 | entry.pid = mPid; |
Mark Salyzyn | b992d0d | 2014-03-20 16:09:38 -0700 | [diff] [blame] | 241 | entry.tid = mTid; |
Mark Salyzyn | 7b87365 | 2015-12-03 15:38:35 -0800 | [diff] [blame] | 242 | entry.uid = mUid; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 243 | entry.sec = mRealTime.tv_sec; |
| 244 | entry.nsec = mRealTime.tv_nsec; |
| 245 | |
| 246 | struct iovec iovec[2]; |
| 247 | iovec[0].iov_base = &entry; |
Mark Salyzyn | 7b87365 | 2015-12-03 15:38:35 -0800 | [diff] [blame] | 248 | iovec[0].iov_len = entry.hdr_size; |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 249 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 250 | char* buffer = NULL; |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 251 | |
Christopher Ferris | 74e74f9 | 2017-08-02 17:54:27 -0700 | [diff] [blame] | 252 | if (mDropped) { |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 253 | entry.len = populateDroppedMessage(buffer, parent, lastSame); |
Mark Salyzyn | 5a34d6e | 2017-03-10 08:44:14 -0800 | [diff] [blame] | 254 | if (!entry.len) return mRealTime; |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 255 | iovec[1].iov_base = buffer; |
| 256 | } else { |
| 257 | entry.len = mMsgLen; |
| 258 | iovec[1].iov_base = mMsg; |
| 259 | } |
| 260 | iovec[1].iov_len = entry.len; |
| 261 | |
Mark Salyzyn | 479c8c2 | 2017-03-22 14:58:53 -0700 | [diff] [blame] | 262 | log_time retval = reader->sendDatav(iovec, 1 + (entry.len != 0)) |
| 263 | ? FLUSH_ERROR |
| 264 | : mRealTime; |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 265 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 266 | if (buffer) free(buffer); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 267 | |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 268 | return retval; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 269 | } |