Log for duplicate service registration.
Multiple copies of the same service on a device have the potential
to cause races during boot. Since we are already certain unexpected
behavior here, add a log.
Fixing: 128436272
Test: boot Pixel 2, check for logs
Test: hidl_test (check that we do see this error at the appropriate
times).
Change-Id: I4e9f445eaa3fe21226f47c770356825a2b05775c
diff --git a/ServiceManager.h b/ServiceManager.h
index 8f0c83a..e70110c 100644
--- a/ServiceManager.h
+++ b/ServiceManager.h
@@ -88,7 +88,7 @@
virtual void serviceDied(uint64_t cookie, const wp<IBase>& who);
private:
- bool addImpl(const hidl_string& name,
+ bool addImpl(const std::string& name,
const sp<IBase>& service,
const hidl_vec<hidl_string>& interfaceChain,
const AccessControl::CallingContext& callingContext);