commit | 02cdbf2eb195284c5d56282a1b0159d04a37464f | [log] [tgz] |
---|---|---|
author | Yi-Yo Chiang <yochiang@google.com> | Wed Mar 17 16:34:35 2021 +0800 |
committer | Yo Chiang <yochiang@google.com> | Thu Mar 18 04:14:55 2021 +0000 |
tree | 81a26de6622d351418765761280b8593339a7311 | |
parent | 0653276a8e772733693411e3469152bd4884555a [diff] |
KernelLogger: Update printk buffer size The buffer size isn't 1024, it's actually 1024-48 or 1024-32, depending on CONFIG_PRINTK_CALLER is defined or not. Since we don't know the kernel config at build time, we should assume the smallest possible size, which is 1024 - 48. Reference: kernel/printk/printk.c Test: Manually add code that uses the kernel logger and observe dmesg Change-Id: I5e54c9345f831de1c21de46e0f1cdbee15d0447b
This library is a collection of convenience functions to make common tasks easier and less error-prone.
In this context, "error-prone" covers both "hard to do correctly" and "hard to do with good performance", but as a general purpose library, libbase's primary focus is on making it easier to do things easily and correctly when a compromise has to be made between "simplest API" on the one hand and "fastest implementation" on the other. Though obviously the ideal is to have both.
The intention is to cover the 80% use cases, not be all things to all users.
If you have a routine that's really useful in your project, congratulations. But that doesn't mean it should be here rather than just in your project.
The question for libbase is "should everyone be doing this?"/"does this make everyone's code cleaner/safer?". Historically we've considered the bar for inclusion to be "are there at least three unrelated projects that would be cleaned up by doing so".
If your routine is actually something from a future C++ standard (that isn't yet in libc++), or it's widely used in another library, that helps show that there's precedent. Being able to say "so-and-so has used this API for n years" is a good way to reduce concerns about API choices.
Unlike most Android code, code in libbase has to build for Mac and Windows too.
Code here is also expected to have good test coverage.
By its nature, it's difficult to change libbase API. It's often best to start using your routine just in your project, and let it "graduate" after you're certain that the API is solid.