Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / libbase / 9e58f1b2690cca0823cbf258584df93fbbfef71f
commit9e58f1b2690cca0823cbf258584df93fbbfef71f[log] [tgz]
authorTom Cherry <tomcherry@google.com>Wed Aug 22 14:38:02 2018 -0700
committerTom Cherry <tomcherry@google.com>Wed Aug 22 15:02:57 2018 -0700
treee8bda6a0f3daf9b092ae6aef022cbe4820c4f34f
parent16e29cfa2d41616146f03ea9f9911ee219635621 [diff]
Fix two ParseInt edge cases

1) ParseInt and ParseUint accept strings that have spaces followed by
   a valid number, however the base check for determining hex numbers
   does not take this into account currently, but now does this this
   change.
2) ParseUint rejects negative numbers except in the case that the
   template argument is unsigned long long.  That is a mistake; it
   should reject negative numbers in all cases and this change does
   that by rejecting any string with a - prefix.

Bug: 112668205
Test: new (and old) unit tests
Change-Id: I0179b42e50adc1b169cf0e6d830283b71210a029
2 files changed
tree: e8bda6a0f3daf9b092ae6aef022cbe4820c4f34f
  1. include/
  2. .clang-format ⇨ ../.clang-format-2
  3. Android.bp
  4. chrono_utils.cpp
  5. chrono_utils_test.cpp
  6. CPPLINT.cfg
  7. endian_test.cpp
  8. errors_test.cpp
  9. errors_unix.cpp
  10. errors_windows.cpp
  11. file.cpp
  12. file_test.cpp
  13. logging.cpp
  14. logging_test.cpp
  15. macros_test.cpp
  16. OWNERS
  17. parsedouble_test.cpp
  18. parseint_test.cpp
  19. parsenetaddress.cpp
  20. parsenetaddress_test.cpp
  21. properties.cpp
  22. properties_test.cpp
  23. quick_exit.cpp
  24. quick_exit_test.cpp
  25. scopeguard_test.cpp
  26. stringprintf.cpp
  27. stringprintf_test.cpp
  28. strings.cpp
  29. strings_test.cpp
  30. test_main.cpp
  31. test_utils.cpp
  32. test_utils_test.cpp
  33. threads.cpp
  34. utf8.cpp
  35. utf8_test.cpp