Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / libbase / c50f38f14accde1e0653abe69ed4d57b413a103d
commitc50f38f14accde1e0653abe69ed4d57b413a103d[log] [tgz]
authorJosh Gao <jmgao@google.com>Mon Jan 07 19:16:21 2019 -0800
committerJosh Gao <jmgao@google.com>Wed Feb 13 13:21:54 2019 -0800
treed9320499a22b48ae8525b46ab47d2d4e3b2e75f3
parentf5b28ff20ee0e57852cc8b8b11871c5effe4bfe6 [diff]
base: add helpers for sending/receiving file descriptors.

Almost all of the uses of cmsg(3) in our source tree are wrong in at
least one of the following ways:

  - not aligning the cmsg buffer
  - leaking fds if more fds are received than expected
  - blindly dereferencing CMSG_DATA without checking the header
  - using CMSG_SPACE instead of CMSG_LEN for .cmsg_len
  - using CMSG_LEN instead of CMSG_SPACE for .msg_controllen
  - using a length specified in number of fds instead of bytes

Implement wrapper functions that implement this dumpster fire of an
API correctly.

Bug: http://b/122047630
Test: libbase_test32
Change-Id: I6ac34d67bbbf1bfa9727ab598248fc178ea19df9
5 files changed
tree: d9320499a22b48ae8525b46ab47d2d4e3b2e75f3
  1. include/
  2. .clang-format ⇨ ../.clang-format-2
  3. Android.bp
  4. chrono_utils.cpp
  5. chrono_utils_test.cpp
  6. cmsg.cpp
  7. cmsg_test.cpp
  8. CPPLINT.cfg
  9. endian_test.cpp
  10. errors_test.cpp
  11. errors_unix.cpp
  12. errors_windows.cpp
  13. file.cpp
  14. file_test.cpp
  15. logging.cpp
  16. logging_test.cpp
  17. macros_test.cpp
  18. mapped_file.cpp
  19. mapped_file_test.cpp
  20. OWNERS
  21. parsedouble_test.cpp
  22. parseint_test.cpp
  23. parsenetaddress.cpp
  24. parsenetaddress_test.cpp
  25. properties.cpp
  26. properties_test.cpp
  27. quick_exit.cpp
  28. quick_exit_test.cpp
  29. scopeguard_test.cpp
  30. stringprintf.cpp
  31. stringprintf_test.cpp
  32. strings.cpp
  33. strings_test.cpp
  34. test_main.cpp
  35. test_utils.cpp
  36. test_utils_test.cpp
  37. threads.cpp
  38. utf8.cpp
  39. utf8_test.cpp