Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Elliott Hughes | b635162 | 2015-12-04 22:00:26 -0800 | [diff] [blame] | 17 | #include "android-base/logging.h" |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 18 | |
Elliott Hughes | 4d4e90f | 2015-08-13 20:09:29 -0700 | [diff] [blame] | 19 | #include <libgen.h> |
| 20 | |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 21 | #if defined(_WIN32) |
| 22 | #include <signal.h> |
| 23 | #endif |
| 24 | |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 25 | #include <regex> |
| 26 | #include <string> |
| 27 | |
Elliott Hughes | b635162 | 2015-12-04 22:00:26 -0800 | [diff] [blame] | 28 | #include "android-base/file.h" |
| 29 | #include "android-base/stringprintf.h" |
| 30 | #include "android-base/test_utils.h" |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 31 | |
| 32 | #include <gtest/gtest.h> |
| 33 | |
| 34 | #ifdef __ANDROID__ |
| 35 | #define HOST_TEST(suite, name) TEST(suite, DISABLED_ ## name) |
| 36 | #else |
| 37 | #define HOST_TEST(suite, name) TEST(suite, name) |
| 38 | #endif |
| 39 | |
| 40 | class CapturedStderr { |
| 41 | public: |
| 42 | CapturedStderr() : old_stderr_(-1) { |
| 43 | init(); |
| 44 | } |
| 45 | |
| 46 | ~CapturedStderr() { |
| 47 | reset(); |
| 48 | } |
| 49 | |
| 50 | int fd() const { |
| 51 | return temp_file_.fd; |
| 52 | } |
| 53 | |
| 54 | private: |
| 55 | void init() { |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 56 | #if defined(_WIN32) |
| 57 | // On Windows, stderr is often buffered, so make sure it is unbuffered so |
| 58 | // that we can immediately read back what was written to stderr. |
| 59 | ASSERT_EQ(0, setvbuf(stderr, NULL, _IONBF, 0)); |
| 60 | #endif |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 61 | old_stderr_ = dup(STDERR_FILENO); |
| 62 | ASSERT_NE(-1, old_stderr_); |
| 63 | ASSERT_NE(-1, dup2(fd(), STDERR_FILENO)); |
| 64 | } |
| 65 | |
| 66 | void reset() { |
| 67 | ASSERT_NE(-1, dup2(old_stderr_, STDERR_FILENO)); |
| 68 | ASSERT_EQ(0, close(old_stderr_)); |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 69 | // Note: cannot restore prior setvbuf() setting. |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 70 | } |
| 71 | |
| 72 | TemporaryFile temp_file_; |
| 73 | int old_stderr_; |
| 74 | }; |
| 75 | |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 76 | #if defined(_WIN32) |
| 77 | static void ExitSignalAbortHandler(int) { |
| 78 | _exit(3); |
| 79 | } |
| 80 | #endif |
| 81 | |
| 82 | static void SuppressAbortUI() { |
| 83 | #if defined(_WIN32) |
| 84 | // We really just want to call _set_abort_behavior(0, _CALL_REPORTFAULT) to |
| 85 | // suppress the Windows Error Reporting dialog box, but that API is not |
| 86 | // available in the OS-supplied C Runtime, msvcrt.dll, that we currently |
| 87 | // use (it is available in the Visual Studio C runtime). |
| 88 | // |
| 89 | // Instead, we setup a SIGABRT handler, which is called in abort() right |
| 90 | // before calling Windows Error Reporting. In the handler, we exit the |
| 91 | // process just like abort() does. |
| 92 | ASSERT_NE(SIG_ERR, signal(SIGABRT, ExitSignalAbortHandler)); |
| 93 | #endif |
| 94 | } |
| 95 | |
Dan Albert | 1f65c49 | 2015-03-27 11:20:14 -0700 | [diff] [blame] | 96 | TEST(logging, CHECK) { |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 97 | ASSERT_DEATH({SuppressAbortUI(); CHECK(false);}, "Check failed: false "); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 98 | CHECK(true); |
| 99 | |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 100 | ASSERT_DEATH({SuppressAbortUI(); CHECK_EQ(0, 1);}, "Check failed: 0 == 1 "); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 101 | CHECK_EQ(0, 0); |
| 102 | |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 103 | ASSERT_DEATH({SuppressAbortUI(); CHECK_STREQ("foo", "bar");}, |
| 104 | R"(Check failed: "foo" == "bar")"); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 105 | CHECK_STREQ("foo", "foo"); |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 106 | |
| 107 | // Test whether CHECK() and CHECK_STREQ() have a dangling if with no else. |
| 108 | bool flag = false; |
| 109 | if (true) |
| 110 | CHECK(true); |
| 111 | else |
| 112 | flag = true; |
| 113 | EXPECT_FALSE(flag) << "CHECK macro probably has a dangling if with no else"; |
| 114 | |
| 115 | flag = false; |
| 116 | if (true) |
| 117 | CHECK_STREQ("foo", "foo"); |
| 118 | else |
| 119 | flag = true; |
| 120 | EXPECT_FALSE(flag) << "CHECK_STREQ probably has a dangling if with no else"; |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 121 | } |
| 122 | |
| 123 | std::string make_log_pattern(android::base::LogSeverity severity, |
| 124 | const char* message) { |
| 125 | static const char* log_characters = "VDIWEF"; |
| 126 | char log_char = log_characters[severity]; |
Spencer Low | 55853a9 | 2015-08-11 16:00:13 -0700 | [diff] [blame] | 127 | std::string holder(__FILE__); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 128 | return android::base::StringPrintf( |
Spencer Low | 55853a9 | 2015-08-11 16:00:13 -0700 | [diff] [blame] | 129 | "%c[[:space:]]+[[:digit:]]+[[:space:]]+[[:digit:]]+ %s:[[:digit:]]+] %s", |
| 130 | log_char, basename(&holder[0]), message); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 131 | } |
| 132 | |
Dan Albert | 1f65c49 | 2015-03-27 11:20:14 -0700 | [diff] [blame] | 133 | TEST(logging, LOG) { |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 134 | ASSERT_DEATH({SuppressAbortUI(); LOG(FATAL) << "foobar";}, "foobar"); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 135 | |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 136 | // We can't usefully check the output of any of these on Windows because we |
| 137 | // don't have std::regex, but we can at least make sure we printed at least as |
| 138 | // many characters are in the log message. |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 139 | { |
| 140 | CapturedStderr cap; |
| 141 | LOG(WARNING) << "foobar"; |
Elliott Hughes | a39cd13 | 2015-10-20 13:18:22 -0700 | [diff] [blame] | 142 | ASSERT_EQ(0, lseek(cap.fd(), 0, SEEK_SET)); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 143 | |
| 144 | std::string output; |
| 145 | android::base::ReadFdToString(cap.fd(), &output); |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 146 | ASSERT_GT(output.length(), strlen("foobar")); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 147 | |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 148 | #if !defined(_WIN32) |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 149 | std::regex message_regex( |
| 150 | make_log_pattern(android::base::WARNING, "foobar")); |
Spencer Low | 55853a9 | 2015-08-11 16:00:13 -0700 | [diff] [blame] | 151 | ASSERT_TRUE(std::regex_search(output, message_regex)) << output; |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 152 | #endif |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 153 | } |
| 154 | |
| 155 | { |
| 156 | CapturedStderr cap; |
| 157 | LOG(INFO) << "foobar"; |
Elliott Hughes | a39cd13 | 2015-10-20 13:18:22 -0700 | [diff] [blame] | 158 | ASSERT_EQ(0, lseek(cap.fd(), 0, SEEK_SET)); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 159 | |
| 160 | std::string output; |
| 161 | android::base::ReadFdToString(cap.fd(), &output); |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 162 | ASSERT_GT(output.length(), strlen("foobar")); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 163 | |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 164 | #if !defined(_WIN32) |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 165 | std::regex message_regex( |
| 166 | make_log_pattern(android::base::INFO, "foobar")); |
Spencer Low | 55853a9 | 2015-08-11 16:00:13 -0700 | [diff] [blame] | 167 | ASSERT_TRUE(std::regex_search(output, message_regex)) << output; |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 168 | #endif |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 169 | } |
| 170 | |
| 171 | { |
| 172 | CapturedStderr cap; |
| 173 | LOG(DEBUG) << "foobar"; |
Elliott Hughes | a39cd13 | 2015-10-20 13:18:22 -0700 | [diff] [blame] | 174 | ASSERT_EQ(0, lseek(cap.fd(), 0, SEEK_SET)); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 175 | |
| 176 | std::string output; |
| 177 | android::base::ReadFdToString(cap.fd(), &output); |
| 178 | ASSERT_TRUE(output.empty()); |
| 179 | } |
| 180 | |
| 181 | { |
| 182 | android::base::ScopedLogSeverity severity(android::base::DEBUG); |
| 183 | CapturedStderr cap; |
| 184 | LOG(DEBUG) << "foobar"; |
Elliott Hughes | a39cd13 | 2015-10-20 13:18:22 -0700 | [diff] [blame] | 185 | ASSERT_EQ(0, lseek(cap.fd(), 0, SEEK_SET)); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 186 | |
| 187 | std::string output; |
| 188 | android::base::ReadFdToString(cap.fd(), &output); |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 189 | ASSERT_GT(output.length(), strlen("foobar")); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 190 | |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 191 | #if !defined(_WIN32) |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 192 | std::regex message_regex( |
| 193 | make_log_pattern(android::base::DEBUG, "foobar")); |
Spencer Low | 55853a9 | 2015-08-11 16:00:13 -0700 | [diff] [blame] | 194 | ASSERT_TRUE(std::regex_search(output, message_regex)) << output; |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 195 | #endif |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 196 | } |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 197 | |
| 198 | // Test whether LOG() saves and restores errno. |
| 199 | { |
| 200 | CapturedStderr cap; |
| 201 | errno = 12345; |
| 202 | LOG(INFO) << (errno = 67890); |
| 203 | EXPECT_EQ(12345, errno) << "errno was not restored"; |
| 204 | |
Elliott Hughes | a39cd13 | 2015-10-20 13:18:22 -0700 | [diff] [blame] | 205 | ASSERT_EQ(0, lseek(cap.fd(), 0, SEEK_SET)); |
Spencer Low | e0671d6 | 2015-09-17 19:36:10 -0700 | [diff] [blame] | 206 | |
| 207 | std::string output; |
| 208 | android::base::ReadFdToString(cap.fd(), &output); |
| 209 | EXPECT_NE(nullptr, strstr(output.c_str(), "67890")) << output; |
| 210 | |
| 211 | #if !defined(_WIN32) |
| 212 | std::regex message_regex( |
| 213 | make_log_pattern(android::base::INFO, "67890")); |
| 214 | ASSERT_TRUE(std::regex_search(output, message_regex)) << output; |
| 215 | #endif |
| 216 | } |
| 217 | |
| 218 | // Test whether LOG() has a dangling if with no else. |
| 219 | { |
| 220 | CapturedStderr cap; |
| 221 | |
| 222 | // Do the test two ways: once where we hypothesize that LOG()'s if |
| 223 | // will evaluate to true (when severity is high enough) and once when we |
| 224 | // expect it to evaluate to false (when severity is not high enough). |
| 225 | bool flag = false; |
| 226 | if (true) |
| 227 | LOG(INFO) << "foobar"; |
| 228 | else |
| 229 | flag = true; |
| 230 | |
| 231 | EXPECT_FALSE(flag) << "LOG macro probably has a dangling if with no else"; |
| 232 | |
| 233 | flag = false; |
| 234 | if (true) |
| 235 | LOG(VERBOSE) << "foobar"; |
| 236 | else |
| 237 | flag = true; |
| 238 | |
| 239 | EXPECT_FALSE(flag) << "LOG macro probably has a dangling if with no else"; |
| 240 | } |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 241 | } |
| 242 | |
Dan Albert | 1f65c49 | 2015-03-27 11:20:14 -0700 | [diff] [blame] | 243 | TEST(logging, PLOG) { |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 244 | { |
| 245 | CapturedStderr cap; |
| 246 | errno = ENOENT; |
| 247 | PLOG(INFO) << "foobar"; |
Elliott Hughes | a39cd13 | 2015-10-20 13:18:22 -0700 | [diff] [blame] | 248 | ASSERT_EQ(0, lseek(cap.fd(), 0, SEEK_SET)); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 249 | |
| 250 | std::string output; |
| 251 | android::base::ReadFdToString(cap.fd(), &output); |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 252 | ASSERT_GT(output.length(), strlen("foobar")); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 253 | |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 254 | #if !defined(_WIN32) |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 255 | std::regex message_regex(make_log_pattern( |
| 256 | android::base::INFO, "foobar: No such file or directory")); |
Spencer Low | 55853a9 | 2015-08-11 16:00:13 -0700 | [diff] [blame] | 257 | ASSERT_TRUE(std::regex_search(output, message_regex)) << output; |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 258 | #endif |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 259 | } |
| 260 | } |
| 261 | |
Dan Albert | 1f65c49 | 2015-03-27 11:20:14 -0700 | [diff] [blame] | 262 | TEST(logging, UNIMPLEMENTED) { |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 263 | { |
| 264 | CapturedStderr cap; |
| 265 | errno = ENOENT; |
| 266 | UNIMPLEMENTED(ERROR); |
Elliott Hughes | a39cd13 | 2015-10-20 13:18:22 -0700 | [diff] [blame] | 267 | ASSERT_EQ(0, lseek(cap.fd(), 0, SEEK_SET)); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 268 | |
| 269 | std::string output; |
| 270 | android::base::ReadFdToString(cap.fd(), &output); |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 271 | ASSERT_GT(output.length(), strlen("unimplemented")); |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 272 | |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 273 | #if !defined(_WIN32) |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 274 | std::string expected_message = |
| 275 | android::base::StringPrintf("%s unimplemented ", __PRETTY_FUNCTION__); |
| 276 | std::regex message_regex( |
| 277 | make_log_pattern(android::base::ERROR, expected_message.c_str())); |
Spencer Low | 55853a9 | 2015-08-11 16:00:13 -0700 | [diff] [blame] | 278 | ASSERT_TRUE(std::regex_search(output, message_regex)) << output; |
Dan Albert | dc15ffd | 2015-04-29 11:32:23 -0700 | [diff] [blame] | 279 | #endif |
Dan Albert | e3ea058 | 2015-03-13 23:06:01 -0700 | [diff] [blame] | 280 | } |
| 281 | } |