MQDescriptor: warn about handle ownership
am: 4cee37c838
Change-Id: Ie905a0dcb7bc9811b79ba3260a58f8b2db554623
diff --git a/transport/HidlBinderSupport.cpp b/transport/HidlBinderSupport.cpp
index a96050c..b9d2d19 100644
--- a/transport/HidlBinderSupport.cpp
+++ b/transport/HidlBinderSupport.cpp
@@ -23,6 +23,7 @@
#include <hwbinder/IPCThreadState.h>
// C includes
+#include <inttypes.h>
#include <unistd.h>
// C++ includes
@@ -95,6 +96,15 @@
parentOffset + hidl_memory::kOffsetOfName);
}
+ // hidl_memory's size is stored in uint64_t, but mapMemory's mmap will map
+ // size in size_t. If size is over SIZE_MAX, mapMemory could succeed
+ // but the mapped memory's actual size will be smaller than the reported size.
+ if (memory.size() > SIZE_MAX) {
+ ALOGE("Cannot use memory with %" PRId64 " bytes because it is too large.", memory.size());
+ android_errorWriteLog(0x534e4554, "79376389");
+ return BAD_VALUE;
+ }
+
return _hidl_err;
}