Fix proxy memory leak.
Proxy objects that had a death recipient registered
could not be freed; this is because of the following
chain of events:
- Proxy objects extend BpHwRefBase
- BpHwRefBase extends the lifetime of the object to
weak - meaning it will only get freed when both
all strong *and* weak references are gone.
- When a death recipient is registered, it keeps
a weak reference to the proxy object (it needs to,
so it can pass the object in the callback).
- The death recipient objects are kept in a vector
of sp<> objects.
- Now, whenever the last strong reference to the proxy
goes away in client code, the proxy object destructor
will not run, because of the weak reference left in
the death recipient.
- But, the death recipient won't get destructed either,
because it would only get destructed in the proxy
destructor.
This fixes the leak only in case the death recipient
fires; in case the last strong reference to the proxy
object is removed by the client without the death
recipient having fired, the leak remains. This can
be prevented in client code by calling unlinkToDeath()
before getting rid of a proxy object.
Bug:62319810 (?)
Bug:63127792
Test: mma, hidl_test
Change-Id: I686863ab462e63d98737cfc5ae50a6a8fa0081c0
1 file changed