blob: a7e96263e7f9ad82e3467a0e668da4aafe727919 [file] [log] [blame]
Steven Moreland5d5ef7f2016-10-20 19:19:55 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Steven Morelandfcaa97f2019-06-24 12:07:22 -070017#define LOG_TAG "HidlServiceManagement"
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070018
Steven Moreland2056cf32019-09-17 17:41:02 -070019#ifdef __ANDROID__
Jiyong Park3ab546c2017-04-06 20:28:07 +090020#include <android/dlext.h>
Steven Moreland2056cf32019-09-17 17:41:02 -070021#endif // __ANDROID__
22
Yifan Hong9a22d1d2017-01-25 14:19:26 -080023#include <condition_variable>
24#include <dlfcn.h>
25#include <dirent.h>
Steven Moreland405d7612017-04-07 20:31:22 -070026#include <fstream>
27#include <pthread.h>
Yifan Hong9a22d1d2017-01-25 14:19:26 -080028#include <unistd.h>
29
30#include <mutex>
31#include <regex>
Yifan Hongbd0d8f72017-05-24 19:43:51 -070032#include <set>
Yifan Hong9a22d1d2017-01-25 14:19:26 -080033
Martijn Coenen12f04d92016-12-07 17:29:41 +010034#include <hidl/HidlBinderSupport.h>
Justin Yun1f048102017-12-01 15:30:08 +090035#include <hidl/HidlInternal.h>
Steven Morelande69e8d32018-03-14 10:55:42 -070036#include <hidl/HidlTransportUtils.h>
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070037#include <hidl/ServiceManagement.h>
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070038#include <hidl/Status.h>
Peter Kalauskas64ffced2018-09-05 16:41:08 -070039#include <utils/SystemClock.h>
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070040
Peter Kalauskas64ffced2018-09-05 16:41:08 -070041#include <android-base/file.h>
Steven Moreland337e6b62017-01-18 17:25:13 -080042#include <android-base/logging.h>
Peter Kalauskas64ffced2018-09-05 16:41:08 -070043#include <android-base/parseint.h>
Steven Morelandc1cee2c2017-03-24 16:23:11 +000044#include <android-base/properties.h>
Justin Yun1f048102017-12-01 15:30:08 +090045#include <android-base/stringprintf.h>
Peter Kalauskas64ffced2018-09-05 16:41:08 -070046#include <android-base/strings.h>
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070047#include <hwbinder/IPCThreadState.h>
48#include <hwbinder/Parcel.h>
Steven Moreland2056cf32019-09-17 17:41:02 -070049#if !defined(__ANDROID_RECOVERY__) && defined(__ANDROID__)
Jiyong Parkba8ace12017-05-15 15:44:39 +090050#include <vndksupport/linker.h>
Jerry Zhang86ae9992018-05-30 17:11:09 -070051#endif
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070052
Steven Moreland89909692018-05-30 14:11:19 -070053#include <android/hidl/manager/1.2/BnHwServiceManager.h>
54#include <android/hidl/manager/1.2/BpHwServiceManager.h>
55#include <android/hidl/manager/1.2/IServiceManager.h>
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070056
Steven Morelandbb9eb2a2018-10-11 12:10:01 -070057using ::android::hidl::base::V1_0::IBase;
Steven Moreland2a2678e2017-07-21 18:07:38 -070058using IServiceManager1_0 = android::hidl::manager::V1_0::IServiceManager;
59using IServiceManager1_1 = android::hidl::manager::V1_1::IServiceManager;
Steven Moreland89909692018-05-30 14:11:19 -070060using IServiceManager1_2 = android::hidl::manager::V1_2::IServiceManager;
Steven Morelandbb9eb2a2018-10-11 12:10:01 -070061using ::android::hidl::manager::V1_0::IServiceNotification;
Steven Moreland5d5ef7f2016-10-20 19:19:55 -070062
63namespace android {
64namespace hardware {
65
Yifan Hongdeacf142018-07-10 17:33:34 -070066#if defined(__ANDROID_RECOVERY__)
67static constexpr bool kIsRecovery = true;
68#else
69static constexpr bool kIsRecovery = false;
70#endif
71
Steven Morelandbb9eb2a2018-10-11 12:10:01 -070072static void waitForHwServiceManager() {
Steven Moreland2056cf32019-09-17 17:41:02 -070073 // TODO(b/31559095): need bionic host so that we can use 'prop_info' returned
74 // from WaitForProperty
75#ifdef __ANDROID__
76 static const char* kHwServicemanagerReadyProperty = "hwservicemanager.ready";
77
Steven Morelandc1cee2c2017-03-24 16:23:11 +000078 using std::literals::chrono_literals::operator""s;
79
Steven Moreland2056cf32019-09-17 17:41:02 -070080 using android::base::WaitForProperty;
Steven Morelandc1cee2c2017-03-24 16:23:11 +000081 while (!WaitForProperty(kHwServicemanagerReadyProperty, "true", 1s)) {
82 LOG(WARNING) << "Waited for hwservicemanager.ready for a second, waiting another...";
83 }
Steven Moreland2056cf32019-09-17 17:41:02 -070084#endif // __ANDROID__
Steven Morelandc1cee2c2017-03-24 16:23:11 +000085}
86
Steven Morelandbb9eb2a2018-10-11 12:10:01 -070087static std::string binaryName() {
Steven Moreland405d7612017-04-07 20:31:22 -070088 std::ifstream ifs("/proc/self/cmdline");
89 std::string cmdline;
Steven Moreland3eec5b92020-07-21 17:47:32 +000090 if (!ifs) {
Steven Moreland405d7612017-04-07 20:31:22 -070091 return "";
92 }
93 ifs >> cmdline;
94
Chih-Hung Hsieh41649d52017-08-03 14:27:21 -070095 size_t idx = cmdline.rfind('/');
Steven Moreland405d7612017-04-07 20:31:22 -070096 if (idx != std::string::npos) {
97 cmdline = cmdline.substr(idx + 1);
98 }
99
100 return cmdline;
101}
102
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700103static std::string packageWithoutVersion(const std::string& packageAndVersion) {
Steven Moreland7d09a402018-04-06 10:44:05 -0700104 size_t at = packageAndVersion.find('@');
105 if (at == std::string::npos) return packageAndVersion;
106 return packageAndVersion.substr(0, at);
107}
108
Steven Moreland3eec5b92020-07-21 17:47:32 +0000109__attribute__((noinline)) static void tryShortenProcessName(const std::string& descriptor) {
Steven Moreland7d09a402018-04-06 10:44:05 -0700110 const static std::string kTasks = "/proc/self/task/";
111
112 // make sure that this binary name is in the same package
Steven Moreland405d7612017-04-07 20:31:22 -0700113 std::string processName = binaryName();
114
Steven Moreland7d09a402018-04-06 10:44:05 -0700115 // e.x. android.hardware.foo is this package
Steven Moreland8092aa02018-10-12 15:54:56 -0700116 if (!base::StartsWith(packageWithoutVersion(processName), packageWithoutVersion(descriptor))) {
Steven Moreland405d7612017-04-07 20:31:22 -0700117 return;
118 }
119
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700120 // e.x. android.hardware.module.foo@1.2::IFoo -> foo@1.2
121 size_t lastDot = descriptor.rfind('.');
Steven Moreland7d09a402018-04-06 10:44:05 -0700122 if (lastDot == std::string::npos) return;
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700123 size_t secondDot = descriptor.rfind('.', lastDot - 1);
Steven Moreland7d09a402018-04-06 10:44:05 -0700124 if (secondDot == std::string::npos) return;
Steven Moreland405d7612017-04-07 20:31:22 -0700125
Steven Moreland7d09a402018-04-06 10:44:05 -0700126 std::string newName = processName.substr(secondDot + 1, std::string::npos);
127 ALOGI("Removing namespace from process name %s to %s.", processName.c_str(), newName.c_str());
128
129 std::unique_ptr<DIR, decltype(&closedir)> dir(opendir(kTasks.c_str()), closedir);
130 if (dir == nullptr) return;
131
132 dirent* dp;
133 while ((dp = readdir(dir.get())) != nullptr) {
134 if (dp->d_type != DT_DIR) continue;
135 if (dp->d_name[0] == '.') continue;
136
137 std::fstream fs(kTasks + dp->d_name + "/comm");
Steven Moreland3eec5b92020-07-21 17:47:32 +0000138 if (!fs) {
Steven Moreland7d09a402018-04-06 10:44:05 -0700139 ALOGI("Could not rename process, failed read comm for %s.", dp->d_name);
140 continue;
141 }
142
143 std::string oldComm;
Steven Moreland3eec5b92020-07-21 17:47:32 +0000144 if (!(fs >> oldComm)) continue;
Steven Moreland7d09a402018-04-06 10:44:05 -0700145
146 // don't rename if it already has an explicit name
Steven Moreland8092aa02018-10-12 15:54:56 -0700147 if (base::StartsWith(descriptor, oldComm)) {
Steven Moreland3eec5b92020-07-21 17:47:32 +0000148 if (!fs.seekg(0, fs.beg)) continue;
Steven Moreland7d09a402018-04-06 10:44:05 -0700149 fs << newName;
150 }
Steven Moreland405d7612017-04-07 20:31:22 -0700151 }
Steven Moreland405d7612017-04-07 20:31:22 -0700152}
153
154namespace details {
155
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700156static void onRegistrationImpl(const std::string& descriptor, const std::string& instanceName) {
Steven Moreland6c6cd372021-01-21 19:02:54 +0000157 LOG(INFO) << "Registered " << descriptor << "/" << instanceName;
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700158 tryShortenProcessName(descriptor);
159}
160
161void onRegistration(const std::string& packageName, const std::string& interfaceName,
162 const std::string& instanceName) {
163 return onRegistrationImpl(packageName + "::" + interfaceName, instanceName);
Steven Moreland405d7612017-04-07 20:31:22 -0700164}
165
166} // details
167
Steven Moreland2a2678e2017-07-21 18:07:38 -0700168sp<IServiceManager1_0> defaultServiceManager() {
Steven Moreland89909692018-05-30 14:11:19 -0700169 return defaultServiceManager1_2();
Steven Moreland2a2678e2017-07-21 18:07:38 -0700170}
171sp<IServiceManager1_1> defaultServiceManager1_1() {
Steven Moreland89909692018-05-30 14:11:19 -0700172 return defaultServiceManager1_2();
173}
174sp<IServiceManager1_2> defaultServiceManager1_2() {
175 using android::hidl::manager::V1_2::BnHwServiceManager;
176 using android::hidl::manager::V1_2::BpHwServiceManager;
177
Steven Morelandc63f0322020-04-21 14:10:53 -0700178 static std::mutex& gDefaultServiceManagerLock = *new std::mutex;
179 static sp<IServiceManager1_2>& gDefaultServiceManager = *new sp<IServiceManager1_2>;
Steven Moreland89909692018-05-30 14:11:19 -0700180
Steven Moreland5d5ef7f2016-10-20 19:19:55 -0700181 {
Steven Moreland89909692018-05-30 14:11:19 -0700182 std::lock_guard<std::mutex> _l(gDefaultServiceManagerLock);
183 if (gDefaultServiceManager != nullptr) {
184 return gDefaultServiceManager;
Yifan Hong8fb656b2017-03-16 14:30:40 -0700185 }
Steven Moreland405d7612017-04-07 20:31:22 -0700186
Yifan Hong8fb656b2017-03-16 14:30:40 -0700187 if (access("/dev/hwbinder", F_OK|R_OK|W_OK) != 0) {
188 // HwBinder not available on this device or not accessible to
189 // this process.
190 return nullptr;
191 }
Steven Morelandc1cee2c2017-03-24 16:23:11 +0000192
193 waitForHwServiceManager();
194
Steven Moreland89909692018-05-30 14:11:19 -0700195 while (gDefaultServiceManager == nullptr) {
196 gDefaultServiceManager =
197 fromBinder<IServiceManager1_2, BpHwServiceManager, BnHwServiceManager>(
198 ProcessState::self()->getContextObject(nullptr));
199 if (gDefaultServiceManager == nullptr) {
Steven Morelandc1cee2c2017-03-24 16:23:11 +0000200 LOG(ERROR) << "Waited for hwservicemanager, but got nullptr.";
Steven Moreland5d5ef7f2016-10-20 19:19:55 -0700201 sleep(1);
Yifan Hong8fb656b2017-03-16 14:30:40 -0700202 }
Steven Moreland5d5ef7f2016-10-20 19:19:55 -0700203 }
204 }
205
Steven Moreland89909692018-05-30 14:11:19 -0700206 return gDefaultServiceManager;
Steven Moreland5d5ef7f2016-10-20 19:19:55 -0700207}
208
Elliott Hughes19306142018-10-26 13:13:04 -0700209static std::vector<std::string> findFiles(const std::string& path, const std::string& prefix,
210 const std::string& suffix) {
Steven Moreland0091c092017-01-20 23:15:18 +0000211 std::unique_ptr<DIR, decltype(&closedir)> dir(opendir(path.c_str()), closedir);
212 if (!dir) return {};
213
214 std::vector<std::string> results{};
215
216 dirent* dp;
217 while ((dp = readdir(dir.get())) != nullptr) {
218 std::string name = dp->d_name;
219
Steven Moreland8092aa02018-10-12 15:54:56 -0700220 if (base::StartsWith(name, prefix) && base::EndsWith(name, suffix)) {
Steven Moreland0091c092017-01-20 23:15:18 +0000221 results.push_back(name);
222 }
223 }
224
225 return results;
226}
227
Steven Morelande518fc32020-02-26 16:38:31 -0800228static bool matchPackageName(const std::string& lib, std::string* matchedName,
229 std::string* implName) {
230#define RE_COMPONENT "[a-zA-Z_][a-zA-Z_0-9]*"
231#define RE_PATH RE_COMPONENT "(?:[.]" RE_COMPONENT ")*"
232 static const std::regex gLibraryFileNamePattern("(" RE_PATH "@[0-9]+[.][0-9]+)-impl(.*?).so");
233#undef RE_PATH
234#undef RE_COMPONENT
235
Yifan Hong9a22d1d2017-01-25 14:19:26 -0800236 std::smatch match;
237 if (std::regex_match(lib, match, gLibraryFileNamePattern)) {
238 *matchedName = match.str(1) + "::I*";
Yifan Hongbd0d8f72017-05-24 19:43:51 -0700239 *implName = match.str(2);
Yifan Hong9a22d1d2017-01-25 14:19:26 -0800240 return true;
241 }
242 return false;
243}
244
Yifan Hong7f49f592017-02-03 15:11:44 -0800245static void registerReference(const hidl_string &interfaceName, const hidl_string &instanceName) {
Yifan Hongdeacf142018-07-10 17:33:34 -0700246 if (kIsRecovery) {
247 // No hwservicemanager in recovery.
248 return;
249 }
250
Steven Moreland2a2678e2017-07-21 18:07:38 -0700251 sp<IServiceManager1_0> binderizedManager = defaultServiceManager();
Yifan Hong7f49f592017-02-03 15:11:44 -0800252 if (binderizedManager == nullptr) {
253 LOG(WARNING) << "Could not registerReference for "
254 << interfaceName << "/" << instanceName
255 << ": null binderized manager.";
256 return;
257 }
Martijn Coenenaf4aba52017-04-27 09:41:13 -0700258 auto ret = binderizedManager->registerPassthroughClient(interfaceName, instanceName);
Yifan Hong7f49f592017-02-03 15:11:44 -0800259 if (!ret.isOk()) {
260 LOG(WARNING) << "Could not registerReference for "
261 << interfaceName << "/" << instanceName
262 << ": " << ret.description();
Steven Moreland0aeaa782017-03-22 08:11:07 -0700263 return;
Yifan Hong7f49f592017-02-03 15:11:44 -0800264 }
Steven Morelande681aa52017-02-15 16:22:37 -0800265 LOG(VERBOSE) << "Successfully registerReference for "
266 << interfaceName << "/" << instanceName;
Yifan Hong7f49f592017-02-03 15:11:44 -0800267}
268
Yifan Hongbd0d8f72017-05-24 19:43:51 -0700269using InstanceDebugInfo = hidl::manager::V1_0::IServiceManager::InstanceDebugInfo;
270static inline void fetchPidsForPassthroughLibraries(
271 std::map<std::string, InstanceDebugInfo>* infos) {
272 static const std::string proc = "/proc/";
273
274 std::map<std::string, std::set<pid_t>> pids;
275 std::unique_ptr<DIR, decltype(&closedir)> dir(opendir(proc.c_str()), closedir);
276 if (!dir) return;
277 dirent* dp;
278 while ((dp = readdir(dir.get())) != nullptr) {
Stephen Hinesfd9ecee2017-09-27 18:52:52 -0700279 pid_t pid = strtoll(dp->d_name, nullptr, 0);
Yifan Hongbd0d8f72017-05-24 19:43:51 -0700280 if (pid == 0) continue;
281 std::string mapsPath = proc + dp->d_name + "/maps";
282 std::ifstream ifs{mapsPath};
283 if (!ifs.is_open()) continue;
284
285 for (std::string line; std::getline(ifs, line);) {
286 // The last token of line should look like
287 // vendor/lib64/hw/android.hardware.foo@1.0-impl-extra.so
288 // Use some simple filters to ignore bad lines before extracting libFileName
289 // and checking the key in info to make parsing faster.
290 if (line.back() != 'o') continue;
291 if (line.rfind('@') == std::string::npos) continue;
292
293 auto spacePos = line.rfind(' ');
294 if (spacePos == std::string::npos) continue;
295 auto libFileName = line.substr(spacePos + 1);
296 auto it = infos->find(libFileName);
297 if (it == infos->end()) continue;
298 pids[libFileName].insert(pid);
299 }
300 }
301 for (auto& pair : *infos) {
302 pair.second.clientPids =
303 std::vector<pid_t>{pids[pair.first].begin(), pids[pair.first].end()};
304 }
305}
306
Steven Moreland2a2678e2017-07-21 18:07:38 -0700307struct PassthroughServiceManager : IServiceManager1_1 {
Chih-Hung Hsieh41649d52017-08-03 14:27:21 -0700308 static void openLibs(
309 const std::string& fqName,
310 const std::function<bool /* continue */ (void* /* handle */, const std::string& /* lib */,
311 const std::string& /* sym */)>& eachLib) {
Steven Moreland819c05d2017-04-06 17:24:22 -0700312 //fqName looks like android.hardware.foo@1.0::IFoo
Steven Moreland519306f2017-06-06 17:14:12 -0700313 size_t idx = fqName.find("::");
Steven Moreland819c05d2017-04-06 17:24:22 -0700314
315 if (idx == std::string::npos ||
Steven Moreland519306f2017-06-06 17:14:12 -0700316 idx + strlen("::") + 1 >= fqName.size()) {
Steven Moreland337e6b62017-01-18 17:25:13 -0800317 LOG(ERROR) << "Invalid interface name passthrough lookup: " << fqName;
Steven Moreland519306f2017-06-06 17:14:12 -0700318 return;
Steven Moreland337e6b62017-01-18 17:25:13 -0800319 }
320
Steven Moreland519306f2017-06-06 17:14:12 -0700321 std::string packageAndVersion = fqName.substr(0, idx);
322 std::string ifaceName = fqName.substr(idx + strlen("::"));
Steven Moreland819c05d2017-04-06 17:24:22 -0700323
324 const std::string prefix = packageAndVersion + "-impl";
325 const std::string sym = "HIDL_FETCH_" + ifaceName;
Steven Moreland348802d2017-02-23 12:48:55 -0800326
Steven Moreland77f4c852017-10-12 11:05:53 -0700327 constexpr int dlMode = RTLD_LAZY;
328 void* handle = nullptr;
Steven Moreland337e6b62017-01-18 17:25:13 -0800329
Steven Morelanda29905c2017-03-01 10:42:35 -0800330 dlerror(); // clear
331
Justin Yun1f048102017-12-01 15:30:08 +0900332 static std::string halLibPathVndkSp = android::base::StringPrintf(
333 HAL_LIBRARY_PATH_VNDK_SP_FOR_VERSION, details::getVndkVersionStr().c_str());
Justin Yun6a323ed2018-10-18 18:41:56 +0900334 std::vector<std::string> paths = {
335 HAL_LIBRARY_PATH_ODM, HAL_LIBRARY_PATH_VENDOR, halLibPathVndkSp,
336#ifndef __ANDROID_VNDK__
337 HAL_LIBRARY_PATH_SYSTEM,
338#endif
339 };
Steven Moreland77f4c852017-10-12 11:05:53 -0700340
Steven Morelandf7dea692017-07-14 12:49:28 -0700341#ifdef LIBHIDL_TARGET_DEBUGGABLE
342 const char* env = std::getenv("TREBLE_TESTING_OVERRIDE");
343 const bool trebleTestingOverride = env && !strcmp(env, "true");
344 if (trebleTestingOverride) {
Steven Moreland77f4c852017-10-12 11:05:53 -0700345 // Load HAL implementations that are statically linked
346 handle = dlopen(nullptr, dlMode);
347 if (handle == nullptr) {
348 const char* error = dlerror();
349 LOG(ERROR) << "Failed to dlopen self: "
350 << (error == nullptr ? "unknown error" : error);
351 } else if (!eachLib(handle, "SELF", sym)) {
352 return;
353 }
Steven Morelandf7dea692017-07-14 12:49:28 -0700354 }
355#endif
Steven Moreland77f4c852017-10-12 11:05:53 -0700356
Steven Morelandf7dea692017-07-14 12:49:28 -0700357 for (const std::string& path : paths) {
Elliott Hughes19306142018-10-26 13:13:04 -0700358 std::vector<std::string> libs = findFiles(path, prefix, ".so");
Steven Moreland0091c092017-01-20 23:15:18 +0000359
Steven Moreland0091c092017-01-20 23:15:18 +0000360 for (const std::string &lib : libs) {
Steven Moreland348802d2017-02-23 12:48:55 -0800361 const std::string fullPath = path + lib;
362
Yifan Hongdeacf142018-07-10 17:33:34 -0700363 if (kIsRecovery || path == HAL_LIBRARY_PATH_SYSTEM) {
Jiyong Park3ab546c2017-04-06 20:28:07 +0900364 handle = dlopen(fullPath.c_str(), dlMode);
Steven Moreland65c00cb2017-10-12 11:35:22 -0700365 } else {
Steven Moreland2056cf32019-09-17 17:41:02 -0700366#if !defined(__ANDROID_RECOVERY__) && defined(__ANDROID__)
Steven Moreland65c00cb2017-10-12 11:35:22 -0700367 handle = android_load_sphal_library(fullPath.c_str(), dlMode);
Jerry Zhang86ae9992018-05-30 17:11:09 -0700368#endif
Jiyong Park3ab546c2017-04-06 20:28:07 +0900369 }
370
Steven Moreland348802d2017-02-23 12:48:55 -0800371 if (handle == nullptr) {
372 const char* error = dlerror();
373 LOG(ERROR) << "Failed to dlopen " << lib << ": "
374 << (error == nullptr ? "unknown error" : error);
375 continue;
Steven Moreland0091c092017-01-20 23:15:18 +0000376 }
Steven Moreland348802d2017-02-23 12:48:55 -0800377
Steven Moreland519306f2017-06-06 17:14:12 -0700378 if (!eachLib(handle, lib, sym)) {
379 return;
Steven Moreland348802d2017-02-23 12:48:55 -0800380 }
Steven Moreland337e6b62017-01-18 17:25:13 -0800381 }
382 }
Steven Moreland519306f2017-06-06 17:14:12 -0700383 }
Steven Moreland337e6b62017-01-18 17:25:13 -0800384
Steven Moreland519306f2017-06-06 17:14:12 -0700385 Return<sp<IBase>> get(const hidl_string& fqName,
386 const hidl_string& name) override {
387 sp<IBase> ret = nullptr;
388
389 openLibs(fqName, [&](void* handle, const std::string &lib, const std::string &sym) {
390 IBase* (*generator)(const char* name);
391 *(void **)(&generator) = dlsym(handle, sym.c_str());
392 if(!generator) {
393 const char* error = dlerror();
394 LOG(ERROR) << "Passthrough lookup opened " << lib
395 << " but could not find symbol " << sym << ": "
396 << (error == nullptr ? "unknown error" : error);
397 dlclose(handle);
398 return true;
399 }
400
401 ret = (*generator)(name.c_str());
402
403 if (ret == nullptr) {
404 dlclose(handle);
405 return true; // this module doesn't provide this instance name
406 }
407
Steven Morelande69e8d32018-03-14 10:55:42 -0700408 // Actual fqname might be a subclass.
409 // This assumption is tested in vts_treble_vintf_test
410 using ::android::hardware::details::getDescriptor;
411 std::string actualFqName = getDescriptor(ret.get());
412 CHECK(actualFqName.size() > 0);
413 registerReference(actualFqName, name);
Steven Moreland519306f2017-06-06 17:14:12 -0700414 return false;
415 });
416
417 return ret;
Steven Moreland337e6b62017-01-18 17:25:13 -0800418 }
419
Martijn Coenen67a02492017-03-06 13:04:48 +0100420 Return<bool> add(const hidl_string& /* name */,
Steven Moreland337e6b62017-01-18 17:25:13 -0800421 const sp<IBase>& /* service */) override {
422 LOG(FATAL) << "Cannot register services with passthrough service manager.";
423 return false;
424 }
425
Steven Morelandc601c5f2017-04-06 09:26:07 -0700426 Return<Transport> getTransport(const hidl_string& /* fqName */,
427 const hidl_string& /* name */) {
428 LOG(FATAL) << "Cannot getTransport with passthrough service manager.";
429 return Transport::EMPTY;
430 }
431
Yifan Hong705e5da2017-03-02 16:59:39 -0800432 Return<void> list(list_cb /* _hidl_cb */) override {
433 LOG(FATAL) << "Cannot list services with passthrough service manager.";
Steven Moreland337e6b62017-01-18 17:25:13 -0800434 return Void();
435 }
436 Return<void> listByInterface(const hidl_string& /* fqInstanceName */,
437 listByInterface_cb /* _hidl_cb */) override {
438 // TODO: add this functionality
439 LOG(FATAL) << "Cannot list services with passthrough service manager.";
440 return Void();
441 }
442
443 Return<bool> registerForNotifications(const hidl_string& /* fqName */,
444 const hidl_string& /* name */,
445 const sp<IServiceNotification>& /* callback */) override {
446 // This makes no sense.
447 LOG(FATAL) << "Cannot register for notifications with passthrough service manager.";
448 return false;
449 }
450
Yifan Hong705e5da2017-03-02 16:59:39 -0800451 Return<void> debugDump(debugDump_cb _hidl_cb) override {
452 using Arch = ::android::hidl::base::V1_0::DebugInfo::Architecture;
Yifan Hongbd0d8f72017-05-24 19:43:51 -0700453 using std::literals::string_literals::operator""s;
Justin Yun1f048102017-12-01 15:30:08 +0900454 static std::string halLibPathVndkSp64 = android::base::StringPrintf(
455 HAL_LIBRARY_PATH_VNDK_SP_64BIT_FOR_VERSION, details::getVndkVersionStr().c_str());
456 static std::string halLibPathVndkSp32 = android::base::StringPrintf(
457 HAL_LIBRARY_PATH_VNDK_SP_32BIT_FOR_VERSION, details::getVndkVersionStr().c_str());
Jiyong Park56eb1492017-08-04 16:16:13 +0900458 static std::vector<std::pair<Arch, std::vector<const char*>>> sAllPaths{
459 {Arch::IS_64BIT,
Justin Yun6a323ed2018-10-18 18:41:56 +0900460 {
461 HAL_LIBRARY_PATH_ODM_64BIT, HAL_LIBRARY_PATH_VENDOR_64BIT,
462 halLibPathVndkSp64.c_str(),
463#ifndef __ANDROID_VNDK__
464 HAL_LIBRARY_PATH_SYSTEM_64BIT,
465#endif
466 }},
Jiyong Park56eb1492017-08-04 16:16:13 +0900467 {Arch::IS_32BIT,
Justin Yun6a323ed2018-10-18 18:41:56 +0900468 {
469 HAL_LIBRARY_PATH_ODM_32BIT, HAL_LIBRARY_PATH_VENDOR_32BIT,
470 halLibPathVndkSp32.c_str(),
471#ifndef __ANDROID_VNDK__
472 HAL_LIBRARY_PATH_SYSTEM_32BIT,
473#endif
474 }}};
Yifan Hongbd0d8f72017-05-24 19:43:51 -0700475 std::map<std::string, InstanceDebugInfo> map;
Yifan Hong705e5da2017-03-02 16:59:39 -0800476 for (const auto &pair : sAllPaths) {
477 Arch arch = pair.first;
478 for (const auto &path : pair.second) {
Elliott Hughes19306142018-10-26 13:13:04 -0700479 std::vector<std::string> libs = findFiles(path, "", ".so");
Yifan Hong705e5da2017-03-02 16:59:39 -0800480 for (const std::string &lib : libs) {
481 std::string matchedName;
Yifan Hongbd0d8f72017-05-24 19:43:51 -0700482 std::string implName;
483 if (matchPackageName(lib, &matchedName, &implName)) {
484 std::string instanceName{"* ("s + path + ")"s};
485 if (!implName.empty()) instanceName += " ("s + implName + ")"s;
486 map.emplace(path + lib, InstanceDebugInfo{.interfaceName = matchedName,
487 .instanceName = instanceName,
488 .clientPids = {},
489 .arch = arch});
Yifan Hong705e5da2017-03-02 16:59:39 -0800490 }
491 }
492 }
493 }
Yifan Hongbd0d8f72017-05-24 19:43:51 -0700494 fetchPidsForPassthroughLibraries(&map);
495 hidl_vec<InstanceDebugInfo> vec;
496 vec.resize(map.size());
497 size_t idx = 0;
498 for (auto&& pair : map) {
499 vec[idx++] = std::move(pair.second);
500 }
Yifan Hong705e5da2017-03-02 16:59:39 -0800501 _hidl_cb(vec);
Yifan Hong7f49f592017-02-03 15:11:44 -0800502 return Void();
503 }
504
Martijn Coenenaf4aba52017-04-27 09:41:13 -0700505 Return<void> registerPassthroughClient(const hidl_string &, const hidl_string &) override {
Yifan Hong7f49f592017-02-03 15:11:44 -0800506 // This makes no sense.
507 LOG(FATAL) << "Cannot call registerPassthroughClient on passthrough service manager. "
508 << "Call it on defaultServiceManager() instead.";
Yifan Hong9a22d1d2017-01-25 14:19:26 -0800509 return Void();
510 }
511
Steven Moreland2a2678e2017-07-21 18:07:38 -0700512 Return<bool> unregisterForNotifications(const hidl_string& /* fqName */,
513 const hidl_string& /* name */,
514 const sp<IServiceNotification>& /* callback */) override {
515 // This makes no sense.
516 LOG(FATAL) << "Cannot unregister for notifications with passthrough service manager.";
517 return false;
518 }
519
Steven Moreland337e6b62017-01-18 17:25:13 -0800520};
521
Steven Moreland2a2678e2017-07-21 18:07:38 -0700522sp<IServiceManager1_0> getPassthroughServiceManager() {
523 return getPassthroughServiceManager1_1();
524}
525sp<IServiceManager1_1> getPassthroughServiceManager1_1() {
Steven Moreland337e6b62017-01-18 17:25:13 -0800526 static sp<PassthroughServiceManager> manager(new PassthroughServiceManager());
527 return manager;
528}
529
Steven Moreland92b247c2019-08-21 14:53:11 -0700530std::vector<std::string> getAllHalInstanceNames(const std::string& descriptor) {
531 std::vector<std::string> ret;
532 auto sm = defaultServiceManager1_2();
533 sm->listManifestByInterface(descriptor, [&](const auto& instances) {
534 ret.reserve(instances.size());
535 for (const auto& i : instances) {
536 ret.push_back(i);
537 }
538 });
539 return ret;
540}
541
Steven Morelandcbefd352017-01-23 20:29:05 -0800542namespace details {
543
Steven Moreland519306f2017-06-06 17:14:12 -0700544void preloadPassthroughService(const std::string &descriptor) {
545 PassthroughServiceManager::openLibs(descriptor,
546 [&](void* /* handle */, const std::string& /* lib */, const std::string& /* sym */) {
547 // do nothing
548 return true; // open all libs
549 });
550}
551
Steven Morelandcbefd352017-01-23 20:29:05 -0800552struct Waiter : IServiceNotification {
Martijn Coenen773609e2017-10-24 09:57:53 +0200553 Waiter(const std::string& interface, const std::string& instanceName,
554 const sp<IServiceManager1_1>& sm) : mInterfaceName(interface),
555 mInstanceName(instanceName), mSm(sm) {
Martijn Coenene6cdfd32017-11-13 14:03:05 +0100556 }
557
558 void onFirstRef() override {
Martijn Coenenb88ae7f2017-10-24 11:45:41 +0200559 // If this process only has one binder thread, and we're calling wait() from
560 // that thread, it will block forever because we hung up the one and only
561 // binder thread on a condition variable that can only be notified by an
562 // incoming binder call.
Tobias Lindskog88e886f2018-01-05 10:32:43 +0100563 if (IPCThreadState::self()->isOnlyBinderThread()) {
Martijn Coenenb88ae7f2017-10-24 11:45:41 +0200564 LOG(WARNING) << "Can't efficiently wait for " << mInterfaceName << "/"
565 << mInstanceName << ", because we are called from "
566 << "the only binder thread in this process.";
567 return;
568 }
569
Martijn Coenene6cdfd32017-11-13 14:03:05 +0100570 Return<bool> ret = mSm->registerForNotifications(mInterfaceName, mInstanceName, this);
Martijn Coenen773609e2017-10-24 09:57:53 +0200571
572 if (!ret.isOk()) {
573 LOG(ERROR) << "Transport error, " << ret.description()
Martijn Coenene6cdfd32017-11-13 14:03:05 +0100574 << ", during notification registration for " << mInterfaceName << "/"
575 << mInstanceName << ".";
Martijn Coenen773609e2017-10-24 09:57:53 +0200576 return;
577 }
578
579 if (!ret) {
Martijn Coenene6cdfd32017-11-13 14:03:05 +0100580 LOG(ERROR) << "Could not register for notifications for " << mInterfaceName << "/"
581 << mInstanceName << ".";
Martijn Coenen773609e2017-10-24 09:57:53 +0200582 return;
583 }
584
585 mRegisteredForNotifications = true;
586 }
587
588 ~Waiter() {
Martijn Coenen3fa15c22018-02-10 11:30:00 +0100589 if (!mDoneCalled) {
590 LOG(FATAL)
591 << "Waiter still registered for notifications, call done() before dropping ref!";
Martijn Coenen773609e2017-10-24 09:57:53 +0200592 }
593 }
594
Steven Morelandcbefd352017-01-23 20:29:05 -0800595 Return<void> onRegistration(const hidl_string& /* fqName */,
596 const hidl_string& /* name */,
597 bool /* preexisting */) override {
598 std::unique_lock<std::mutex> lock(mMutex);
599 if (mRegistered) {
600 return Void();
601 }
602 mRegistered = true;
603 lock.unlock();
604
605 mCondition.notify_one();
606 return Void();
607 }
608
Steven Moreland0771d8a2018-05-09 13:29:14 -0700609 void wait(bool timeout) {
Steven Moreland49605102017-03-28 09:33:06 -0700610 using std::literals::chrono_literals::operator""s;
611
Martijn Coenen773609e2017-10-24 09:57:53 +0200612 if (!mRegisteredForNotifications) {
613 // As an alternative, just sleep for a second and return
614 LOG(WARNING) << "Waiting one second for " << mInterfaceName << "/" << mInstanceName;
615 sleep(1);
616 return;
617 }
618
Steven Morelandcbefd352017-01-23 20:29:05 -0800619 std::unique_lock<std::mutex> lock(mMutex);
Steven Moreland0771d8a2018-05-09 13:29:14 -0700620 do {
Steven Moreland49605102017-03-28 09:33:06 -0700621 mCondition.wait_for(lock, 1s, [this]{
622 return mRegistered;
623 });
624
625 if (mRegistered) {
626 break;
627 }
628
Steven Moreland0771d8a2018-05-09 13:29:14 -0700629 LOG(WARNING) << "Waited one second for " << mInterfaceName << "/" << mInstanceName;
630 } while (!timeout);
Steven Morelandcbefd352017-01-23 20:29:05 -0800631 }
632
Martijn Coenen773609e2017-10-24 09:57:53 +0200633 // Be careful when using this; after calling reset(), you must always try to retrieve
634 // the corresponding service before blocking on the waiter; otherwise, you might run
635 // into a race-condition where the service has just (re-)registered, you clear the state
636 // here, and subsequently calling waiter->wait() will block forever.
637 void reset() {
638 std::unique_lock<std::mutex> lock(mMutex);
639 mRegistered = false;
640 }
Martijn Coenen3fa15c22018-02-10 11:30:00 +0100641
642 // done() must be called before dropping the last strong ref to the Waiter, to make
643 // sure we can properly unregister with hwservicemanager.
644 void done() {
645 if (mRegisteredForNotifications) {
646 if (!mSm->unregisterForNotifications(mInterfaceName, mInstanceName, this)
647 .withDefault(false)) {
648 LOG(ERROR) << "Could not unregister service notification for " << mInterfaceName
649 << "/" << mInstanceName << ".";
650 } else {
651 mRegisteredForNotifications = false;
652 }
653 }
654 mDoneCalled = true;
655 }
656
657 private:
Martijn Coenen773609e2017-10-24 09:57:53 +0200658 const std::string mInterfaceName;
659 const std::string mInstanceName;
Steven Morelandad1f9922018-10-02 19:37:05 -0700660 sp<IServiceManager1_1> mSm;
Steven Morelandcbefd352017-01-23 20:29:05 -0800661 std::mutex mMutex;
662 std::condition_variable mCondition;
663 bool mRegistered = false;
Martijn Coenen773609e2017-10-24 09:57:53 +0200664 bool mRegisteredForNotifications = false;
Martijn Coenen3fa15c22018-02-10 11:30:00 +0100665 bool mDoneCalled = false;
Steven Morelandcbefd352017-01-23 20:29:05 -0800666};
667
668void waitForHwService(
669 const std::string &interface, const std::string &instanceName) {
Martijn Coenen773609e2017-10-24 09:57:53 +0200670 sp<Waiter> waiter = new Waiter(interface, instanceName, defaultServiceManager1_1());
Steven Moreland0771d8a2018-05-09 13:29:14 -0700671 waiter->wait(false /* timeout */);
Martijn Coenen3fa15c22018-02-10 11:30:00 +0100672 waiter->done();
Martijn Coenen773609e2017-10-24 09:57:53 +0200673}
Steven Morelandcbefd352017-01-23 20:29:05 -0800674
Martijn Coenen773609e2017-10-24 09:57:53 +0200675// Prints relevant error/warning messages for error return values from
676// details::canCastInterface(), both transaction errors (!castReturn.isOk())
677// as well as actual cast failures (castReturn.isOk() && castReturn = false).
678// Returns 'true' if the error is non-fatal and it's useful to retry
679bool handleCastError(const Return<bool>& castReturn, const std::string& descriptor,
680 const std::string& instance) {
681 if (castReturn.isOk()) {
682 if (castReturn) {
683 details::logAlwaysFatal("Successful cast value passed into handleCastError.");
684 }
685 // This should never happen, and there's not really a point in retrying.
686 ALOGE("getService: received incompatible service (bug in hwservicemanager?) for "
687 "%s/%s.", descriptor.c_str(), instance.c_str());
688 return false;
Steven Morelandcbefd352017-01-23 20:29:05 -0800689 }
Martijn Coenen773609e2017-10-24 09:57:53 +0200690 if (castReturn.isDeadObject()) {
691 ALOGW("getService: found dead hwbinder service for %s/%s.", descriptor.c_str(),
692 instance.c_str());
693 return true;
Steven Morelandcbefd352017-01-23 20:29:05 -0800694 }
Martijn Coenen773609e2017-10-24 09:57:53 +0200695 // This can happen due to:
696 // 1) No SELinux permissions
697 // 2) Other transaction failure (no buffer space, kernel error)
698 // The first isn't recoverable, but the second is.
699 // Since we can't yet differentiate between the two, and clients depend
700 // on us not blocking in case 1), treat this as a fatal error for now.
701 ALOGW("getService: unable to call into hwbinder service for %s/%s.",
702 descriptor.c_str(), instance.c_str());
703 return false;
Steven Morelandcbefd352017-01-23 20:29:05 -0800704}
705
Steven Moreland84fe49e2019-08-20 17:47:26 +0000706#ifdef ENFORCE_VINTF_MANIFEST
707static constexpr bool kEnforceVintfManifest = true;
708#else
709static constexpr bool kEnforceVintfManifest = false;
710#endif
711
712#ifdef LIBHIDL_TARGET_DEBUGGABLE
713static constexpr bool kDebuggable = true;
714#else
715static constexpr bool kDebuggable = false;
716#endif
717
718static inline bool isTrebleTestingOverride() {
719 if (kEnforceVintfManifest && !kDebuggable) {
720 // don't allow testing override in production
721 return false;
722 }
723
724 const char* env = std::getenv("TREBLE_TESTING_OVERRIDE");
725 return env && !strcmp(env, "true");
726}
727
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200728sp<::android::hidl::base::V1_0::IBase> getRawServiceInternal(const std::string& descriptor,
729 const std::string& instance,
730 bool retry, bool getStub) {
Steven Moreland84fe49e2019-08-20 17:47:26 +0000731 using Transport = IServiceManager1_0::Transport;
Martijn Coenend35678f2018-03-07 09:51:01 +0100732 sp<Waiter> waiter;
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200733
Yifan Hongdeacf142018-07-10 17:33:34 -0700734 sp<IServiceManager1_1> sm;
735 Transport transport = Transport::EMPTY;
736 if (kIsRecovery) {
Yifan Hongdeacf142018-07-10 17:33:34 -0700737 transport = Transport::PASSTHROUGH;
Yifan Hongdeacf142018-07-10 17:33:34 -0700738 } else {
739 sm = defaultServiceManager1_1();
740 if (sm == nullptr) {
741 ALOGE("getService: defaultServiceManager() is null");
742 return nullptr;
743 }
744
745 Return<Transport> transportRet = sm->getTransport(descriptor, instance);
746
747 if (!transportRet.isOk()) {
748 ALOGE("getService: defaultServiceManager()->getTransport returns %s",
749 transportRet.description().c_str());
750 return nullptr;
751 }
752 transport = transportRet;
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200753 }
754
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200755 const bool vintfHwbinder = (transport == Transport::HWBINDER);
756 const bool vintfPassthru = (transport == Transport::PASSTHROUGH);
Steven Moreland84fe49e2019-08-20 17:47:26 +0000757 const bool trebleTestingOverride = isTrebleTestingOverride();
758 const bool allowLegacy = !kEnforceVintfManifest || (trebleTestingOverride && kDebuggable);
759 const bool vintfLegacy = (transport == Transport::EMPTY) && allowLegacy;
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200760
Steven Moreland84fe49e2019-08-20 17:47:26 +0000761 if (!kEnforceVintfManifest) {
762 ALOGE("getService: Potential race detected. The VINTF manifest is not being enforced. If "
763 "a HAL server has a delay in starting and it is not in the manifest, it will not be "
764 "retrieved. Please make sure all HALs on this device are in the VINTF manifest and "
765 "enable PRODUCT_ENFORCE_VINTF_MANIFEST on this device (this is also enabled by "
766 "PRODUCT_FULL_TREBLE). PRODUCT_ENFORCE_VINTF_MANIFEST will ensure that no race "
767 "condition is possible here.");
Steven Morelandaadec3c2019-08-22 17:06:48 -0700768 sleep(1);
Steven Moreland84fe49e2019-08-20 17:47:26 +0000769 }
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200770
Steven Moreland76371242018-04-19 17:11:39 -0700771 for (int tries = 0; !getStub && (vintfHwbinder || vintfLegacy); tries++) {
772 if (waiter == nullptr && tries > 0) {
Martijn Coenend35678f2018-03-07 09:51:01 +0100773 waiter = new Waiter(descriptor, instance, sm);
774 }
Steven Moreland76371242018-04-19 17:11:39 -0700775 if (waiter != nullptr) {
776 waiter->reset(); // don't reorder this -- see comments on reset()
777 }
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200778 Return<sp<IBase>> ret = sm->get(descriptor, instance);
779 if (!ret.isOk()) {
780 ALOGE("getService: defaultServiceManager()->get returns %s for %s/%s.",
781 ret.description().c_str(), descriptor.c_str(), instance.c_str());
782 break;
783 }
784 sp<IBase> base = ret;
Martijn Coenen773609e2017-10-24 09:57:53 +0200785 if (base != nullptr) {
786 Return<bool> canCastRet =
787 details::canCastInterface(base.get(), descriptor.c_str(), true /* emitError */);
788
789 if (canCastRet.isOk() && canCastRet) {
Steven Moreland76371242018-04-19 17:11:39 -0700790 if (waiter != nullptr) {
791 waiter->done();
792 }
Martijn Coenen773609e2017-10-24 09:57:53 +0200793 return base; // still needs to be wrapped by Bp class.
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200794 }
Martijn Coenen773609e2017-10-24 09:57:53 +0200795
796 if (!handleCastError(canCastRet, descriptor, instance)) break;
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200797 }
798
Martijn Coenen773609e2017-10-24 09:57:53 +0200799 // In case of legacy or we were not asked to retry, don't.
800 if (vintfLegacy || !retry) break;
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200801
Steven Moreland76371242018-04-19 17:11:39 -0700802 if (waiter != nullptr) {
803 ALOGI("getService: Trying again for %s/%s...", descriptor.c_str(), instance.c_str());
Steven Moreland0771d8a2018-05-09 13:29:14 -0700804 waiter->wait(true /* timeout */);
Steven Moreland76371242018-04-19 17:11:39 -0700805 }
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200806 }
807
Martijn Coenend35678f2018-03-07 09:51:01 +0100808 if (waiter != nullptr) {
809 waiter->done();
810 }
Martijn Coenen3fa15c22018-02-10 11:30:00 +0100811
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200812 if (getStub || vintfPassthru || vintfLegacy) {
Steven Moreland84fe49e2019-08-20 17:47:26 +0000813 const sp<IServiceManager1_0> pm = getPassthroughServiceManager();
Martijn Coenen86c3abb2017-10-24 09:33:28 +0200814 if (pm != nullptr) {
815 sp<IBase> base = pm->get(descriptor, instance).withDefault(nullptr);
816 if (!getStub || trebleTestingOverride) {
817 base = wrapPassthrough(base);
818 }
819 return base;
820 }
821 }
822
823 return nullptr;
824}
825
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700826status_t registerAsServiceInternal(const sp<IBase>& service, const std::string& name) {
827 if (service == nullptr) {
828 return UNEXPECTED_NULL;
829 }
830
831 sp<IServiceManager1_2> sm = defaultServiceManager1_2();
832 if (sm == nullptr) {
833 return INVALID_OPERATION;
834 }
835
Steven Moreland84fe49e2019-08-20 17:47:26 +0000836 const std::string descriptor = getDescriptor(service.get());
837
838 if (kEnforceVintfManifest && !isTrebleTestingOverride()) {
839 using Transport = IServiceManager1_0::Transport;
840 Transport transport = sm->getTransport(descriptor, name);
841
842 if (transport != Transport::HWBINDER) {
843 LOG(ERROR) << "Service " << descriptor << "/" << name
844 << " must be in VINTF manifest in order to register/get.";
845 return UNKNOWN_ERROR;
846 }
847 }
848
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700849 bool registered = false;
850 Return<void> ret = service->interfaceChain([&](const auto& chain) {
851 registered = sm->addWithChain(name.c_str(), service, chain).withDefault(false);
852 });
853
854 if (!ret.isOk()) {
855 LOG(ERROR) << "Could not retrieve interface chain: " << ret.description();
856 }
857
858 if (registered) {
Steven Moreland84fe49e2019-08-20 17:47:26 +0000859 onRegistrationImpl(descriptor, name);
Steven Morelandbb9eb2a2018-10-11 12:10:01 -0700860 }
861
862 return registered ? OK : UNKNOWN_ERROR;
863}
864
Bernhard Rosenkränzer0c28fd22018-06-04 16:01:47 +0200865} // namespace details
Steven Morelandcbefd352017-01-23 20:29:05 -0800866
Bernhard Rosenkränzer0c28fd22018-06-04 16:01:47 +0200867} // namespace hardware
868} // namespace android