Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / libhwbinder / 02b3c178bb32e87fddb144565c6fbb0f6e3fabec
commit02b3c178bb32e87fddb144565c6fbb0f6e3fabec[log] [tgz]
authorChristopher Wiley <wiley@google.com>Tue Nov 10 09:44:30 2015 -0800
committerAlex Deymo <deymo@google.com>Tue Nov 17 17:49:27 2015 -0800
tree229cac0b941e26e039f31d50ba22124bc12fce93
parent278e7ee2b4812d75bcbadaddfe8bbc6a727f68b4 [diff]
libbinder: Return UNEXPECTED_NULL when appropriate

Return a meaningful and consistent error code when libbinder encounters
a null reference that it didn't expect.  This allows us to detect these
situations and cause a corresponding NullPointerException to be thrown
on the remote callsite.

While here, consolidate places we read vector<T> from a parcel into a
single templated version.  This dramatically reduces code duplication.

Bug: 25617251
Test: Integration tests asserting that vectors serialize correctly
      passes.  Integration test asserting that we throw
      NullPointerException on seeing a null reference also passes.

(cherry picked from commit 4db672ddccb02b2bd70ddb4812c00a5060174c93)

Change-Id: Icdb0b29aaff93e85884314c0304cd786e7b4e34f
1 file changed
tree: 229cac0b941e26e039f31d50ba22124bc12fce93
  1. include/
  2. tests/
  3. Android.mk
  4. AppOpsManager.cpp
  5. Binder.cpp
  6. BpBinder.cpp
  7. BufferedTextOutput.cpp
  8. Debug.cpp
  9. IAppOpsCallback.cpp
  10. IAppOpsService.cpp
  11. IBatteryStats.cpp
  12. IInterface.cpp
  13. IMemory.cpp
  14. IPCThreadState.cpp
  15. IPermissionController.cpp
  16. IProcessInfoService.cpp
  17. IServiceManager.cpp
  18. MemoryBase.cpp
  19. MemoryDealer.cpp
  20. MemoryHeapBase.cpp
  21. Parcel.cpp
  22. PermissionCache.cpp
  23. ProcessInfoService.cpp
  24. ProcessState.cpp
  25. Static.cpp
  26. TextOutput.cpp