Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / libhwbinder / 78183cc65c3a7bd267c570b371ee5ce3f4b5d63d
commit78183cc65c3a7bd267c570b371ee5ce3f4b5d63d[log] [tgz]
authorChristopher Tate <ctate@google.com>Wed Jun 03 18:44:15 2015 -0700
committerChristopher Tate <ctate@google.com>Mon Jun 08 13:13:19 2015 -0700
tree5536a112efc28f83ff3b456fb62ad756f8e75f7a
parenta091b548b33ffd5189e6759550f148d7fdd205b3 [diff]
Don't corrupt parcel when writeFileDescriptor() fails

We now check for fd-legality before committing binder objects to
the flattened data buffer rather than after.  Previously we would
wind up corrupting the parcel and incurring driver-level errors,
as well as potentially leaking FDs.

Bug 21428802

Change-Id: Ice0d641b3dcc41fb1b8c68ce2e2ebd744c2863a1
1 file changed
tree: 5536a112efc28f83ff3b456fb62ad756f8e75f7a
  1. include/
  2. tests/
  3. Android.mk
  4. AppOpsManager.cpp
  5. Binder.cpp
  6. BpBinder.cpp
  7. BufferedTextOutput.cpp
  8. Debug.cpp
  9. IAppOpsCallback.cpp
  10. IAppOpsService.cpp
  11. IBatteryStats.cpp
  12. IInterface.cpp
  13. IMemory.cpp
  14. IPCThreadState.cpp
  15. IPermissionController.cpp
  16. IProcessInfoService.cpp
  17. IServiceManager.cpp
  18. MemoryBase.cpp
  19. MemoryDealer.cpp
  20. MemoryHeapBase.cpp
  21. Parcel.cpp
  22. PermissionCache.cpp
  23. ProcessInfoService.cpp
  24. ProcessState.cpp
  25. Static.cpp
  26. TextOutput.cpp