check_vintf: also checks deprecation

Also fix suggestion for checkUnusedHals because there might be
deprecated HALs added.

Test: replace health 2.1 with 1.0 HAL and m check-vintf-all, see error
      about incompatibility, deprecated HALs and unused HALs.
Test: add health 1.0 HAL, see error about deprecated and unused HALs.
Test: replace vibrator AIDL HAL with 1.3 HIDL HAL, see error about
      deprecated and unused HALs.

Fixes: 153370708

Change-Id: I4d3209b0dcda708ff5f8ad809a10c7d703ee9936
(cherry picked from commit 5a220b158019d823b59ad6c00b07e5bdc5e25f61)
Merged-In: I4d3209b0dcda708ff5f8ad809a10c7d703ee9936
diff --git a/VintfObject.cpp b/VintfObject.cpp
index eca74d0..2c7c9fa 100644
--- a/VintfObject.cpp
+++ b/VintfObject.cpp
@@ -967,11 +967,12 @@
                << "not specified in framework compatibility matrix: \n"
                << "    " << android::base::Join(unused, "\n    ") << "\n"
                << "Suggested fix:\n"
-               << "1. Check for any typos in device manifest or framework compatibility "
+               << "1. Update deprecated HALs to the latest version.\n"
+               << "2. Check for any typos in device manifest or framework compatibility "
                << "matrices with FCM version >= " << matrix->level() << ".\n"
-               << "2. Add them to any framework compatibility matrix with FCM "
-               << "version >= " << matrix->level() << " where applicable.\n"
-               << "3. Add them to DEVICE_FRAMEWORK_COMPATIBILITY_MATRIX_FILE "
+               << "3. For new platform HALs, add them to any framework compatibility matrix "
+               << "with FCM version >= " << matrix->level() << " where applicable.\n"
+               << "4. For device-specific HALs, add to DEVICE_FRAMEWORK_COMPATIBILITY_MATRIX_FILE "
                << "or DEVICE_PRODUCT_COMPATIBILITY_MATRIX_FILE.";
     }
     return {};