Yifan Hong | 676447a | 2016-11-15 12:57:23 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2017 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "CompatibilityMatrix.h" |
| 18 | |
Yifan Hong | b6c7f49 | 2018-02-27 14:07:57 -0800 | [diff] [blame] | 19 | #include <iostream> |
Yifan Hong | dbe9db3 | 2017-12-11 19:06:11 -0800 | [diff] [blame] | 20 | #include <utility> |
| 21 | |
Yifan Hong | bbfff30 | 2017-06-06 17:10:13 -0700 | [diff] [blame] | 22 | #include "parse_string.h" |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 23 | #include "parse_xml.h" |
Yifan Hong | b6c7f49 | 2018-02-27 14:07:57 -0800 | [diff] [blame] | 24 | #include "utils.h" |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 25 | |
Yifan Hong | 676447a | 2016-11-15 12:57:23 -0800 | [diff] [blame] | 26 | namespace android { |
| 27 | namespace vintf { |
| 28 | |
Yifan Hong | 676447a | 2016-11-15 12:57:23 -0800 | [diff] [blame] | 29 | bool CompatibilityMatrix::add(MatrixHal &&hal) { |
Yifan Hong | 0fd7aef | 2017-05-24 14:37:19 -0700 | [diff] [blame] | 30 | return HalGroup<MatrixHal>::add(std::move(hal)); |
Yifan Hong | 676447a | 2016-11-15 12:57:23 -0800 | [diff] [blame] | 31 | } |
| 32 | |
| 33 | bool CompatibilityMatrix::add(MatrixKernel &&kernel) { |
Yifan Hong | 7c7d706 | 2017-04-04 16:26:51 -0700 | [diff] [blame] | 34 | if (mType != SchemaType::FRAMEWORK) { |
| 35 | return false; |
| 36 | } |
| 37 | framework.mKernels.push_back(std::move(kernel)); |
Yifan Hong | 676447a | 2016-11-15 12:57:23 -0800 | [diff] [blame] | 38 | return true; |
| 39 | } |
| 40 | |
Yifan Hong | 398f4c7 | 2017-04-13 20:18:01 -0700 | [diff] [blame] | 41 | SchemaType CompatibilityMatrix::type() const { |
| 42 | return mType; |
| 43 | } |
| 44 | |
Yifan Hong | 2027a49 | 2017-12-11 15:21:19 -0800 | [diff] [blame] | 45 | Level CompatibilityMatrix::level() const { |
| 46 | return mLevel; |
| 47 | } |
| 48 | |
Yifan Hong | db127cb | 2017-09-19 13:36:21 -0700 | [diff] [blame] | 49 | Version CompatibilityMatrix::getMinimumMetaVersion() const { |
| 50 | // TODO(b/62801658): this needs to depend on whether there are 1.1 requirements |
| 51 | // (e.g. required <xmlfile> entry) |
| 52 | return {1, 0}; |
| 53 | } |
Yifan Hong | 1e5a054 | 2017-04-28 14:37:56 -0700 | [diff] [blame] | 54 | |
Yifan Hong | 6021703 | 2018-01-08 16:19:42 -0800 | [diff] [blame] | 55 | status_t CompatibilityMatrix::fetchAllInformation(const std::string& path, std::string* error) { |
| 56 | return details::fetchAllInformation(path, gCompatibilityMatrixConverter, this, error); |
Yifan Hong | 1e5a054 | 2017-04-28 14:37:56 -0700 | [diff] [blame] | 57 | } |
| 58 | |
Yifan Hong | bbfff30 | 2017-06-06 17:10:13 -0700 | [diff] [blame] | 59 | std::string CompatibilityMatrix::getXmlSchemaPath(const std::string& xmlFileName, |
| 60 | const Version& version) const { |
| 61 | using std::literals::string_literals::operator""s; |
| 62 | auto range = getXmlFiles(xmlFileName); |
| 63 | for (auto it = range.first; it != range.second; ++it) { |
| 64 | const MatrixXmlFile& matrixXmlFile = it->second; |
| 65 | if (matrixXmlFile.versionRange().contains(version)) { |
| 66 | if (!matrixXmlFile.overriddenPath().empty()) { |
| 67 | return matrixXmlFile.overriddenPath(); |
| 68 | } |
| 69 | return "/"s + (type() == SchemaType::DEVICE ? "vendor" : "system") + "/etc/" + |
| 70 | xmlFileName + "_V" + std::to_string(matrixXmlFile.versionRange().majorVer) + |
| 71 | "_" + std::to_string(matrixXmlFile.versionRange().maxMinor) + "." + |
| 72 | to_string(matrixXmlFile.format()); |
| 73 | } |
| 74 | } |
| 75 | return ""; |
| 76 | } |
| 77 | |
Yifan Hong | e7e4553 | 2018-03-16 18:11:49 -0700 | [diff] [blame] | 78 | // Split existingHal into a HAL that contains only interface/instance and a HAL |
| 79 | // that does not contain it. Return the HAL that contains only interface/instance. |
| 80 | // - Return nullptr if existingHal does not contain interface/instance |
| 81 | // - Return existingHal if existingHal contains only interface/instance |
| 82 | // - Remove interface/instance from existingHal, and return a new MatrixHal (that is added |
| 83 | // to "this") that contains only interface/instance. |
| 84 | MatrixHal* CompatibilityMatrix::splitInstance(MatrixHal* existingHal, const std::string& interface, |
| 85 | const std::string& instance) { |
| 86 | if (!existingHal->hasInstance(interface, instance)) { |
| 87 | return nullptr; |
| 88 | } |
| 89 | |
| 90 | if (existingHal->hasOnlyInstance(interface, instance)) { |
| 91 | return existingHal; |
| 92 | } |
| 93 | |
| 94 | existingHal->removeInstance(interface, instance); |
| 95 | MatrixHal copy = *existingHal; |
| 96 | copy.clearInstances(); |
| 97 | copy.insertInstance(interface, instance); |
| 98 | |
| 99 | return addInternal(std::move(copy)); |
| 100 | } |
| 101 | |
Yifan Hong | 7967d7b | 2018-03-15 17:08:58 -0700 | [diff] [blame] | 102 | // Add all package@other_version::interface/instance as an optional instance. |
| 103 | // If package@this_version::interface/instance is in this (that is, some instance |
| 104 | // with the same package and interface and instance exists), then other_version is |
| 105 | // considered a possible replacement to this_version. |
| 106 | // See LibVintfTest.AddOptionalHal* tests for details. |
Yifan Hong | dbe9db3 | 2017-12-11 19:06:11 -0800 | [diff] [blame] | 107 | bool CompatibilityMatrix::addAllHalsAsOptional(CompatibilityMatrix* other, std::string* error) { |
| 108 | if (other == nullptr || other->level() <= level()) { |
| 109 | return true; |
| 110 | } |
| 111 | |
| 112 | for (auto& pair : other->mHals) { |
| 113 | const std::string& name = pair.first; |
| 114 | MatrixHal& halToAdd = pair.second; |
Yifan Hong | dbe9db3 | 2017-12-11 19:06:11 -0800 | [diff] [blame] | 115 | |
Yifan Hong | e7e4553 | 2018-03-16 18:11:49 -0700 | [diff] [blame] | 116 | std::set<std::pair<std::string, std::string>> insertedInstances; |
| 117 | auto existingHals = getHals(name); |
| 118 | |
| 119 | halToAdd.forEachInstance([&](const std::vector<VersionRange>& versionRanges, |
Yifan Hong | 7e9e04d | 2018-03-20 13:06:00 -0700 | [diff] [blame] | 120 | const std::string& interface, const std::string& instance, |
| 121 | bool /* isRegex */) { |
Yifan Hong | e7e4553 | 2018-03-16 18:11:49 -0700 | [diff] [blame] | 122 | for (auto* existingHal : existingHals) { |
| 123 | MatrixHal* splitInstance = this->splitInstance(existingHal, interface, instance); |
| 124 | if (splitInstance != nullptr) { |
| 125 | splitInstance->insertVersionRanges(versionRanges); |
| 126 | insertedInstances.insert(std::make_pair(interface, instance)); |
| 127 | } |
Yifan Hong | dbe9db3 | 2017-12-11 19:06:11 -0800 | [diff] [blame] | 128 | } |
Yifan Hong | e7e4553 | 2018-03-16 18:11:49 -0700 | [diff] [blame] | 129 | return true; |
| 130 | }); |
| 131 | |
| 132 | // Add the remaining instances. |
| 133 | for (const auto& pair : insertedInstances) { |
| 134 | halToAdd.removeInstance(pair.first, pair.second); |
Yifan Hong | 7967d7b | 2018-03-15 17:08:58 -0700 | [diff] [blame] | 135 | } |
Yifan Hong | dbe9db3 | 2017-12-11 19:06:11 -0800 | [diff] [blame] | 136 | |
Yifan Hong | 7e9e04d | 2018-03-20 13:06:00 -0700 | [diff] [blame] | 137 | if (halToAdd.instancesCount() > 0) { |
Yifan Hong | 7967d7b | 2018-03-15 17:08:58 -0700 | [diff] [blame] | 138 | halToAdd.setOptional(true); |
| 139 | if (!add(std::move(halToAdd))) { |
| 140 | if (error) { |
| 141 | *error = "Cannot add HAL " + name + " for unknown reason."; |
Yifan Hong | dbe9db3 | 2017-12-11 19:06:11 -0800 | [diff] [blame] | 142 | } |
| 143 | return false; |
| 144 | } |
Yifan Hong | dbe9db3 | 2017-12-11 19:06:11 -0800 | [diff] [blame] | 145 | } |
| 146 | } |
| 147 | return true; |
| 148 | } |
| 149 | |
Yifan Hong | d4b92fe | 2017-12-20 15:29:03 -0800 | [diff] [blame] | 150 | bool CompatibilityMatrix::addAllXmlFilesAsOptional(CompatibilityMatrix* other, std::string* error) { |
| 151 | if (other == nullptr || other->level() <= level()) { |
| 152 | return true; |
| 153 | } |
| 154 | for (auto& pair : other->mXmlFiles) { |
| 155 | const std::string& name = pair.first; |
| 156 | MatrixXmlFile& xmlFileToAdd = pair.second; |
| 157 | |
| 158 | xmlFileToAdd.mOptional = true; |
| 159 | if (!addXmlFile(std::move(xmlFileToAdd))) { |
| 160 | if (error) { |
| 161 | *error = "Cannot add XML File " + name + " for unknown reason."; |
| 162 | } |
| 163 | return false; |
| 164 | } |
| 165 | } |
| 166 | return true; |
| 167 | } |
| 168 | |
Yifan Hong | fb7469c | 2017-04-05 19:15:21 -0700 | [diff] [blame] | 169 | bool operator==(const CompatibilityMatrix &lft, const CompatibilityMatrix &rgt) { |
Yifan Hong | 2027a49 | 2017-12-11 15:21:19 -0800 | [diff] [blame] | 170 | return lft.mType == rgt.mType && lft.mLevel == rgt.mLevel && lft.mHals == rgt.mHals && |
| 171 | lft.mXmlFiles == rgt.mXmlFiles && |
Yifan Hong | feb454e | 2018-01-09 16:16:40 -0800 | [diff] [blame] | 172 | (lft.mType != SchemaType::DEVICE || |
| 173 | ( |
Yifan Hong | 0f529fa | 2018-01-10 14:51:59 -0800 | [diff] [blame] | 174 | #pragma clang diagnostic push |
| 175 | #pragma clang diagnostic ignored "-Wdeprecated-declarations" |
Yifan Hong | feb454e | 2018-01-09 16:16:40 -0800 | [diff] [blame] | 176 | lft.device.mVndk == rgt.device.mVndk && |
Yifan Hong | 0f529fa | 2018-01-10 14:51:59 -0800 | [diff] [blame] | 177 | #pragma clang diagnostic pop |
Yifan Hong | a28729e | 2018-01-17 13:40:35 -0800 | [diff] [blame] | 178 | lft.device.mVendorNdk == rgt.device.mVendorNdk && |
| 179 | lft.device.mSystemSdk == rgt.device.mSystemSdk)) && |
Yifan Hong | d485790 | 2017-06-13 14:13:56 -0700 | [diff] [blame] | 180 | (lft.mType != SchemaType::FRAMEWORK || |
| 181 | (lft.framework.mKernels == rgt.framework.mKernels && |
| 182 | lft.framework.mSepolicy == rgt.framework.mSepolicy && |
| 183 | lft.framework.mAvbMetaVersion == rgt.framework.mAvbMetaVersion)); |
Yifan Hong | fb7469c | 2017-04-05 19:15:21 -0700 | [diff] [blame] | 184 | } |
| 185 | |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 186 | // Find compatibility_matrix.empty.xml (which has unspecified level) and use it |
| 187 | // as a base matrix. |
| 188 | CompatibilityMatrix* CompatibilityMatrix::findOrInsertBaseMatrix( |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 189 | std::vector<Named<CompatibilityMatrix>>* matrices, std::string* error) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 190 | bool multipleFound = false; |
| 191 | CompatibilityMatrix* matrix = nullptr; |
| 192 | for (auto& e : *matrices) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 193 | if (e.object.level() == Level::UNSPECIFIED) { |
| 194 | if (!e.object.mHals.empty()) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 195 | if (error) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 196 | *error = "Error: File \"" + e.name + "\" should not contain " + "HAL elements."; |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 197 | } |
| 198 | return nullptr; |
| 199 | } |
| 200 | |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 201 | if (!e.object.mXmlFiles.empty()) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 202 | if (error) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 203 | *error = |
| 204 | "Error: File \"" + e.name + "\" should not contain " + "XML File elements."; |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 205 | } |
| 206 | return nullptr; |
| 207 | } |
| 208 | |
| 209 | if (matrix != nullptr) { |
| 210 | multipleFound = true; |
| 211 | } |
| 212 | |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 213 | matrix = &e.object; |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 214 | // continue to detect multiple files with "unspecified" levels |
| 215 | } |
| 216 | } |
| 217 | |
| 218 | if (multipleFound) { |
| 219 | if (error) { |
| 220 | *error = |
| 221 | "Error: multiple framework compatibility matrix files have " |
| 222 | "unspecified level; there should only be one such file.\n"; |
| 223 | for (auto& e : *matrices) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 224 | if (e.object.level() == Level::UNSPECIFIED) { |
| 225 | *error += " " + e.name + "\n"; |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 226 | } |
| 227 | } |
| 228 | } |
| 229 | return nullptr; |
| 230 | } |
| 231 | |
| 232 | if (matrix == nullptr) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 233 | matrix = &matrices->emplace(matrices->end())->object; |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 234 | matrix->mType = SchemaType::FRAMEWORK; |
| 235 | matrix->mLevel = Level::UNSPECIFIED; |
| 236 | } |
| 237 | |
| 238 | return matrix; |
| 239 | } |
| 240 | |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 241 | CompatibilityMatrix* CompatibilityMatrix::combine(Level deviceLevel, |
| 242 | std::vector<Named<CompatibilityMatrix>>* matrices, |
| 243 | std::string* error) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 244 | if (deviceLevel == Level::UNSPECIFIED) { |
| 245 | if (error) { |
| 246 | *error = "Error: device level is unspecified."; |
| 247 | } |
| 248 | return nullptr; |
| 249 | } |
| 250 | |
| 251 | CompatibilityMatrix* matrix = findOrInsertBaseMatrix(matrices, error); |
| 252 | if (matrix == nullptr) { |
| 253 | return nullptr; |
| 254 | } |
| 255 | |
| 256 | matrix->mLevel = deviceLevel; |
| 257 | |
| 258 | for (auto& e : *matrices) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 259 | if (&e.object != matrix && e.object.level() == deviceLevel) { |
| 260 | if (!matrix->addAllHals(&e.object, error)) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 261 | if (error) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 262 | *error = "File \"" + e.name + "\" cannot be added: HAL " + *error + |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 263 | " has a conflict."; |
| 264 | } |
| 265 | return nullptr; |
| 266 | } |
| 267 | |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 268 | if (!matrix->addAllXmlFiles(&e.object, error)) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 269 | if (error) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 270 | *error = "File \"" + e.name + "\" cannot be added: XML File entry " + *error + |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 271 | " has a conflict."; |
| 272 | } |
| 273 | return nullptr; |
| 274 | } |
| 275 | } |
| 276 | } |
| 277 | |
| 278 | for (auto& e : *matrices) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 279 | if (&e.object != matrix && e.object.level() != Level::UNSPECIFIED && |
| 280 | e.object.level() > deviceLevel) { |
| 281 | if (!matrix->addAllHalsAsOptional(&e.object, error)) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 282 | if (error) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 283 | *error = "File \"" + e.name + "\" cannot be added: " + *error + |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 284 | ". See <hal> with the same name " + |
| 285 | "in previously parsed files or previously declared in this file."; |
| 286 | } |
| 287 | return nullptr; |
| 288 | } |
| 289 | |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 290 | if (!matrix->addAllXmlFilesAsOptional(&e.object, error)) { |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 291 | if (error) { |
Yifan Hong | ffcaf99 | 2018-01-09 17:08:51 -0800 | [diff] [blame] | 292 | *error = "File \"" + e.name + "\" cannot be added: XML File entry " + *error + |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 293 | " has a conflict."; |
| 294 | } |
| 295 | return nullptr; |
| 296 | } |
| 297 | } |
| 298 | } |
| 299 | |
Yifan Hong | f7e8b1b | 2018-01-23 15:30:35 -0800 | [diff] [blame] | 300 | for (auto& e : *matrices) { |
| 301 | if (&e.object != matrix && e.object.level() == deviceLevel && |
| 302 | e.object.type() == SchemaType::FRAMEWORK) { |
| 303 | for (MatrixKernel& kernel : e.object.framework.mKernels) { |
| 304 | KernelVersion ver = kernel.minLts(); |
| 305 | if (!matrix->add(std::move(kernel))) { |
| 306 | if (error) { |
| 307 | *error = "Cannot add kernel version " + to_string(ver) + |
| 308 | " from FCM version " + to_string(deviceLevel); |
| 309 | } |
| 310 | return nullptr; |
| 311 | } |
| 312 | } |
| 313 | } |
| 314 | } |
| 315 | |
Yifan Hong | ddae77e | 2017-12-18 16:57:07 -0800 | [diff] [blame] | 316 | return matrix; |
| 317 | } |
| 318 | |
Yifan Hong | 2a90ffe | 2018-03-05 17:45:34 -0800 | [diff] [blame] | 319 | bool CompatibilityMatrix::forEachInstanceOfVersion( |
| 320 | const std::string& package, const Version& expectVersion, |
| 321 | const std::function<bool(const MatrixInstance&)>& func) const { |
| 322 | for (const MatrixHal* hal : getHals(package)) { |
| 323 | bool cont = hal->forEachInstance([&](const MatrixInstance& matrixInstance) { |
| 324 | if (matrixInstance.versionRange().contains(expectVersion)) { |
| 325 | return func(matrixInstance); |
Yifan Hong | e3a9234 | 2018-01-25 17:00:16 -0800 | [diff] [blame] | 326 | } |
Yifan Hong | 2a90ffe | 2018-03-05 17:45:34 -0800 | [diff] [blame] | 327 | return true; |
| 328 | }); |
| 329 | if (!cont) return false; |
Yifan Hong | e3a9234 | 2018-01-25 17:00:16 -0800 | [diff] [blame] | 330 | } |
Yifan Hong | 2a90ffe | 2018-03-05 17:45:34 -0800 | [diff] [blame] | 331 | return true; |
Yifan Hong | e3a9234 | 2018-01-25 17:00:16 -0800 | [diff] [blame] | 332 | } |
| 333 | |
Yifan Hong | def7e7f | 2018-03-20 13:27:36 -0700 | [diff] [blame^] | 334 | bool CompatibilityMatrix::matchInstance(const std::string& halName, const Version& version, |
| 335 | const std::string& interfaceName, |
| 336 | const std::string& instance) const { |
| 337 | bool found = false; |
| 338 | (void)forEachInstanceOfInterface(halName, version, interfaceName, |
| 339 | [&found, &instance](const auto& e) { |
| 340 | found |= (e.matchInstance(instance)); |
| 341 | return !found; // if not found, continue |
| 342 | }); |
| 343 | return found; |
| 344 | } |
| 345 | |
Yifan Hong | 676447a | 2016-11-15 12:57:23 -0800 | [diff] [blame] | 346 | } // namespace vintf |
| 347 | } // namespace android |