commit c6ddd030b5c92097bc48f0ebae91b54fbfc4922b
author Andy Hung <hunga@google.com> Wed Apr 25 17:59:24 2018 -0700
committer Andy Hung <hunga@google.com> Thu Apr 26 15:24:16 2018 -0700
tree 7100873ff5c7975d4c903366919b626d6761b517
parent c5e409aa6b5083b6a7a431ac920455ca41ed0db7

Fix in-place audio format conversion issues

memcpy_by_audio_format() corner case of same format in-place.
memcpy_to_p24_from_i16() for the first sample in buffer for in-place.

Update memcpy_by_audio_format() documentation.

Test: added native unit test format_tests
Bug: 78598192
Change-Id: I9e538ed4ef233b319b846f4a91c27a86eb605a20

audio_utils/format.c

diff --git a/audio_utils/format.c b/audio_utils/format.c
index 1803e3c..50872fc 100644
--- a/audio_utils/format.c
+++ b/audio_utils/format.c
@@ -34,7 +34,10 @@
         case AUDIO_FORMAT_PCM_24_BIT_PACKED:
         case AUDIO_FORMAT_PCM_32_BIT:
         case AUDIO_FORMAT_PCM_8_24_BIT:
-            memcpy(dst, src, count * audio_bytes_per_sample(dst_format));
+            if (dst != src) {
+                // TODO: should assert if memory regions overlap.
+                memcpy(dst, src, count * audio_bytes_per_sample(dst_format));
+            }
             return;
         default:
             break;