commit 032b5db23f350e6723ea1902c50090905ad0738b
author Maciej Żenczykowski <maze@google.com> Wed Apr 22 09:43:40 2020 +0000
committer Maciej Zenczykowski <maze@google.com> Wed Apr 22 13:44:03 2020 +0000
tree b91f0773e09a994478b94746a7e6f140c485ff5a
parent ece434ac8bd1cde30c6d98e100940b27693c5bcb

NdcDispatcher - fix bugprone-suspicous-string-compare warnings

Fixes:
  system/netd/server/NdcDispatcher.cpp:989:20: warning: function strcmp is called without explicitly comparing result [bugprone-suspicious-string-compare]
  system/netd/server/NdcDispatcher.cpp:1109:20: ...
  system/netd/server/NdcDispatcher.cpp:1136:20: ...

Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I48056fa81af823f14d2f41885bd1a824e1d5ddd2
Merged-In: I48056fa81af823f14d2f41885bd1a824e1d5ddd2

server/NdcDispatcher.cpp

diff --git a/server/NdcDispatcher.cpp b/server/NdcDispatcher.cpp
index d2f790c..67abed2 100644
--- a/server/NdcDispatcher.cpp
+++ b/server/NdcDispatcher.cpp
@@ -986,7 +986,7 @@
         bool add = false;
         if (!strcmp(argv[nextArg], "add")) {
             add = true;
-        } else if (strcmp(argv[nextArg], "remove")) {
+        } else if (strcmp(argv[nextArg], "remove") != 0) {
             return syntaxError(cli, "Unknown argument");
         }
         ++nextArg;
@@ -1106,7 +1106,7 @@
                 return syntaxError(cli, "Missing netId");
             }
             netId = stringToNetId(argv[3]);
-        } else if (strcmp(argv[2], "clear")) {
+        } else if (strcmp(argv[2], "clear") != 0) {
             return syntaxError(cli, "Unknown argument");
         }
         if (Status status = mNetd->networkSetDefault(netId); !status.isOk()) {
@@ -1133,7 +1133,7 @@
                 return syntaxError(cli, "Unknown permission");
             }
             nextArg = 5;
-        } else if (strcmp(argv[3], "clear")) {
+        } else if (strcmp(argv[3], "clear") != 0) {
             return syntaxError(cli, "Unknown argument");
         }
         if (nextArg == argc) {