Add TetherConfigParcel to improve tetherStartWithConfiguration
tetherStartWithConfiguration doesn't take a configuration, it
takes a boolean. But for extensibility purposes, it should
take some sort of configuration parcel. This is because in
AIDL, once we add a method we cannot ever change its signature
or add parameters, because there cannot be two methods with the
same name. Create a new parcel to improve this.
Bug: 145777247
Test: atest FrameworksNetTests
Test: atest netd_integration_test:BinderTest#TetherStartStopStatus
Test: build, flash, on/off tethering
Change-Id: I0d34a25fc9a187e218d37a058b8316ea2423a5da
diff --git a/tests/binder_test.cpp b/tests/binder_test.cpp
index 7d3d296..e02c7f0 100644
--- a/tests/binder_test.cpp
+++ b/tests/binder_test.cpp
@@ -2013,8 +2013,10 @@
static const char dnsdName[] = "dnsmasq";
for (bool usingLegacyDnsProxy : {true, false}) {
- binder::Status status =
- mNetd->tetherStartWithConfiguration(usingLegacyDnsProxy, noDhcpRange);
+ android::net::TetherConfigParcel config;
+ config.usingLegacyDnsProxy = usingLegacyDnsProxy;
+ config.dhcpRanges = noDhcpRange;
+ binder::Status status = mNetd->tetherStartWithConfiguration(config);
EXPECT_TRUE(status.isOk()) << status.exceptionMessage();
SCOPED_TRACE(StringPrintf("usingLegacyDnsProxy: %d", usingLegacyDnsProxy));
if (usingLegacyDnsProxy == true) {