commit 31ab88730cd4cadba0fb146ee72387b46964740d
author Erik Kline <ek@google.com> Fri May 25 15:35:03 2018 +0900
committer Erik Kline <ek@google.com> Mon May 28 16:55:48 2018 +0900
tree 41e50d4ff7a8eea52f8aba2ebf9527d9a62f71f8
parent 609853a978fc35bacb14b6780025cdf1b6b51dd8

Remove unnecessary imports in DumpWriter

Test: as follows
    - built, flashed, booted
    - adb shell dumpsys netd still produces expected output

Change-Id: I0b6485e302864e952ca47376116ad31ef727c946

server/DumpWriter.cpp

diff --git a/server/DumpWriter.cpp b/server/DumpWriter.cpp
index 9a7e352..44e5e9e 100644
--- a/server/DumpWriter.cpp
+++ b/server/DumpWriter.cpp
@@ -16,12 +16,13 @@
 
 #include "DumpWriter.h"
 
+#include <unistd.h>
+#include <limits>
+
 #include <android-base/stringprintf.h>
 #include <utils/String8.h>
 
 using android::base::StringAppendV;
-using android::String16;
-using android::Vector;
 
 namespace android {
 namespace net {
@@ -37,13 +38,13 @@
 DumpWriter::DumpWriter(int fd) : mIndentLevel(0), mFd(fd) {}
 
 void DumpWriter::incIndent() {
-    if (mIndentLevel < 255) {
+    if (mIndentLevel < std::numeric_limits<decltype(mIndentLevel)>::max()) {
         mIndentLevel++;
     }
 }
 
 void DumpWriter::decIndent() {
-    if (mIndentLevel > 0) {
+    if (mIndentLevel > std::numeric_limits<decltype(mIndentLevel)>::min()) {
         mIndentLevel--;
     }
 }
@@ -51,11 +52,11 @@
 void DumpWriter::println(const std::string& line) {
     if (!line.empty()) {
         for (int i = 0; i < mIndentLevel; i++) {
-            write(mFd, kIndentString, kIndentStringLen);
+            ::write(mFd, kIndentString, kIndentStringLen);
         }
-        write(mFd, line.c_str(), line.size());
+        ::write(mFd, line.c_str(), line.size());
     }
-    write(mFd, "\n", 1);
+    ::write(mFd, "\n", 1);
 }
 
 void DumpWriter::println(const char* fmt, ...) {