Don't cast to unsigned before PERMISSION_UNINSTALLED (-1) is checked
... otherwise the check is no-op.
Found by Clang tautological-constant-out-of-range-compare warning.
Test: presubmit
Bug: 72331526
Change-Id: Ib1abfe74198440b5b60c8c3a3cbf46bca2f5b12c
diff --git a/server/TrafficController.cpp b/server/TrafficController.cpp
index d39ceaf..4c55492 100644
--- a/server/TrafficController.cpp
+++ b/server/TrafficController.cpp
@@ -115,7 +115,7 @@
mPrivilegedUser.find(appId) != mPrivilegedUser.end());
}
-const std::string UidPermissionTypeToString(uint8_t permission) {
+const std::string UidPermissionTypeToString(int permission) {
if (permission == INetd::PERMISSION_NONE) {
return "PERMISSION_NONE";
}
@@ -1121,7 +1121,7 @@
dw.println("mUidOwnerMap print end with error: %s", res.msg().c_str());
}
dumpBpfMap("mUidPermissionMap", dw, "");
- const auto printUidPermissionInfo = [&dw](const uint32_t& key, const uint8_t& value,
+ const auto printUidPermissionInfo = [&dw](const uint32_t& key, const int& value,
const BpfMap<uint32_t, uint8_t>&) {
dw.println("%u %s", key, UidPermissionTypeToString(value).c_str());
return netdutils::status::ok;