Fix memory leak in resolver cache
Memory leaks in resolver cache when network is being destroyed.
We clear DNS servers before deleting the cache to make sure the
cache will not be created again.
Bug: 122940321
Test: built, flashed, booted
system/netd/tests/runtests.sh passed
Change-Id: I6aacc13ade3ce020b906f8a8a0f870f0741a5a47
diff --git a/server/NetdNativeService.cpp b/server/NetdNativeService.cpp
index ce2dd23..2098ad5 100644
--- a/server/NetdNativeService.cpp
+++ b/server/NetdNativeService.cpp
@@ -372,8 +372,9 @@
binder::Status NetdNativeService::networkDestroy(int32_t netId) {
ENFORCE_PERMISSION(NETWORK_STACK);
// Both of these functions manage their own locking internally.
- const int ret = gCtls->netCtrl.destroyNetwork(netId);
+ // Clear DNS servers before delete the cache to avoid the cache being created again.
gCtls->resolverCtrl.clearDnsServers(netId);
+ const int ret = gCtls->netCtrl.destroyNetwork(netId);
return statusFromErrcode(ret);
}