commit 7e25ec006e6b43b3ca33922094cf088aa572d305
author Bernie Innocenti <codewiz@google.com> Mon Jul 02 19:32:17 2018 +0900
committer Bernie Innocenti <codewiz@google.com> Mon Jul 02 19:33:39 2018 +0900
tree 826a3049b4385a6325ec550a75119b3f09389fe2
parent 453914f871e7c9fa4130a46a03e7defaf1bd7718

Fix linter warnings in netd tests

Test: tests/runtests.sh
Change-Id: Id06480fa3c1fc04f5669c42b87b263b46bf614fd

server/TrafficControllerTest.cpp

diff --git a/server/TrafficControllerTest.cpp b/server/TrafficControllerTest.cpp
index c7b6f48..6a5f2bc 100644
--- a/server/TrafficControllerTest.cpp
+++ b/server/TrafficControllerTest.cpp
@@ -40,7 +40,7 @@
 #include "TrafficController.h"
 #include "bpf/BpfUtils.h"
 
-using namespace android::bpf;
+using namespace android::bpf;  // NOLINT(google-build-using-namespace): grandfathered
 
 using ::testing::_;
 using ::testing::ByMove;
@@ -228,7 +228,7 @@
 
     void expectBandwidthMapValues(const std::vector<std::string>& appStrUids,
                                   uint8_t expectedValue) {
-        for (std::string strUid : appStrUids) {
+        for (const std::string& strUid : appStrUids) {
             uint32_t uid = stoi(strUid);
             StatusOr<uint8_t> value = mFakeBandwidthUidMap.readValue(uid);
             EXPECT_TRUE(isOk(value));