Remove wrong and unnecessary check for setDnsForwarders
inet_pton could not parse link local address with zone id.
Additionally, setDnsForwarders has already used getaddrinfo for address parsing.
Bug: 129474773
Test: built, flashed, booted
system/netd/tests/runtests.sh passes
Change-Id: Iea8ccd234e81ff6ddd863d920033559d436bf0d0
diff --git a/server/TetherController.cpp b/server/TetherController.cpp
index 6ce617d..c684a1a 100644
--- a/server/TetherController.cpp
+++ b/server/TetherController.cpp
@@ -347,7 +347,7 @@
// dnsmasq reads up to 1023 bytes.
const size_t MAX_CMD_SIZE = 1023;
-// TODO: convert callers to the overload taking a vector<string>
+// TODO: Remove overload function and update this after NDC migration.
int TetherController::setDnsForwarders(unsigned netId, char **servers, int numServers) {
Fwmark fwmark;
fwmark.netId = netId;
@@ -394,14 +394,6 @@
}
int TetherController::setDnsForwarders(unsigned netId, const std::vector<std::string>& servers) {
- struct in_addr v4_addr;
- struct in6_addr v6_addr;
- for (const auto& server : servers) {
- if (!inet_pton(AF_INET, server.c_str(), &v4_addr) &&
- !inet_pton(AF_INET6, server.c_str(), &v6_addr)) {
- return -EINVAL;
- }
- }
auto dnsServers = toCstrVec(servers);
return setDnsForwarders(netId, dnsServers.data(), dnsServers.size());
}