commit a803670da621a8ed2e2bc551c819c7352845c415
author Maciej Żenczykowski <maze@google.com> Fri May 01 01:30:12 2020 +0000
committer Maciej Zenczykowski <maze@google.com> Fri May 01 01:39:44 2020 +0000
tree 279944c8db842183add495d5c784069e82bc5d51
parent 59f1893258ef13927bcfaf8cd06dfdecd37647a3

TrafficController - comment out some dead code (clang-analyzer-deadcode.DeadStores)

Fixes:
  system/netd/server/TrafficController.cpp:
  713:9: error: Value stored to 'type' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
        type = WHITELIST;
        ^
  713:9: note: Value stored to 'type' is never read
  714:9: error: Value stored to 'rule' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
        rule = ALLOW;
        ^
  714:9: note: Value stored to 'rule' is never read
  system/netd/server/TrafficController.cpp:
  716:9: error: Value stored to 'type' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
        type = BLACKLIST;
        ^
  716:9: note: Value stored to 'type' is never read
  717:9: error: Value stored to 'rule' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
        rule = DENY;
        ^
  717:9: note: Value stored to 'rule' is never read

Test: builds
Bug: 155351989
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I070cd1ac4e205008b09c9ad919aea82784da4e01
Merged-In: I070cd1ac4e205008b09c9ad919aea82784da4e01

server/TrafficController.cpp

diff --git a/server/TrafficController.cpp b/server/TrafficController.cpp
index e2b88a6..9d7d6a1 100644
--- a/server/TrafficController.cpp
+++ b/server/TrafficController.cpp
@@ -705,17 +705,10 @@
     return netdutils::status::ok;
 }
 
-int TrafficController::replaceUidOwnerMap(const std::string& name, bool isWhitelist,
+int TrafficController::replaceUidOwnerMap(const std::string& name, bool isWhitelist __unused,
                                           const std::vector<int32_t>& uids) {
-    FirewallRule rule;
-    FirewallType type;
-    if (isWhitelist) {
-        type = WHITELIST;
-        rule = ALLOW;
-    } else {
-        type = BLACKLIST;
-        rule = DENY;
-    }
+    // FirewallRule rule = isWhitelist ? ALLOW : DENY;
+    // FirewallType type = isWhitelist ? WHITELIST : BLACKLIST;
     Status res;
     if (!name.compare(FirewallController::LOCAL_DOZABLE)) {
         res = replaceRulesInMap(DOZABLE_MATCH, uids);