commit b22e4d24b7f5468d7596dea66010ec159a8be6b1
author Chih-Hung Hsieh <chh@google.com> Thu Jul 28 14:13:11 2016 -0700
committer Chih-Hung Hsieh <chh@google.com> Thu Jul 28 14:13:11 2016 -0700
tree 6663aceb79d1f63ecadbc2e2126c253fdcfd691f
parent 451debdc6bff2ffda2f4c85f7de244d52b05c806

Fix clang-tidy performance warnings in SockDiag.

* Use const reference type for parameters to avoid unnecessary copy.

Bug: 30407689
Change-Id: I77d26f64b86aa03cf877b2d4475bbe1348400316
Test: build with WITH_TIDY=1

server/SockDiag.h

diff --git a/server/SockDiag.h b/server/SockDiag.h
index 56acbdb..ccd54bf 100644
--- a/server/SockDiag.h
+++ b/server/SockDiag.h
@@ -23,7 +23,7 @@
     virtual ~SockDiag() { closeSocks(); }
 
     int sendDumpRequest(uint8_t proto, uint8_t family, const char *addrstr);
-    int readDiagMsg(uint8_t proto, DumpCallback callback);
+    int readDiagMsg(uint8_t proto, const DumpCallback& callback);
     int sockDestroy(uint8_t proto, const inet_diag_msg *);
     int destroySockets(const char *addrstr);