Use StartsWith for IpSec Iface Find
Address Code Review Comments on Change-Id:
Ibc66b014692a978ebfcc7856dcc26524618668a8
Use android::base::StartsWith() rather than
strcmp() for checking the prefix of a tunnel.
Bug: 74560705
Test: runtest -x netd_integration_test.cpp
Change-Id: I5c3b9067840cfea6273b3c83e2ff94e1f54d6c83
diff --git a/server/XfrmController.cpp b/server/XfrmController.cpp
index 5c51a36..2a2382f 100644
--- a/server/XfrmController.cpp
+++ b/server/XfrmController.cpp
@@ -390,7 +390,7 @@
for (const std::string& iface : ifaces.value()) {
int status = 0;
// Look for the reserved interface prefix, which must be in the name at position 0
- if (!iface.compare(0, ifPrefix8.length(), ifPrefix8.c_str()) &&
+ if (android::base::StartsWith(iface.c_str(), ifPrefix8.c_str()) &&
(status = removeVirtualTunnelInterface(iface)) < 0) {
ALOGE("Failed to delete ipsec tunnel %s.", iface.c_str());
return netdutils::statusFromErrno(status, "Failed to remove ipsec tunnel.");