commit b7ac3f7e3ed4569e15bb5a57d70458585eb9fe53
author Lorenzo Colitti <lorenzo@google.com> Thu Jul 06 16:52:52 2017 +0900
committer Lorenzo Colitti <lorenzo@google.com> Thu Jul 06 18:24:32 2017 +0900
tree 58fa3629956032738544fd73bedba2774f172609
parent 48f83006a0c5cf35d1f8d20fcd4213e4b325997e

Minor improvements to shared quota error handling.

Bug: 28362720
Test: bullhead builds,boots
Test: netd_{unit,integration}_test pass
Change-Id: Ib3de9f4f3317373619ba185a6e7860f0fc82ca7b

server/BandwidthController.cpp

diff --git a/server/BandwidthController.cpp b/server/BandwidthController.cpp
index 2468cd9..3d1a56c 100644
--- a/server/BandwidthController.cpp
+++ b/server/BandwidthController.cpp
@@ -421,28 +421,38 @@
         return -1;
     }
 
-    mSharedQuotaIfaces.erase(it);
-
     std::vector<std::string> cmds = {
         "*filter",
         StringPrintf("-D bw_INPUT -i %s --jump %s", iface.c_str(), chain),
         StringPrintf("-D bw_OUTPUT -o %s --jump %s", iface.c_str(), chain),
         StringPrintf("-D bw_FORWARD -o %s --jump %s", iface.c_str(), chain),
     };
-    if (mSharedQuotaIfaces.empty()) {
+    if (mSharedQuotaIfaces.size() == 1) {
         cmds.push_back(StringPrintf("-D %s -m quota2 ! --quota %" PRIu64
                                     " --name %s --jump REJECT",
                                     chain, mSharedQuotaBytes, cost));
-
-        mSharedQuotaBytes = 0;
-        if (mSharedAlertBytes) {
-            removeSharedAlert();
-            mSharedAlertBytes = 0;
-        }
     }
     cmds.push_back("COMMIT\n");
 
-    return iptablesRestoreFunction(V4V6, Join(cmds, "\n"), nullptr);
+    if (iptablesRestoreFunction(V4V6, Join(cmds, "\n"), nullptr) != 0) {
+        ALOGE("Failed to remove shared quota on %s", iface.c_str());
+        return -1;
+    }
+
+    int res = 0;
+    mSharedQuotaIfaces.erase(it);
+    if (mSharedQuotaIfaces.empty()) {
+        mSharedQuotaBytes = 0;
+        if (mSharedAlertBytes) {
+            res = removeSharedAlert();
+            if (res == 0) {
+                mSharedAlertBytes = 0;
+            }
+        }
+    }
+
+    return res;
+
 }
 
 int BandwidthController::setInterfaceQuota(const std::string& iface, int64_t maxBytes) {
@@ -547,7 +557,9 @@
 
     const int res = iptablesRestoreFunction(V4V6, Join(cmds, "\n"), nullptr);
 
-    mQuotaIfaces.erase(it);
+    if (res == 0) {
+        mQuotaIfaces.erase(it);
+    }
 
     return res;
 }