Disable sensitive logs
- PII logs can only appear in VERBOSE level
- logSeverityStrToEnum() no more support VERBOSE level input, only
accept DEBUG, INFO, WARNING, and ERROR.
- developer can set DBG flag from code to have a debug build, the DEBUG
level is automatically promote to VERBOSE.
- uniform log format to [FILE NAME]: [FUNC NAME]: [MSG]
- move from ALOG to LOG on DnsProxyListener
- adjust severity for some logs
- correct print format on uint8_t type
Bug: 128736560
Test: builds, boots
Test: atest resolv_integration_test
Change-Id: I0ff03824901168165bbe1f5abae9ff3e74db63d6
diff --git a/resolv/DnsResolver.cpp b/resolv/DnsResolver.cpp
index a9d2f85..822f860 100644
--- a/resolv/DnsResolver.cpp
+++ b/resolv/DnsResolver.cpp
@@ -27,7 +27,7 @@
bool resolv_init(const ResolverNetdCallbacks& callbacks) {
android::base::InitLogging(/*argv=*/nullptr);
android::base::SetDefaultTag("libnetd_resolv");
- LOG(INFO) << "Initializing resolver";
+ LOG(INFO) << __func__ << "Initializing resolver";
const std::string logSeverityStr =
android::base::GetProperty("persist.sys.nw_dns_resolver_log", "WARNING");
android::base::SetMinimumLogSeverity(logSeverityStrToEnum(logSeverityStr));
@@ -60,16 +60,16 @@
bool DnsResolver::start() {
if (!verifyCallbacks()) {
- LOG(ERROR) << "Callback verification failed";
+ LOG(ERROR) << __func__ << "Callback verification failed";
return false;
}
if (mDnsProxyListener.startListener()) {
- PLOG(ERROR) << "Unable to start DnsProxyListener";
+ PLOG(ERROR) << __func__ << "Unable to start DnsProxyListener";
return false;
}
binder_status_t ret;
if ((ret = DnsResolverService::start()) != STATUS_OK) {
- LOG(ERROR) << "Unable to start DnsResolverService: " << ret;
+ LOG(ERROR) << __func__ << "Unable to start DnsResolverService: " << ret;
return false;
}
return true;