Ensure icmp redirects are always ignored
A side effect of disabling the ip forwarding sysconf on all
interfaces is to re-enable the ICMP redirects sysconf on all
interfaces.
This patch ensures that ICMP redirects stays turned off when disabling
ip forwarding in TetherController.
Accepting ICMP redirects can allow an attacker to inject malicious
routes into a host and it is therefore desirable to always reject them.
Bug: 62387578
Bug: 77541904
Test: manual
Change-Id: I1f9a950eebf2f65d047f33145feee40d3ab34bd9
diff --git a/server/InterfaceController.h b/server/InterfaceController.h
index cd6f0eb..f97547f 100644
--- a/server/InterfaceController.h
+++ b/server/InterfaceController.h
@@ -43,6 +43,7 @@
static int setMtu(const char *interface, const char *mtu);
static int addAddress(const char *interface, const char *addrString, int prefixLength);
static int delAddress(const char *interface, const char *addrString, int prefixLength);
+ static int disableIcmpRedirects();
// Read and write values in files of the form:
// /proc/sys/net/<family>/<which>/<interface>/<parameter>