commit d662844d5bf03cb05805e8824746283c09e99a5c
author Ken Chen <cken@google.com> Wed Nov 14 15:59:41 2018 +0800
committer Ken Chen <cken@google.com> Mon Nov 19 14:25:46 2018 +0000
tree 3a45ea722ac375cf604f1e474846510ed3ee8531
parent 4abb043ed58128cb0f8ff381ebe9ef71c8c5253f

fix stack-use-after-scope in netd

Pointer 'ipLiteral' refers to volatile rvalue

Bug: 119496958
Test: compile and push libnetd_resolv.so to device. wifi can work
Change-Id: I1a043abb018301221cb4cbefa9ba9febbbaa7fbd

resolv/PrivateDnsConfiguration.cpp

diff --git a/resolv/PrivateDnsConfiguration.cpp b/resolv/PrivateDnsConfiguration.cpp
index b854a38..b32cf97 100644
--- a/resolv/PrivateDnsConfiguration.cpp
+++ b/resolv/PrivateDnsConfiguration.cpp
@@ -322,9 +322,9 @@
 
     // Invoke the callback to send a validation event to NetdEventListenerService.
     if (mCallback != nullptr) {
-        const char* ipLiteral = addrToString(&(server.ss)).c_str();
+        const std::string ipLiteral = addrToString(&(server.ss));
         const char* hostname = server.name.empty() ? "" : server.name.c_str();
-        mCallback(netId, ipLiteral, hostname, success);
+        mCallback(netId, ipLiteral.c_str(), hostname, success);
     }
 
     if (success) {