commit f253caa2f95cc1dfb42acf91049a44db9c0e3771
author Maciej Żenczykowski <maze@google.com> Thu Apr 23 13:23:19 2020 +0000
committer Maciej Zenczykowski <maze@google.com> Thu Apr 23 13:43:37 2020 +0000
tree 1d3aa9ce2ce67785e35d83aeb20ddf6664986b35
parent 032b5db23f350e6723ea1902c50090905ad0738b

NdcDispatcher - fix bugprone-branch-clone warning

Fixes:
  system/netd/server/NdcDispatcher.cpp:274:56: warning: repeated branch in conditional chain [bugprone-branch-clone]

Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I58230a91a52e142b1cdc7d3c662156374c16e0c1
Merged-In: I58230a91a52e142b1cdc7d3c662156374c16e0c1

server/NdcDispatcher.cpp

diff --git a/server/NdcDispatcher.cpp b/server/NdcDispatcher.cpp
index 67abed2..48f7d9f 100644
--- a/server/NdcDispatcher.cpp
+++ b/server/NdcDispatcher.cpp
@@ -271,15 +271,9 @@
                                      true);
                         return 0;
                     }
-                } else if (!strcmp(flag, "broadcast")) {
-                    // currently ignored
-                } else if (!strcmp(flag, "multicast")) {
-                    // currently ignored
-                } else if (!strcmp(flag, "running")) {
-                    // currently ignored
-                } else if (!strcmp(flag, "loopback")) {
-                    // currently ignored
-                } else if (!strcmp(flag, "point-to-point")) {
+                } else if (!strcmp(flag, "broadcast") || !strcmp(flag, "multicast") ||
+                           !strcmp(flag, "running") || !strcmp(flag, "loopback") ||
+                           !strcmp(flag, "point-to-point")) {
                     // currently ignored
                 } else {
                     cli->sendMsg(ResponseCode::CommandParameterError, "Flag unsupported", false);