XfrmController.h - fix a virtual method call from destructor warning
Fixes:
system/netd/server/XfrmController.h:67:29: error: Call to virtual method 'XfrmSocket::close' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall,-warnings-as-errors]
virtual ~XfrmSocket() { close(); }
^
system/netd/server/XfrmController.cpp:630:5: note: Taking false branch
if (!isOk(ret)) {
^
system/netd/server/XfrmController.cpp:636:5: note: Taking true branch
if (!isOk(socketStatus)) {
^
system/netd/server/XfrmController.cpp:638:16: note: Calling implicit destructor for 'XfrmSocketImpl'
return socketStatus;
^
system/netd/server/XfrmController.cpp:638:16: note: Calling '~XfrmSocket'
Test: builds
Bug: 155351989
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I992c9899d9f9fc6a45fac28cad46db6331436099
Merged-In: I992c9899d9f9fc6a45fac28cad46db6331436099
diff --git a/server/XfrmController.h b/server/XfrmController.h
index 587647c..15eef3d 100644
--- a/server/XfrmController.h
+++ b/server/XfrmController.h
@@ -55,7 +55,8 @@
class XfrmSocket {
public:
- virtual void close() {
+ // called from destructor and thus cannot be virtual
+ void close() {
if (mSock >= 0) {
::close(mSock);
}