commit 2178081cd90ebcd77c867d52a8b0e15f0d4134cc
author Steven Moreland <smoreland@google.com> Fri Sep 11 01:29:45 2020 +0000
committer Treehugger Robot <treehugger-gerrit@google.com> Wed Sep 16 19:56:14 2020 +0000
tree 60121b57b0dfab00beb6ccd38826a05a0567daee
parent 40d398a0d28ad652afe1168d3abc7cd5231ae4de

Use AIDL_* errors over libbase logging.

This:
- gives us line numbers in source AIDL files reflecting errors
- makes it possible aidl_parser_fuzzer can detect when we return an
  error but don't provide any output logging

Bug: N/A
Test: aidl_unittest
Change-Id: I0479fd8d87547c1f0b1be754f9b8f6865db3cbef

parser.h

diff --git a/parser.h b/parser.h
index 23da269..0d39342 100644
--- a/parser.h
+++ b/parser.h
@@ -19,8 +19,8 @@
 #include "aidl_language.h"
 #include "aidl_typenames.h"
 #include "io_delegate.h"
+#include "logging.h"
 #include "options.h"
-#include <android-base/logging.h>
 
 #include <memory>
 #include <string>
@@ -88,7 +88,7 @@
   }
 
   const AidlDocument& ParsedDocument() const {
-    CHECK(!HasError());
+    AIDL_FATAL_IF(HasError(), FileName());
     return *document_;
   }