Add missing error for non-'+' string op.
Compiler was returning an error message without printing an error.
Future considerations: there are a lot of other errors the compiler
could be throwing here, for other things that are wrong, without
aborting early.
Fixes: 169628569
Test: aidl_parser_fuzzer tests/corpus/other_string_operation
Change-Id: I1131e8c530cf7c562a7af68e5036796f44976852
diff --git a/aidl_const_expressions.cpp b/aidl_const_expressions.cpp
index a4e26e0..bac8dac 100644
--- a/aidl_const_expressions.cpp
+++ b/aidl_const_expressions.cpp
@@ -846,8 +846,9 @@
// Handle String case first
if (left_val_->final_type_ == Type::STRING) {
+ AIDL_FATAL_IF(right_val_->final_type_ != Type::STRING, this);
if (!OPEQ("+")) {
- // invalid operation on strings
+ AIDL_ERROR(this) << "Only '+' is supported for strings, not '" << op_ << "'.";
final_type_ = Type::ERROR;
is_valid_ = false;
return false;